Re: [edk2] [PATCH 5/5] MdePkg/BaseSynchronizationLib GCC: simplify IA32 InternalSyncCompareExchange64()

2018-10-01 Thread Laszlo Ersek
On 10/01/18 20:27, Philippe Mathieu-Daudé wrote: > On 30/09/2018 00:23, Laszlo Ersek wrote: >> The IA32 variant of InternalSyncCompareExchange64() is correct, but we can >> simplify it. We don't need to load the lower 32 bits of ExchangeValue into >> EBX in two steps (first into a general

Re: [edk2] [PATCH 5/5] MdePkg/BaseSynchronizationLib GCC: simplify IA32 InternalSyncCompareExchange64()

2018-10-01 Thread Philippe Mathieu-Daudé
On 30/09/2018 00:23, Laszlo Ersek wrote: > The IA32 variant of InternalSyncCompareExchange64() is correct, but we can > simplify it. We don't need to load the lower 32 bits of ExchangeValue into > EBX in two steps (first into a general register, then into EBX); we can > ask GCC to populate EBX

[edk2] [PATCH 5/5] MdePkg/BaseSynchronizationLib GCC: simplify IA32 InternalSyncCompareExchange64()

2018-09-29 Thread Laszlo Ersek
The IA32 variant of InternalSyncCompareExchange64() is correct, but we can simplify it. We don't need to load the lower 32 bits of ExchangeValue into EBX in two steps (first into a general register, then into EBX); we can ask GCC to populate EBX like that itself. Cc: Liming Gao Cc: Michael D