Re: [edk2] [PATCH V2 03/15] MdeModulePkg Variable: Not get NV PCD in VariableWriteServiceInitialize

2019-01-15 Thread Zeng, Star
On 2019/1/15 14:37, Wang, Jian J wrote: Hi Star, One comment below. -Original Message- From: Zeng, Star Sent: Monday, January 14, 2019 11:20 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Wang, Jian J ; Wu, Hao A Subject: [PATCH V2 03/15] MdeModulePkg Variable: Not get NV PCD in Vari

Re: [edk2] [PATCH V2 03/15] MdeModulePkg Variable: Not get NV PCD in VariableWriteServiceInitialize

2019-01-14 Thread Wang, Jian J
Hi Star, One comment below. > -Original Message- > From: Zeng, Star > Sent: Monday, January 14, 2019 11:20 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Wang, Jian J ; > Wu, Hao A > Subject: [PATCH V2 03/15] MdeModulePkg Variable: Not get NV PCD in > VariableWriteServiceInitialize

Re: [edk2] [PATCH V2 03/15] MdeModulePkg Variable: Not get NV PCD in VariableWriteServiceInitialize

2019-01-14 Thread Zeng, Star
On 2019/1/15 13:48, Wu, Hao A wrote: Hi Star, One minor comment below. -Original Message- From: Zeng, Star Sent: Monday, January 14, 2019 11:20 PM To: edk2-devel@lists.01.org Cc: Zeng, Star; Wang, Jian J; Wu, Hao A Subject: [PATCH V2 03/15] MdeModulePkg Variable: Not get NV PCD in Vari

Re: [edk2] [PATCH V2 03/15] MdeModulePkg Variable: Not get NV PCD in VariableWriteServiceInitialize

2019-01-14 Thread Wu, Hao A
Hi Star, One minor comment below. > -Original Message- > From: Zeng, Star > Sent: Monday, January 14, 2019 11:20 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star; Wang, Jian J; Wu, Hao A > Subject: [PATCH V2 03/15] MdeModulePkg Variable: Not get NV PCD in > VariableWriteServiceInitialize

[edk2] [PATCH V2 03/15] MdeModulePkg Variable: Not get NV PCD in VariableWriteServiceInitialize

2019-01-14 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1323 Merge EmuVariable and Real variable driver. Add macro NV_STORAGE_VARIABLE_BASE. Not get NV PCD in VariableWriteServiceInitialize, but in FtwNotificationEvent/SmmFtwNotificationEvent, then VariableWriteServiceInitialize could be not aware the