Re: [edk2] [PATCH V3 04/12] MdeModulePkg: Upstream SerialDxe from EmbeddedPkg

2015-11-24 Thread Zeng, Star
On 2015/11/25 9:07, Kinney, Michael D wrote: Star, One minor issue in this patch. It mixes global variables and function prototypes. All the typedefs and function prototypes should come first, then globals, and then function implementation. The rest of the V3 series addresses all my V2

Re: [edk2] [PATCH V3 04/12] MdeModulePkg: Upstream SerialDxe from EmbeddedPkg

2015-11-24 Thread Kinney, Michael D
Star, One minor issue in this patch. It mixes global variables and function prototypes. All the typedefs and function prototypes should come first, then globals, and then function implementation. The rest of the V3 series addresses all my V2 feedback. Thanks! Mike > -Original

[edk2] [PATCH V3 04/12] MdeModulePkg: Upstream SerialDxe from EmbeddedPkg

2015-11-22 Thread Star Zeng
This Serial driver layers on top of a Serial Port Library instance to produce serial IO protocol. There is also another SerialDxe implementation in CorebootPayloadPkg, but SerialDxe from EmbeddedPkg should be better that also consumes the extended interfaces GetControl/SetControl/SetAttributes in