Thanks for your comments. I will update base on 1, 2, 3.
I have tested on Nt32Pkg and OvmfPkg to replace the PEIM debug lib with the new
one and add MdeModulePkg/Universal/DebugServicePei/DebugServicePei.inf with the
original PEIM DebugLib to dsc and fdf file.
The PEIMs which use the DebugLib
Zhichao:
For new library instance, I have some comments.
1) DebugPrint(). If DebugPpi is not found, directly return instead of
CpuDeadLoop().
2) DebugAssert(). If DebugPpi is not found, bases on PcdDebugPropertyMask value
to trig CpuDeadLoop() or CpuBreakPoint().
3) Please rename mDebugPpi
If it follows the EDK II C Coding Standards Specification, then ignore
my relating comments then,
Best Regards,
Hao Wu
> -Original Message-
> From: Gao, Zhichao
> Sent: Friday, March 22, 2019 10:19 AM
> To: Wu, Hao A; edk2-devel@lists.01.org
> Cc: Gao, Liming; Wang, Jian J; Ni, Ray;
For the sections you point. It seems good to watch the patch downloaded.
The indention is one or two space behind the function name depend on tab
expand(2 space).
Is it need to adjust them?
Thanks,
Zhichao
> -Original Message-
> From: Wu, Hao A
> Sent: Friday, March 22, 2019 10:09 AM
>
> -Original Message-
> From: Gao, Zhichao
> Sent: Thursday, March 21, 2019 10:05 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming; Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Sean Brogan;
> Michael Turner; Bret Barkelew
> Subject: [PATCH V4 16/17] MdeModulePkg/PeiDebugLibDebugPpi: Add
From: Liming Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395
Add a PEI debug library instance PeiDebugLibDebugPpi base on
DebugPpi. Using the combination of the DebugServicePei and
this lib instance can reduce the image size of PEI drivers.
Contributed-under: TianoCore
6 matches
Mail list logo
