Re: [edk2] [PATCH v2 2/3] MdeModulePkg/SerialDxe: Set FIFO depth with PCD

2016-03-24 Thread Laszlo Ersek
ng ; >> edk2-devel@lists.01.org ; >> Zeng, Star ; Ard Biesheuvel >> Subject: Re: [edk2] [PATCH v2 2/3] MdeModulePkg/SerialDxe: Set FIFO depth >> with PCD >> >> Hi folks, >> >> Please see my thoughts below: >> >> On 03/24/2016 12:26 AM,

Re: [edk2] [PATCH v2 2/3] MdeModulePkg/SerialDxe: Set FIFO depth with PCD

2016-03-24 Thread Ni, Ruiyu
y early mail to explain the calculation? Yes I saw it. Let's talk in that mail thread. > >Regards. > >Heyi > >>> Thanks. >>> >>> Heyi >>> >>> >>>> I'm sure you would all work it out ok, but that should have bee

Re: [edk2] [PATCH v2 2/3] MdeModulePkg/SerialDxe: Set FIFO depth with PCD

2016-03-23 Thread Heyi Guo
: Re: [edk2] [PATCH v2 2/3] MdeModulePkg/SerialDxe: Set FIFO depth with PCD Hi folks, Please see my thoughts below: On 03/24/2016 12:26 AM, Ryan Harkin wrote: On 23 March 2016 at 16:24, Ryan Harkin wrote: On 23 March 2016 at 08:53, Laszlo Ersek wrote: On 03/23/16 09:33, Ni, Ruiyu wrote

Re: [edk2] [PATCH v2 2/3] MdeModulePkg/SerialDxe: Set FIFO depth with PCD

2016-03-23 Thread Ni, Ruiyu
; >> >> >>> It's a shame, because it works on FVP models and copy/paste then works. >>> >>> I haven't made any investigations on what's going wrong. But regular >>> ASCII keys work, control codes like cursor keys don't. So it lo

Re: [edk2] [PATCH v2 2/3] MdeModulePkg/SerialDxe: Set FIFO depth with PCD

2016-03-23 Thread Ni, Ruiyu
an Harkin >; Zeng, Star > >Subject: Re: [edk2] [PATCH v2 2/3] MdeModulePkg/SerialDxe: Set FIFO depth with >PCD > >On 03/23/16 09:33, Ni, Ruiyu wrote: >> Laszlo, >> Since the patch below lets SerialDxe driver use the new introduced >> PCD gEfiMdePkgTokenSpaceGuid.Pcd

Re: [edk2] [PATCH v2 2/3] MdeModulePkg/SerialDxe: Set FIFO depth with PCD

2016-03-23 Thread Heyi Guo
; Tian, Feng ; Zeng, Star Subject: [edk2] [PATCH v2 2/3] MdeModulePkg/SerialDxe: Set FIFO depth with PCD Set UART receive FIFO depth with PCD instead of fixed number "1". The default value of PCD is also 1, so it makes no difference for platforms which do not explicitly set this PCD. C

Re: [edk2] [PATCH v2 2/3] MdeModulePkg/SerialDxe: Set FIFO depth with PCD

2016-03-23 Thread Laszlo Ersek
ng problem we discussed a few weeks ago. >> >> >>> Thanks >>> Laszlo >>> >>>> >>>> Regards, >>>> Ray >>>> >>>> >>>>> -Original Message- >>>>> From: edk2-devel [ma

Re: [edk2] [PATCH v2 2/3] MdeModulePkg/SerialDxe: Set FIFO depth with PCD

2016-03-23 Thread Ryan Harkin
>>> >>>> -----Original Message- >>>> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >>>> Heyi Guo >>>> Sent: Thursday, March 17, 2016 10:37 PM >>>> To: edk2-devel@lists.01.org >>>>

Re: [edk2] [PATCH v2 2/3] MdeModulePkg/SerialDxe: Set FIFO depth with PCD

2016-03-23 Thread Ryan Harkin
vel-boun...@lists.01.org] On Behalf Of Heyi >>> Guo >>> Sent: Thursday, March 17, 2016 10:37 PM >>> To: edk2-devel@lists.01.org >>> Cc: Heyi Guo ; Tian, Feng ; Zeng, >>> Star >>> Subject: [edk2] [PATCH v2 2/3] MdeModulePkg/SerialDxe: Set FIF

Re: [edk2] [PATCH v2 2/3] MdeModulePkg/SerialDxe: Set FIFO depth with PCD

2016-03-23 Thread Ni, Ruiyu
g ; Ard Biesheuvel >; edk2-devel@lists.01.org >; Heyi Guo ; Ryan Harkin >; Zeng, Star > >Subject: Re: [edk2] [PATCH v2 2/3] MdeModulePkg/SerialDxe: Set FIFO depth with >PCD > >On 03/23/16 09:33, Ni, Ruiyu wrote: >> Laszlo, >> Since the patch bel

Re: [edk2] [PATCH v2 2/3] MdeModulePkg/SerialDxe: Set FIFO depth with PCD

2016-03-23 Thread Laszlo Ersek
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Heyi >> Guo >> Sent: Thursday, March 17, 2016 10:37 PM >> To: edk2-devel@lists.01.org >> Cc: Heyi Guo ; Tian, Feng ; Zeng, >> Star >> Subject: [edk2] [PATCH v2 2/3] MdeModulePkg/SerialDxe: S

Re: [edk2] [PATCH v2 2/3] MdeModulePkg/SerialDxe: Set FIFO depth with PCD

2016-03-23 Thread Ni, Ruiyu
---Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Heyi Guo >Sent: Thursday, March 17, 2016 10:37 PM >To: edk2-devel@lists.01.org >Cc: Heyi Guo ; Tian, Feng ; Zeng, >Star >Subject: [edk2] [PATCH v2 2/3] MdeModulePkg/SerialDxe: Set FI

[edk2] [PATCH v2 2/3] MdeModulePkg/SerialDxe: Set FIFO depth with PCD

2016-03-19 Thread Heyi Guo
Set UART receive FIFO depth with PCD instead of fixed number "1". The default value of PCD is also 1, so it makes no difference for platforms which do not explicitly set this PCD. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo Cc: Feng Tian Cc: Star Zeng --- Md