Yes. I will remove it before checking in the codes. Thanks.
Regards,
Dandan
-Original Message-
From: Zeng, Star
Sent: Monday, June 19, 2017 12:55 PM
To: Bi, Dandan <dandan...@intel.com>; edk2-devel@lists.01.org
Cc: Ni, Ruiyu <ruiyu...@intel.com>; Gao, Liming <liming@intel.com>; Zeng,
Star <star.z...@intel.com>
Subject: RE: [edk2] [PATCH v2 4/8] MdePkg/HiiImageDecoder.h: Remove the
unnecessary comments
Just found below comments in MdePkg.dec, should it be removed also?
##
## In UEFI 2.6 spec,this guid value is duplicate with
## EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL_GUID. Now update this guid value to
## avoid the duplicate guid issue. So its value is not consistent with
## UEFI spec definition now. We have proposed to update UEFI spec to
## use this new guid. After new spec released, we will remove this
## comments.
##
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi
Sent: Monday, June 19, 2017 12:46 PM
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu <ruiyu...@intel.com>; Gao, Liming <liming@intel.com>
Subject: [edk2] [PATCH v2 4/8] MdePkg/HiiImageDecoder.h: Remove the unnecessary
comments
Cc: Liming Gao <liming@intel.com>
Cc: Ruiyu Ni <ruiyu...@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan...@intel.com>
---
MdePkg/Include/Protocol/HiiImageDecoder.h | 9 -
1 file changed, 9 deletions(-)
diff --git a/MdePkg/Include/Protocol/HiiImageDecoder.h
b/MdePkg/Include/Protocol/HiiImageDecoder.h
index 48a1a97..34eb5e1 100644
--- a/MdePkg/Include/Protocol/HiiImageDecoder.h
+++ b/MdePkg/Include/Protocol/HiiImageDecoder.h
@@ -16,19 +16,10 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER
EXPRESS OR IMPLIED.
#ifndef __HII_IMAGE_DECODER_H__
#define __HII_IMAGE_DECODER_H__
#include
-
-//
-// In UEFI 2.6 spec,this guid value is duplicate with -//
EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL_GUID. Now update this guid value to -// avoid
the duplicate guid issue. So its value is not consistent with -// UEFI spec
definition now. We have proposed to update UEFI spec to -// use this new guid.
After new spec released, we will remove this -// comments.
-//
#define EFI_HII_IMAGE_DECODER_PROTOCOL_GUID \
{0x9e66f251, 0x727c, 0x418c, { 0xbf, 0xd6, 0xc2, 0xb4, 0x25, 0x28, 0x18,
0xea }}
#define EFI_HII_IMAGE_DECODER_NAME_JPEG_GUID \
--
1.9.5.msysgit.1
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
