Re: [edk2] [PATCH v2 6/6] OvmfPkg/QemuVideoDxe: Bypass NULL pointer detection during VBE SHIM installing

2017-09-24 Thread Wang, Jian J
You're right that there's no such need. I just saw that this driver is loaded before EndOfDxe but missed the fact that it's actually started after that. So BIT7 of PcdNullPointerDetectionPropertyMask is enough. And thanks a lot for other feedbacks in another emails, especially for the catching

Re: [edk2] [PATCH v2 6/6] OvmfPkg/QemuVideoDxe: Bypass NULL pointer detection during VBE SHIM installing

2017-09-22 Thread Laszlo Ersek
On 09/22/17 13:50, Laszlo Ersek wrote: > This patch looks great to me, I would like to request a few small > updates: > > On 09/21/17 07:20, Jian J Wang wrote: >> QemuVideoDxe driver will install VBE SHIM into page 0. If NULL pointer > > (1) please replace the word "install" with "link". > > The

Re: [edk2] [PATCH v2 6/6] OvmfPkg/QemuVideoDxe: Bypass NULL pointer detection during VBE SHIM installing

2017-09-22 Thread Laszlo Ersek
This patch looks great to me, I would like to request a few small updates: On 09/21/17 07:20, Jian J Wang wrote: > QemuVideoDxe driver will install VBE SHIM into page 0. If NULL pointer (1) please replace the word "install" with "link". The VBE Shim is technically installed into the "real-mode"

[edk2] [PATCH v2 6/6] OvmfPkg/QemuVideoDxe: Bypass NULL pointer detection during VBE SHIM installing

2017-09-20 Thread Jian J Wang
QemuVideoDxe driver will install VBE SHIM into page 0. If NULL pointer detection is enabled, this driver will fail to load. NULL pointer detection bypassing code is added to prevent such problem during boot. Please note that Windows 7 will try to access VBE SHIM during boot if it's installed, and