Re: [edk2] [PATCH v4 0/7] BaseTools: add support for GCC5 in LTO mode

2016-08-01 Thread Ard Biesheuvel
On 1 August 2016 at 04:26, Gao, Liming wrote: > Ard: > My GNU ld (GNU Binutils for Ubuntu) 2.24. Which version you use? > > 1. #pragma GCC visibility push (hidden) , GCC5 with GCC49 tool chain pass. > GCC5 with GCC5 tool chain failure. Here is failure message. > GenFw:

Re: [edk2] [PATCH v4 0/7] BaseTools: add support for GCC5 in LTO mode

2016-07-31 Thread Gao, Liming
Ard: My GNU ld (GNU Binutils for Ubuntu) 2.24. Which version you use? 1. #pragma GCC visibility push (hidden) , GCC5 with GCC49 tool chain pass. GCC5 with GCC5 tool chain failure. Here is failure message. GenFw: Elf64Convert.c:424: ScanSections64: Assertion `((BOOLEAN)(0==1))' failed. GenFw:

Re: [edk2] [PATCH v4 0/7] BaseTools: add support for GCC5 in LTO mode

2016-07-31 Thread Ard Biesheuvel
On 30 July 2016 at 16:34, Ard Biesheuvel wrote: > On 29 July 2016 at 17:18, Gao, Liming wrote: >> Ard: >> >> My gcc version 5.3.0 20151204 (Ubuntu 5.3.0-3ubuntu1~14.04). I will try >> GCC54. >> > > I cannot reproduce this with 5.3.1-14ubuntu2.1

Re: [edk2] [PATCH v4 0/7] BaseTools: add support for GCC5 in LTO mode

2016-07-30 Thread Ard Biesheuvel
On 29 July 2016 at 17:18, Gao, Liming wrote: > Ard: > > My gcc version 5.3.0 20151204 (Ubuntu 5.3.0-3ubuntu1~14.04). I will try > GCC54. > I cannot reproduce this with 5.3.1-14ubuntu2.1 either. ___ edk2-devel mailing list

Re: [edk2] [PATCH v4 0/7] BaseTools: add support for GCC5 in LTO mode

2016-07-30 Thread Ard Biesheuvel
On 29 July 2016 at 22:33, Jordan Justen wrote: > On 2016-07-28 23:09:15, Ard Biesheuvel wrote: >> On 29 July 2016 at 06:47, Gao, Liming wrote: >> > Ard: >> > Thanks for your update. I have some comments for them. >> > 1) It uses GCC as Link for

Re: [edk2] [PATCH v4 0/7] BaseTools: add support for GCC5 in LTO mode

2016-07-29 Thread Jordan Justen
On 2016-07-28 23:09:15, Ard Biesheuvel wrote: > On 29 July 2016 at 06:47, Gao, Liming wrote: > > Ard: > > Thanks for your update. I have some comments for them. > > 1) It uses GCC as Link for GCC44-GCC49. Have you done verification on them? > > I verify GCC49 in

Re: [edk2] [PATCH v4 0/7] BaseTools: add support for GCC5 in LTO mode

2016-07-29 Thread Ard Biesheuvel
On 29 July 2016 at 17:18, Gao, Liming wrote: > Ard: > > My gcc version 5.3.0 20151204 (Ubuntu 5.3.0-3ubuntu1~14.04). I will try > GCC54. > Could you check if the issue also occurs with the 'old' GCC49, i.e., the version that uses LD as the linker? > > > Besides, for

Re: [edk2] [PATCH v4 0/7] BaseTools: add support for GCC5 in LTO mode

2016-07-29 Thread Gao, Liming
Ard: My gcc version 5.3.0 20151204 (Ubuntu 5.3.0-3ubuntu1~14.04). I will try GCC54. Besides, for new GCC5 tool chain, could you add one brief introduction in tools_def.txt like GCC49? And, highlight it enable LTO by default. # GCC49 -Linux,Windows- Requires: #

Re: [edk2] [PATCH v4 0/7] BaseTools: add support for GCC5 in LTO mode

2016-07-29 Thread Ard Biesheuvel
On 29 July 2016 at 08:09, Ard Biesheuvel wrote: > On 29 July 2016 at 06:47, Gao, Liming wrote: >> Ard: >> Thanks for your update. I have some comments for them. >> 1) It uses GCC as Link for GCC44-GCC49. Have you done verification on them? >> I

Re: [edk2] [PATCH v4 0/7] BaseTools: add support for GCC5 in LTO mode

2016-07-28 Thread Gao, Liming
Ard: Thanks for your update. I have some comments for them. 1) It uses GCC as Link for GCC44-GCC49. Have you done verification on them? I verify GCC49 in OVMFIa32X64 platform. It works. 2) After this change, how to append new link option in platform DSC? Use style -Wl, ? 3) I see GCC5 uses

[edk2] [PATCH v4 0/7] BaseTools: add support for GCC5 in LTO mode

2016-07-27 Thread Ard Biesheuvel
This v4 to introduce GCC5 is now a 7 piece series, including some preparatory cleanup patches that allow all GCC4x and CLANG35 toolchains to switch to using 'gcc' as the linker. This allows us to get rid of the wrapper script to marshall ld arguments in order to make them understandable by gcc,