Re: [edk2] [PATCH v5] BaseTools/Scripts/PatchCheck.py: Extended patch style check for c code

2016-12-14 Thread Jordan Justen
The patch subject seems too generic, but I think that is because the patch is doing too many things at once. (See more comments below.) On 2016-12-13 06:15:18, Daniil Egranov wrote: > Corrected code checking for multi-line and commented lines. Both > multi-line and open comment flags will be

Re: [edk2] [PATCH v5] BaseTools/Scripts/PatchCheck.py: Extended patch style check for c code

2016-12-13 Thread Gao, Liming
016 10:15 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming <liming@intel.com>; leif.lindh...@linaro.org > Subject: [edk2] [PATCH v5] BaseTools/Scripts/PatchCheck.py: Extended > patch style check for c code > > Corrected code checking for multi-line and commented lines. Both

[edk2] [PATCH v5] BaseTools/Scripts/PatchCheck.py: Extended patch style check for c code

2016-12-13 Thread Daniil Egranov
Corrected code checking for multi-line and commented lines. Both multi-line and open comment flags will be reset when leaving diff "+" area of the patch. Changed version of the tool to 0.2. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daniil Egranov