Re: [edk2] [Patch 1/2] BaseTools VfrCompiler: In order to keep consistent, add an optional "; " for condition op-code.

2015-10-14 Thread Leif Lindholm
On Wed, Oct 14, 2015 at 04:29:27PM +0800, Eric Dong wrote: > In current implementation, the "endif" opcode for suppressif has an end ";" > for the statement opcode, but not for the option opcode. This is not a user > friendly grammar. So this patch fixed this issue. Add an optional ";" end for

[edk2] [Patch 1/2] BaseTools VfrCompiler: In order to keep consistent, add an optional "; " for condition op-code.

2015-10-14 Thread Eric Dong
In current implementation, the "endif" opcode for suppressif has an end ";" for the statement opcode, but not for the option opcode. This is not a user friendly grammar. So this patch fixed this issue. Add an optional ";" end for option opcode to keep consistent with existed code. The same case

Re: [edk2] [Patch 1/2] BaseTools VfrCompiler: In order to keep consistent, add an optional "; " for condition op-code.

2015-10-14 Thread Dong, Eric
Leif, Got it, I will update the format to follow the BaseTools/Contributions.txt. Thanks for your comments. Thanks, Eric -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Leif Lindholm Sent: Wednesday, October 14, 2015 10:32 PM To: Dong, Eric Cc: