Re: [edk2] [Patch V2 0/9] Add DisplayUpdateProgressLib for capsules

2018-04-22 Thread Zeng, Star
Mike, Thanks for the clarification. Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Kinney, Michael D Sent: Saturday, April 21, 2018 7:12 AM To: Zeng, Star ; Yao, Jiewen ; edk2-devel@lists.01.org; Kinney,

Re: [edk2] [Patch V2 0/9] Add DisplayUpdateProgressLib for capsules

2018-04-20 Thread Kinney, Michael D
Star, I did consider a PCD based method and I even prototyped it. It does work. However, it uses the Dynamic PCD memory database as a shared resource between all the FMP modules and depends on the FMP modules to set the PCDs when their SetImage() service is called. Since not all FMP modules

Re: [edk2] [Patch V2 0/9] Add DisplayUpdateProgressLib for capsules

2018-04-20 Thread Kinney, Michael D
Jiewen, Thanks for the reminder. I will add a 32-bit Version field. Mike > -Original Message- > From: Yao, Jiewen > Sent: Thursday, April 19, 2018 9:23 PM > To: Kinney, Michael D ; > edk2-devel@lists.01.org > Cc: Sean Brogan ;

Re: [edk2] [Patch V2 0/9] Add DisplayUpdateProgressLib for capsules

2018-04-19 Thread Sean Brogan
Reviewed-by: Sean Brogan -Original Message- From: Kinney, Michael D Sent: Wednesday, April 11, 2018 5:48 PM To: edk2-devel@lists.01.org Cc: Sean Brogan ; Zeng, Star ; Dong, Eric

Re: [edk2] [Patch V2 0/9] Add DisplayUpdateProgressLib for capsules

2018-04-19 Thread Zeng, Star
I also had another comment to the protocol at https://lists.01.org/pipermail/edk2-devel/2018-April/023720.html before. Thanks, Star -Original Message- From: Yao, Jiewen Sent: Friday, April 20, 2018 12:23 PM To: Kinney, Michael D ; edk2-devel@lists.01.org Cc:

Re: [edk2] [Patch V2 0/9] Add DisplayUpdateProgressLib for capsules

2018-04-19 Thread Yao, Jiewen
Thanks Mike. I still think we should add a Version flag for EDKII_FIRMWARE_MANAGEMENT_PROGRESS_PROTOCOL for future extension, as we discussed in V1. Other update seems good to me. Reviewed-by: jiewen@intel.com Thank you Yao Jiewen > -Original Message- > From: Kinney, Michael D

Re: [edk2] [Patch V2 0/9] Add DisplayUpdateProgressLib for capsules

2018-04-11 Thread Kinney, Michael D
I have also posted a branch for review. https://github.com/mdkinney/edk2/tree/Bug_801_DisplayUpdateProgressLib_V2 Mike > -Original Message- > From: Kinney, Michael D > Sent: Wednesday, April 11, 2018 5:48 PM > To: edk2-devel@lists.01.org > Cc: Sean Brogan ;

[edk2] [Patch V2 0/9] Add DisplayUpdateProgressLib for capsules

2018-04-11 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=801 Based on content from: https://github.com/Microsoft/MS_UEFI/blob/share/MsCapsuleSupport/MsCapsuleUpdatePkg/Include/Library/DisplayUpdateProgressLib.h