Re: [edk2] [Patch v2] UefiCpuPkg/PiSmmCpuDxeSmm: Add EFIAPI to CheckFeatureSupported()

2016-02-22 Thread Kinney, Michael D
.com>; Laszlo Ersek <ler...@redhat.com> > Subject: RE: [edk2] [Patch v2] UefiCpuPkg/PiSmmCpuDxeSmm: Add EFIAPI to > CheckFeatureSupported() > > Mike, > > One more comment. Please add the @param as blow in CheckFeatureSupported()'s > function > header. > > @param[

Re: [edk2] [Patch v2] UefiCpuPkg/PiSmmCpuDxeSmm: Add EFIAPI to CheckFeatureSupported()

2016-02-21 Thread Fan, Jeff
@lists.01.org Cc: Yao, Jiewen; Laszlo Ersek Subject: RE: [edk2] [Patch v2] UefiCpuPkg/PiSmmCpuDxeSmm: Add EFIAPI to CheckFeatureSupported() Reviewed-by: Jeff Fan <jeff@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Michael Kinne

Re: [edk2] [Patch v2] UefiCpuPkg/PiSmmCpuDxeSmm: Add EFIAPI to CheckFeatureSupported()

2016-02-19 Thread Laszlo Ersek
On 02/19/16 02:53, Michael Kinney wrote: > The function CheckFeatureSupported() is used as an EFI_AP_PROCEDURE > in the MP Services Protocol service StartAllAPs(). Any function > used as an EFI_AP_PROCEDURE must use EFIAPI calling convention. > > Cc: Laszlo Ersek > Cc: Jeff

Re: [edk2] [Patch v2] UefiCpuPkg/PiSmmCpuDxeSmm: Add EFIAPI to CheckFeatureSupported()

2016-02-18 Thread Fan, Jeff
tch v2] UefiCpuPkg/PiSmmCpuDxeSmm: Add EFIAPI to CheckFeatureSupported() The function CheckFeatureSupported() is used as an EFI_AP_PROCEDURE in the MP Services Protocol service StartAllAPs(). Any function used as an EFI_AP_PROCEDURE must use EFIAPI calling convention. Cc: Laszlo Ersek <ler...@r

[edk2] [Patch v2] UefiCpuPkg/PiSmmCpuDxeSmm: Add EFIAPI to CheckFeatureSupported()

2016-02-18 Thread Michael Kinney
The function CheckFeatureSupported() is used as an EFI_AP_PROCEDURE in the MP Services Protocol service StartAllAPs(). Any function used as an EFI_AP_PROCEDURE must use EFIAPI calling convention. Cc: Laszlo Ersek Cc: Jeff Fan Cc: Jiewen Yao