Re: [edk2] [Patch v3 3/3] UefiCpuPkg/MpInitLib: Load uCode once for each core.

2018-07-18 Thread Ni, Ruiyu
Thanks/Ray > -Original Message- > From: Dong, Eric > Sent: Wednesday, July 18, 2018 8:12 AM > To: Laszlo Ersek ; Ni, Ruiyu > Cc: edk2-devel@lists.01.org > Subject: RE: [edk2] [Patch v3 3/3] UefiCpuPkg/MpInitLib: Load uCode once > for each core.

Re: [edk2] [Patch v3 3/3] UefiCpuPkg/MpInitLib: Load uCode once for each core.

2018-07-17 Thread Dong, Eric
Hi Laszlo & Ray, > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, July 17, 2018 10:07 PM > To: Ni, Ruiyu ; Dong, Eric > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [Patch v3 3/3] UefiCpuPkg/MpInitLib: Load uCode once for &

Re: [edk2] [Patch v3 3/3] UefiCpuPkg/MpInitLib: Load uCode once for each core.

2018-07-17 Thread Laszlo Ersek
On 07/17/18 12:02, Ni, Ruiyu wrote: > On 7/16/2018 11:08 AM, Eric Dong wrote: >> GetProcessorLocationByApicId (GetInitialApicId (), NULL, NULL, >> ); >> +  if (ThreadId != 0) { >> +    // >> +    // Skip loading microcode if it is not the first thread in one core. >> +    // >> +    return; >> + 

Re: [edk2] [Patch v3 3/3] UefiCpuPkg/MpInitLib: Load uCode once for each core.

2018-07-17 Thread Ni, Ruiyu
On 7/16/2018 11:08 AM, Eric Dong wrote: GetProcessorLocationByApicId (GetInitialApicId (), NULL, NULL, ); + if (ThreadId != 0) { +// +// Skip loading microcode if it is not the first thread in one core. +// +return; + } + Eric, Is it possible that Thread#0 is disabled while

[edk2] [Patch v3 3/3] UefiCpuPkg/MpInitLib: Load uCode once for each core.

2018-07-15 Thread Eric Dong
The SDM requires only one thread per core to load the microcode. This change enables this solution. Cc: Laszlo Ersek Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- UefiCpuPkg/Library/MpInitLib/Microcode.c | 9 + 1 file changed, 9