Re: [edk2] [RFC] SATA : Implemented NXP errata A008402

2018-01-11 Thread Ard Biesheuvel
On 11 January 2018 at 02:25, Ni, Ruiyu wrote: > On 1/10/2018 5:52 PM, Ard Biesheuvel wrote: >> >> On 10 January 2018 at 09:43, Udit Kumar wrote: >>> >>> Hi Ruiyu, >>> -Original Message- > > > And this change will not impact any

Re: [edk2] [RFC] SATA : Implemented NXP errata A008402

2018-01-10 Thread Ni, Ruiyu
On 1/10/2018 5:52 PM, Ard Biesheuvel wrote: On 10 January 2018 at 09:43, Udit Kumar wrote: Hi Ruiyu, -Original Message- And this change will not impact any other hardware so no one is basically impacted by this change. Your buggy HW only need the value zero.

Re: [edk2] [RFC] SATA : Implemented NXP errata A008402

2018-01-10 Thread Udit Kumar
edk2-devel@lists.01.org; Zeng, Star > <star.z...@intel.com>; leif.lindh...@linaro.org > Subject: Re: [edk2] [RFC] SATA : Implemented NXP errata A008402 > > On 10 January 2018 at 09:43, Udit Kumar <udit.ku...@nxp.com> wrote: > > Hi Ruiyu, > > > >> -

Re: [edk2] [RFC] SATA : Implemented NXP errata A008402

2018-01-10 Thread Ard Biesheuvel
On 10 January 2018 at 09:43, Udit Kumar wrote: > Hi Ruiyu, > >> -Original Message- >> > >> > And this change will not impact any other hardware so no one is basically >> impacted by this change. >> >> Your buggy HW only need the value zero. But the addition of PCD

Re: [edk2] [RFC] SATA : Implemented NXP errata A008402

2018-01-10 Thread Udit Kumar
Hi Ruiyu, > -Original Message- > > > > And this change will not impact any other hardware so no one is basically > impacted by this change. > > Your buggy HW only need the value zero. But the addition of PCD exposes > an interface that can use any size of PRD. > I am not sure the

Re: [edk2] [RFC] SATA : Implemented NXP errata A008402

2018-01-10 Thread Ni, Ruiyu
On 1/10/2018 4:56 PM, Meenakshi Aggarwal wrote: -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ni, Ruiyu Sent: Tuesday, January 09, 2018 9:11 AM To: edk2-devel@lists.01.org Subject: Re: [edk2] [RFC] SATA : Implemented NXP errata A008402 On 1

Re: [edk2] [RFC] SATA : Implemented NXP errata A008402

2018-01-10 Thread Meenakshi Aggarwal
> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ni, > Ruiyu > Sent: Tuesday, January 09, 2018 9:11 AM > To: edk2-devel@lists.01.org > Subject: Re: [edk2] [RFC] SATA : Implemented NXP errata A008402 > > On 1/8/2018 7:1

Re: [edk2] [RFC] SATA : Implemented NXP errata A008402

2018-01-08 Thread Ni, Ruiyu
On 1/8/2018 7:16 PM, Meenakshi Aggarwal wrote: Description: Commands with 4 MB PRD length entries fail if PRD[DBC] is set to the value according to AHCI standard spec. Due to a logic error, 3F_h is misinterpreted by the device as zero length. Is the logic error mentioned here is the error

Re: [edk2] [RFC] SATA : Implemented NXP errata A008402

2018-01-08 Thread Meenakshi Aggarwal
de...@lists.01.org; Dong, Eric <eric.d...@intel.com> > Cc: Ni, Ruiyu <ruiyu...@intel.com>; Zeng, Star <star.z...@intel.com> > Subject: RE: [edk2] [RFC] SATA : Implemented NXP errata A008402 > > How will the code work based on your patch if the this PCD is conf

Re: [edk2] [RFC] SATA : Implemented NXP errata A008402

2018-01-08 Thread Zeng, Star
com>; ard.biesheu...@linaro.org; leif.lindh...@linaro.org; edk2-devel@lists.01.org; Dong, Eric <eric.d...@intel.com> Cc: Ni, Ruiyu <ruiyu...@intel.com> Subject: RE: [edk2] [RFC] SATA : Implemented NXP errata A008402 > -Original Message- > From: Zeng, Star [mailto:sta

Re: [edk2] [RFC] SATA : Implemented NXP errata A008402

2018-01-08 Thread Meenakshi Aggarwal
ic.d...@intel.com> > Cc: Ni, Ruiyu <ruiyu...@intel.com>; Zeng, Star <star.z...@intel.com> > Subject: RE: [edk2] [RFC] SATA : Implemented NXP errata A008402 > > So this PCD needs to be defined as 0x3F or may be 0x40, then it > needs to be configured to 0 for

Re: [edk2] [RFC] SATA : Implemented NXP errata A008402

2018-01-08 Thread Zeng, Star
.org; edk2-devel@lists.01.org; Dong, Eric <eric.d...@intel.com> Cc: Ni, Ruiyu <ruiyu...@intel.com> Subject: RE: [edk2] [RFC] SATA : Implemented NXP errata A008402 Hi Star, Apologies and some correction in my last reply. As per the errata, PRDT Maximum value needs to be set to 0 only

Re: [edk2] [RFC] SATA : Implemented NXP errata A008402

2018-01-07 Thread Meenakshi Aggarwal
gar...@nxp.com>; > > ard.biesheu...@linaro.org; leif.lindh...@linaro.org; edk2- > > de...@lists.01.org; Dong, Eric <eric.d...@intel.com> > > Cc: Ni, Ruiyu <ruiyu...@intel.com>; Zeng, Star <star.z...@intel.com> > > Subject: RE: [edk2] [RFC]

Re: [edk2] [RFC] SATA : Implemented NXP errata A008402

2018-01-07 Thread Meenakshi Aggarwal
Cc: Ni, Ruiyu <ruiyu...@intel.com>; Zeng, Star <star.z...@intel.com> > Subject: RE: [edk2] [RFC] SATA : Implemented NXP errata A008402 > > Do you have a full patch already? > Why the PcdPrdtMaxDataLength is defined to 0x3F, but not 0x40? > > > Thanks, > St

Re: [edk2] [RFC] SATA : Implemented NXP errata A008402

2018-01-07 Thread Zeng, Star
...@linaro.org; leif.lindh...@linaro.org; edk2-devel@lists.01.org; Zeng, Star <star.z...@intel.com>; Dong, Eric <eric.d...@intel.com> Subject: [edk2] [RFC] SATA : Implemented NXP errata A008402 Description: Commands with 4 MB PRD length entries fail if PRD[DBC] is set to the value accor

[edk2] [RFC] SATA : Implemented NXP errata A008402

2018-01-07 Thread Meenakshi Aggarwal
Description: Commands with 4 MB PRD length entries fail if PRD[DBC] is set to the value according to AHCI standard spec. Due to a logic error, 3F_h is misinterpreted by the device as zero length. Workaround: Set PRD length to 0 when creating a PRD entry for a maximum data transfer size of 4