Re: [edk2] [edk2-test][PATCH] SctPkg/Tools: Fix incorrect line ending detection by GenBin tool

2018-11-27 Thread Lokesh Belathur Veerappa
Hi Supreeth, The GenBin tool was not being rebuilt due to the existence of previously built intermediate binary. To resolve this, intermediate binary has to be cleaned after the build. I will upload the new patch with the this change. Thanks, Lokesh -Original Message- From: Supreeth Ve

Re: [edk2] [edk2-test][PATCH] SctPkg/Tools: Fix incorrect line ending detection by GenBin tool

2018-11-27 Thread Supreeth Venkatesh
Lokesh, I had applied the GenBin tool rebuild patch before this. I will check again on my side but please recheck on your side. Thanks, Supreeth -Original Message- From: Lokesh Belathur Veerappa Sent: Tuesday, November 27, 2018 2:04 AM To: Supreeth Venkatesh ; edk2-devel@lists.01.org;

Re: [edk2] [edk2-test][PATCH] SctPkg/Tools: Fix incorrect line ending detection by GenBin tool

2018-11-27 Thread Lokesh Belathur Veerappa
Hi Supreeth, The 'GenBin' tool has to be rebuilt with this change. The GenBin tool build support is added in the patch "[edk2-test][PATCH] SctPkg/build: Add support for GenBin tool build". I will upload a single patch which includes both the changes. Please verify and merge it. Thanks, Lokesh

Re: [edk2] [edk2-test][PATCH] SctPkg/Tools: Fix incorrect line ending detection by GenBin tool

2018-11-26 Thread Supreeth Venkatesh
With the latest edk2, I am getting this compilation error (even when this patch is applied). I will be looking at it tomorrow. Please check this out if you get a chance. GenBin /data/users/supreeth/supven01/work/sct_workspace/edk2/SctPkg/TestCase/UEFI/EFI/Protocol/Decompress/BlackBoxTest/Depend

Re: [edk2] [edk2-test][PATCH] SctPkg/Tools: Fix incorrect line ending detection by GenBin tool

2018-11-20 Thread Jin, Eric
Please don't forget to change the copyright info when commit patch. Reviewed-by: Eric Jin -Original Message- From: Lokesh B V Sent: Tuesday, November 20, 2018 2:50 PM To: edk2-devel@lists.01.org; supreeth.venkat...@arm.com; Jin, Eric Cc: Lokesh B V Subject: [edk2-test][PATCH] SctPkg/

[edk2] [edk2-test][PATCH] SctPkg/Tools: Fix incorrect line ending detection by GenBin tool

2018-11-19 Thread Lokesh B V
Some windows editors uses "\r\n" for line feed. While processing uefi testcase info file, the GenBin tool logic to skip line feed doesn't consider the presence of carraige return(\r) in line feed. So this results in incorrect format error. Signed-off-by: Lokesh B V --- uefi-sct/SctPkg/Tools/Sour