Re: [edk2] [patch] ShellPkg/Dh: Refine variable naming style

2017-09-28 Thread Carsey, Jaben 
Reviewed-by: Jaben Carsey 

> -Original Message-
> From: Ni, Ruiyu
> Sent: Wednesday, September 27, 2017 10:57 PM
> To: Bi, Dandan ; edk2-devel@lists.01.org
> Cc: Carsey, Jaben 
> Subject: RE: [patch] ShellPkg/Dh: Refine variable naming style
> Importance: High
> 
> Reviewed-by: Ruiyu Ni 
> 
> Thanks/Ray
> 
> > -Original Message-
> > From: Bi, Dandan
> > Sent: Thursday, September 28, 2017 10:45 AM
> > To: edk2-devel@lists.01.org
> > Cc: Ni, Ruiyu ; Carsey, Jaben
> 
> > Subject: [patch] ShellPkg/Dh: Refine variable naming style
> >
> > Avoid using only lower-case characters for variable name.
> >
> > Cc: Ruiyu Ni 
> > Cc: Jaben Carsey 
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Dandan Bi 
> > ---
> >  ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
> > b/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
> > index 7d06163..a7bd251 100644
> > --- a/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
> > +++ b/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
> > @@ -284,11 +284,11 @@ GetProtocolInfoString(
> >EFI_STATUSStatus;
> >CHAR16*RetVal;
> >UINTN Size;
> >CHAR16*Temp;
> >CHAR16GuidStr[40];
> > -  VOID  *instance;
> > +  VOID  *Instance;
> >CHAR16InstanceStr[17];
> >
> >ProtocolGuidArray = NULL;
> >RetVal= NULL;
> >Size  = 0;
> > @@ -314,14 +314,14 @@ GetProtocolInfoString(
> >  FreePool(Temp);
> >}
> >StrnCatGrow(, , L"%N", 0);
> >
> >if(Verbose) {
> > -Status = gBS->HandleProtocol (TheHandle,
> > ProtocolGuidArray[ProtocolIndex], );
> > +Status = gBS->HandleProtocol (TheHandle,
> > ProtocolGuidArray[ProtocolIndex], );
> >  if (!EFI_ERROR (Status)) {
> >StrnCatGrow (, , L"(%H", 0);
> > -  UnicodeSPrint (InstanceStr, sizeof (InstanceStr), L"%x", 
> > instance);
> > +  UnicodeSPrint (InstanceStr, sizeof (InstanceStr), L"%x", 
> > Instance);
> >StrnCatGrow (, , InstanceStr, 0);
> >StrnCatGrow (, , L"%N)", 0);
> >  }
> >}
> >
> > --
> > 1.9.5.msysgit.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [patch] ShellPkg/Dh: Refine variable naming style

2017-09-27 Thread Ni, Ruiyu 
Reviewed-by: Ruiyu Ni 

Thanks/Ray

> -Original Message-
> From: Bi, Dandan
> Sent: Thursday, September 28, 2017 10:45 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Carsey, Jaben 
> Subject: [patch] ShellPkg/Dh: Refine variable naming style
> 
> Avoid using only lower-case characters for variable name.
> 
> Cc: Ruiyu Ni 
> Cc: Jaben Carsey 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Dandan Bi 
> ---
>  ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
> b/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
> index 7d06163..a7bd251 100644
> --- a/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
> +++ b/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
> @@ -284,11 +284,11 @@ GetProtocolInfoString(
>EFI_STATUSStatus;
>CHAR16*RetVal;
>UINTN Size;
>CHAR16*Temp;
>CHAR16GuidStr[40];
> -  VOID  *instance;
> +  VOID  *Instance;
>CHAR16InstanceStr[17];
> 
>ProtocolGuidArray = NULL;
>RetVal= NULL;
>Size  = 0;
> @@ -314,14 +314,14 @@ GetProtocolInfoString(
>  FreePool(Temp);
>}
>StrnCatGrow(, , L"%N", 0);
> 
>if(Verbose) {
> -Status = gBS->HandleProtocol (TheHandle,
> ProtocolGuidArray[ProtocolIndex], );
> +Status = gBS->HandleProtocol (TheHandle,
> ProtocolGuidArray[ProtocolIndex], );
>  if (!EFI_ERROR (Status)) {
>StrnCatGrow (, , L"(%H", 0);
> -  UnicodeSPrint (InstanceStr, sizeof (InstanceStr), L"%x", instance);
> +  UnicodeSPrint (InstanceStr, sizeof (InstanceStr), L"%x", Instance);
>StrnCatGrow (, , InstanceStr, 0);
>StrnCatGrow (, , L"%N)", 0);
>  }
>}
> 
> --
> 1.9.5.msysgit.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [patch] ShellPkg/Dh: Refine variable naming style

2017-09-27 Thread Dandan Bi 
Avoid using only lower-case characters for variable name.

Cc: Ruiyu Ni 
Cc: Jaben Carsey 
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi 
---
 ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c 
b/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
index 7d06163..a7bd251 100644
--- a/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
+++ b/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
@@ -284,11 +284,11 @@ GetProtocolInfoString(
   EFI_STATUSStatus;
   CHAR16*RetVal;
   UINTN Size;
   CHAR16*Temp;
   CHAR16GuidStr[40];
-  VOID  *instance;
+  VOID  *Instance;
   CHAR16InstanceStr[17];
 
   ProtocolGuidArray = NULL;
   RetVal= NULL;
   Size  = 0;
@@ -314,14 +314,14 @@ GetProtocolInfoString(
 FreePool(Temp);
   }
   StrnCatGrow(, , L"%N", 0);
 
   if(Verbose) {
-Status = gBS->HandleProtocol (TheHandle, 
ProtocolGuidArray[ProtocolIndex], );
+Status = gBS->HandleProtocol (TheHandle, 
ProtocolGuidArray[ProtocolIndex], );
 if (!EFI_ERROR (Status)) {
   StrnCatGrow (, , L"(%H", 0);
-  UnicodeSPrint (InstanceStr, sizeof (InstanceStr), L"%x", instance);
+  UnicodeSPrint (InstanceStr, sizeof (InstanceStr), L"%x", Instance);
   StrnCatGrow (, , InstanceStr, 0);
   StrnCatGrow (, , L"%N)", 0);
 }
   }
 
-- 
1.9.5.msysgit.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel