Re: [edk2] [platforms: PATCH 01/12] Marvell/Library: ArmadaSoCDescLib: Add GPIO information

2018-11-26 Thread Leif Lindholm
On Wed, Nov 21, 2018 at 02:26:23AM +0100, Marcin Wojtas wrote: > Hi Leif, > > śr., 14 lis 2018 o 18:33 Leif Lindholm napisał(a): > > > > On Wed, Nov 14, 2018 at 07:05:01AM +0100, Marcin Wojtas wrote: > > > > I think all of my comments on this patch can be summarised as "what is > > > > an AP in

Re: [edk2] [platforms: PATCH 01/12] Marvell/Library: ArmadaSoCDescLib: Add GPIO information

2018-11-20 Thread Marcin Wojtas
Hi Leif, śr., 14 lis 2018 o 18:33 Leif Lindholm napisał(a): > > On Wed, Nov 14, 2018 at 07:05:01AM +0100, Marcin Wojtas wrote: > > > I think all of my comments on this patch can be summarised as "what is > > > an AP in this context"? > > > > > > The term either needs explicit documenting, or

Re: [edk2] [platforms: PATCH 01/12] Marvell/Library: ArmadaSoCDescLib: Add GPIO information

2018-11-14 Thread Leif Lindholm
On Wed, Nov 14, 2018 at 07:05:01AM +0100, Marcin Wojtas wrote: > > I think all of my comments on this patch can be summarised as "what is > > an AP in this context"? > > > > The term either needs explicit documenting, or expansion in the macro > > names such that documentation is not required. >

Re: [edk2] [platforms: PATCH 01/12] Marvell/Library: ArmadaSoCDescLib: Add GPIO information

2018-11-13 Thread Marcin Wojtas
Hi Leif, śr., 14 lis 2018 o 02:10 Leif Lindholm napisał(a): > > On Sat, Oct 20, 2018 at 03:57:30AM +0200, Marcin Wojtas wrote: > > This patch introduces new library callback (ArmadaSoCDescGpioGet ()), > > which dynamically allocates and fills MV_SOC_GPIO_DESC structure with > > the SoC

[edk2] [platforms: PATCH 01/12] Marvell/Library: ArmadaSoCDescLib: Add GPIO information

2018-10-19 Thread Marcin Wojtas
This patch introduces new library callback (ArmadaSoCDescGpioGet ()), which dynamically allocates and fills MV_SOC_GPIO_DESC structure with the SoC description of GPIO controllers. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas ---