Re: [edk2] Vlan config protocol Query

2015-03-15 Thread Ye, Ting
Hi Sajeesh, I need more information to understand your question. As you said you are implementing EFI_VLAN_CONIFG_PROTOCOL in your UNDI driver, do you use your own network modules for PXE boot, or you use UEFI network stack? If you use UEFI network stack, MnpDxe driver already supplies EFI_VLAN

Re: [edk2] [PATCH] PeCoffExtraActionLibDebug: Restore debug registers in PeCoffExtraActionLibDebug

2015-03-15 Thread Fan, Jeff
Brian, Sorry, I missed this patch. Thank you finding and fixing this bug. Your patch looks good to me. One minimal comment is to remove the word "qemu" from the code comment, because we will avoid to use any specific platform information in core code. > +if ((NewDr7 & ~BIT10) == 0) { // H

Re: [edk2] Controller Handle in NetLibCreateServiceChild()

2015-03-15 Thread Ye, Ting
Hi Ritesh, EFI_TCP4_PROTOCOL does not support returning underlying socket information. If you want to use TCP socket you might refer to the socket library: https://svn.code.sf.net/p/edk2/code/trunk/edk2/AppPkg https://svn.code.sf.net/p/edk2/code/trunk/edk2/StdLib Best Regards, Ye Ting From: R

[edk2] [PATCH] ShellPkg: smbiosview update for SMBIOS 3.0

2015-03-15 Thread Li, Elvin
Hi Jaben, Could you help to review this update to UEFI shell smbiosview to dump   64-bit entry point and table? [Description]     I added the additional function that smbiosview can dump 64-bit entry point and table as long as SMBIOS 3.0 table exists in system configuration ta

Re: [edk2] [Patch] ShellPkg: Fix typo in ShellPkg.

2015-03-15 Thread Qiu, Shumin
Hi Bruce, Thanks for your comments. Update the patch. -Shumin -Original Message- From: Bruce Cran [mailto:bruce.c...@gmail.com] Sent: Sunday, March 15, 2015 5:09 AM To: edk2-devel@lists.sourceforge.net; Carsey, Jaben Subject: Re: [edk2] [Patch] ShellPkg: Fix typo 'caculate' in ShellPkg.

Re: [edk2] [PATCH v2 3/4] MdeModulePkg: XhciDxe: list ARM and AARCH64 as valid architectures

2015-03-15 Thread Tian, Feng
Good to me. Reviewed-by: Feng Tian -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Friday, March 13, 2015 22:36 To: edk2-devel@lists.sourceforge.net Cc: Tian, Feng Subject: [PATCH v2 3/4] MdeModulePkg: XhciDxe: list ARM and AARCH64 as valid architectures "ArmPla

[edk2] [PATCH] ArmPkg: Fixup of PTE attributes for coherent memory

2015-03-15 Thread Leo Duran
Coherent memory requires cacheability and shareability attributes. This patch ensures that cacheable memory include an 'inner shareable' attribute. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leo Duran --- ArmPkg/Include/Chipset/AArch64Mmu.h| 5 + ArmPkg/Li