Reviewed-by: Yingke Liu
Dennis
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Tuesday, July 14, 2015 3:52
To: Liu, Yingke D; edk2-devel@lists.sourceforge.net
Cc: Ard Biesheuvel
Subject: [PATCH] BaseTools/PeCoffLib: handle EFI_IMAGE_REL_BASED_DIR64 in
Reviewed-by: Yingke Liu
Thanks for your patch, it was committed at revision 17866.
Dennis
-Original Message-
From: Bruce Cran [mailto:br...@cran.org.uk]
Sent: Tuesday, July 07, 2015 18:15
To: Liu, Yingke D; edk2-devel@lists.sourceforge.net
Cc: Bruce Cran
Subject: [PATCH] BaseTools
ndoToken()
for Line in IncFileProfile.FileLinesList:
self.Profile.FileLinesList.insert(InsertAtLine, Line)
--
1.9.5.msysgit.0
Dennis
-Original Message-
From: Samer El-Haj-Mahmoud [mailto:samer.el-haj-mahm...@hp.com]
Sent: Thursday, July 02, 2015
Hi Ard,
Thanks for the comments, I have updated the log message.
Thanks,
Dennis
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Wednesday, July 01, 2015 16:12
To: Liu, Yingke D
Cc: edk2-devel@lists.sourceforge.net; Justen, Jordan L; Gao, Liming
Subject
Ard,
Following is the full GenFw patch, please confirm it:
BaseTools: Update GenFw to support 4K alignment.
Get maximum section alignment from ELF sections
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
BaseTools/Source/C/GenFw/Elf32Convert.c | 16 ++
Ard:
Thanks for your comments, update the script as following:
/* OUTPUT_FORMAT(efi-bsdrv-x86_64) */
SECTIONS
{
/* . = 0 + SIZEOF_HEADERS; */
. = 0x280;
.text:ALIGN(0x1000)
{
*(.text .stub .text.* .gnu.linkonce.t.*)
. = ALIGN(0x20);
}
.data: ALIGN(0x1000)
{
*(
.ro
Reviewed-by: Yingke Liu
Dennis
-Original Message-
From: Liming Gao [mailto:liming@intel.com]
Sent: Friday, June 19, 2015 9:30
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [Patch] BaseTools: Convert ".\\" to "" in FilePath
Convert ".\\" to "", because it doesn't work with WI
Jordan,
I'm OK for the patches. Thanks for your contribution.
Reviewed-by: Yingke Liu
Dennis
-Original Message-
From: Justen, Jordan L
Sent: Friday, June 12, 2015 15:11
To: Liu, Yingke D; edk2-devel@lists.sourceforge.net
Subject: Re: [PATCH v4 00/10] Support UTF-8 in .uni s
Yes, after this patch checked in, the bug you reported should be fixed.
Thanks,
Dennis
-Original Message-
From: Andrew Fish [mailto:af...@apple.com]
Sent: Wednesday, June 17, 2015 0:11
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] [Patch] BaseTools: Fixed Build Option overri
Liming,
1) TotalSize is the EXT header size
2) TotalSize is the whole EXT header size, and it is initianlized with 16 + 4
which is the size of EFI_FIRMWARE_VOLUME_EXT_HEADER.
Dennis
-Original Message-
From: Gao, Liming [mailto:liming@intel.com]
Sent: Thursday, June 11, 2015 23:18
T
Andrew,
The second one overrides first one by current behavior.
We will discuss the expected behavior. For workaround, following statement
should work:
XCODE:*_*_*_CC_FLAGS = -D ALPHA -D BETA
Thanks,
Dennis
-Original Message-
From: Andrew Fish [mailto:af...@apple.com]
Sent: Saturday
: Tuesday, May 19, 2015 11:32 PM
To: edk2-devel@lists.sourceforge.net; Gao, Liming; Liu, Yingke D
Subject: Re: [edk2] [Patch 1/2] BaseTools: Implement BUILDRULEORDER for
tools_def
Liming, for future reference, you might want to use
git commit --author="Yingke Liu "
when committing a
Hello,
Attached patch implemented BUILDRULEORDER feature.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Yingke Liu
Dennis
-Original Message-
From: Kinney, Michael D [mailto:michael.d.kin...@intel.com]
Sent: Wednesday, May 13, 2015 8:48 AM
To: edk2-devel@lists.
Patch looks good to me.
Reviewed-by: Yingke Liu
Dennis
From: Feng, Bob C
Sent: Thursday, May 07, 2015 5:15 PM
To: 'edk2-devel@lists.sourceforge.net'
Cc: ard.biesheu...@linaro.org; ard.biesheu...@linaro.org; Liu, Yingke D
Subject: [edk2] [patch] BaseTool : The PCD value in uninitia
k for NT32
X64 build
Hello Dennis,
Thanks for your suggestion. It makes sense to me. :)
Please review the attached file with using GlobalData.gGlobalDefines['ARCH']
instead.
Thanks,
Cinnamon Shia
From: Liu, Yingke D [mailto:yingke.d@intel.com]
Sent: Tuesday, December 16, 20
Hi Cinnamon Shia,
GlobalData.gCommandLineDefines['ARCH'] is command line arch list, its value
might be 'IA32 X64' if you specified '-a IA32 -a X64' on command line.
Please use GlobalData.gGlobalDefines['ARCH'] instead.
Thanks,
Dennis
From: Shia, Cinnamon [mailto:cinnamon.s...@hp.com]
Sent: Frid
Jim,
FDF spec limited that only $(WORKSPACE), $(ECP_SOURCE), $(EFI_SOURCE),
$(EDK_SOURCE) can be contained in !include path.
Dennis
From: jim_dai...@dell.com [mailto:jim_dai...@dell.com]
Sent: Thursday, December 11, 2014 11:57 PM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] FW: build.ex
Hi Cecil,
Thanks for your comments, I will follow up it. Thank you.
Dennis
From: Sheng, Cecil (HPS SW) [mailto:cecil.sh...@hp.com]
Sent: Thursday, December 04, 2014 8:26 AM
To: edk2-devel@lists.sourceforge.net
Cc: Liu, Yingke D
Subject: RE: [PATCH] BaseTool : Fix '/' handling in UNI
Richard,
Thanks for reporting this problem. I think we will fix it soon.
Thanks,
Dennis
From: Richard Mahn [mailto:rmah...@yahoo.com]
Sent: Wednesday, December 03, 2014 7:43 AM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] "build run" not properly handling x64 builds of Nt32
I've been tr
nk it's okay to keep it in this file. A similar function might be
needed for ANSI text files but it's not in the scope of the problem I wanted to
fix.
Sincerely,
Cecil Sheng
ISS Firmware Development
HP Servers
From: Liu, Yingke D [mailto:yingke.d@intel.com]
Sent: Wednesday, Nov
Reviewed-By: Olivier Martin
I can see this patch has not been merged. Dennis, are you happy to do it?
> -Original Message-
> From: Liu, Yingke D [mailto:yingke.d@intel.com]
> Sent: 24 November 2014 01:56
> To: Scott Duplichan; edk2-devel@lists.sourceforge.net
> Subject: Re
Hi Cecil,
Thanks for this patch.
Two comments about the patch:
1) Count '\"' might not be correct, for example a string with escaped
backslash: "some text\\"
2) I think the StripComments function is a common function which is better
to be defined out of the class.
Thanks,
Dennis
Fr
Scott,
Patch looks good to me.
Reviewed-by: Yingke Liu
Dennis
-Original Message-
From: Scott Duplichan [mailto:sc...@notabs.org]
Sent: Thursday, November 20, 2014 3:46 AM
To: edk2-devel@lists.sourceforge.net
Cc: Liu, Yingke D
Subject: [PATCH] BaseTools: Fix ARM build failure with gcc
al Message-
From: Scott Duplichan [mailto:sc...@notabs.org]
Sent: Thursday, November 06, 2014 10:56 PM
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] [PATCH] [BaseTools] Put all include search paths of a
module into a file
Liu, Yingke D [mailto:yingke.d@intel.com] wrote:
]Dear A
Dear All,
This patch is going to put all -I or /I options followed by include search path
into a file (inc.lst) just as object files and static library files.
There are cases that too many /I options on the command line, and NMAKE fails
due to command-line length limitation.
Please let me know
Patch is good to me.
Reviewed-by: Yingke Liu
Dennis
-Original Message-
From: Olivier Martin [mailto:olivier.mar...@arm.com]
Sent: Monday, November 03, 2014 7:04 PM
To: Liu, Yingke D
Cc: edk2-devel@lists.sourceforge.net; Olivier Martin
Subject: [PATCH] BaseTools/GenFw: Fixed
-
From: Liu, Yingke D [mailto:yingke.d@intel.com]
Sent: Sunday, September 28, 2014 3:43 PM
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] [RFC] BaseTools: Avoid hard coding of Visual Studio path
Scott,
A very good suggestion. We will evaluate it first. Thanks.
Dennis
-Original
Scott,
A very good suggestion. We will evaluate it first. Thanks.
Dennis
-Original Message-
From: Bruce Cran [mailto:bruce.c...@gmail.com]
Sent: Sunday, September 28, 2014 4:22 AM
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] [RFC] BaseTools: Avoid hard coding of Visual Studi
Hi,
Please review the patch to fix the regression bug:
BaseTools/Source/Python/GenFds/FfsInfStatement.py", line 448, in __ExtendMacro__
String = GenFdsGlobalVariable.MacroExtend(String, self.MacroDict)
AttributeError: OptRomInfStatement instance has no attribute 'MacroDict'
Contributed-un
Hi Hess,
The patch looks good to me.
Reviewed-by: Yingke Liu
Dennis
From: Chen, Hesheng [mailto:hesheng.c...@intel.com]
Sent: Wednesday, September 03, 2014 3:20 PM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [BaseTools] [Patch] Update AutoGen to copy binary files to
output directory o
Hi Samer,
It's really a good enhancement. Since it's a change to build output, we have to
evaluate if the new outputs impact current users or not.
Thanks,
Dennis
From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hp.com]
Sent: Tuesday, August 26, 2014 4:21 AM
To: edk2-devel@lists.sourcef
Hi Samer,
Thanks for this patch, it's really a good new feature, we will evaluate this
feature and let you know the feedback later.
Thanks,
Dennis
From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hp.com]
Sent: Tuesday, August 26, 2014 4:59 AM
To: edk2-devel@lists.sourceforge.net
Subject
Patch looks good to me.
Reviewed-by: Yingke Liu
Dennis
From: Feng, Bob C
Sent: Monday, August 25, 2014 1:49 PM
To: Liu, Yingke D; 'edk2-devel@lists.sourceforge.net'
Subject: RE: [edk2] [BaseTools]Implement the external PCD database generation
rule to support the case that all binary
Reviewed-by: Yingke Liu
Dennis
From: Chen, Hesheng [mailto:hesheng.c...@intel.com]
Sent: Monday, August 25, 2014 10:53 AM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [BaseTools]Support a force binary build mode
Hello all,
Could you help review this patch?
This patch is going to:
1.
Reviewed-by: Yingke Liu
Dennis
From: Chen, Hesheng [mailto:hesheng.c...@intel.com]
Sent: Thursday, August 21, 2014 2:44 PM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [ECC]Add some checkpoints for ECC tool
Hello all,
Could you help review this patch?
This patch is going to:
1. A
Hess,
The patch looks good to me.
Reviewed-by: Yingke Liu
Dennis
-Original Message-
From: Chen, Hesheng
Sent: Wednesday, August 20, 2014 3:31 PM
To: Jordan Justen; edk2-devel@lists.sourceforge.net; Liu, Yingke D
Subject: RE: [edk2] [PATCH] BaseTools: Revert r15816 and r15831 to fix
Hi Jordan,
The issue has been root caused. Before retiring top level makefile, the GenFds
command was executed by make fds, but after the change, we call GenFds command
directly. The -D option passed to Genfds is encapsulated by quotes which is
remove automatically by shell, that's why building
Hess,
The patch looks good to me.
Reviewed-by: Yingke Liu
Dennis
From: Chen, Hesheng [mailto:hesheng.c...@intel.com]
Sent: Friday, August 15, 2014 3:48 PM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [Patch][Basetools]Retire top level makefile on BaseTools
Hello all,
Could you help rev
Hess,
The patch is good.
Reviewed-by: Yingke Liu
Dennis
From: Chen, Hesheng [mailto:hesheng.c...@intel.com]
Sent: Thursday, August 14, 2014 3:16 PM
To: 'edk2-devel@lists.sourceforge.net'
Subject: [edk2] [Patch][Basetools]Enable long file path support on BaseTools
Hello all,
Could you help revi
Mike,
The basetools part is good to me.
Reviewed-by: Yingke Liu
Dennis
From: Kinney, Michael D [mailto:michael.d.kin...@intel.com]
Sent: Tuesday, August 12, 2014 11:39 AM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [Patch] RSA 2048 SHA 256 Signing Tools and Signature
Verification Modu
Olivier,
The patch is good to me.
Reviewed-by: Yingke Liu mailto:yingke.d@intel.com>>
Thanks,
Dennis
From: Olivier Martin [mailto:olivier.mar...@arm.com]
Sent: Saturday, August 02, 2014 2:22 AM
To: edk2-devel@lists.sourceforge.net; Wang, Yu
Cc: Harry Liebel
Subject: Re: [edk2] [PATCH] BaseT
Jordan,
It is good to me.
Reviewed-by: Yingke Liu
Best Regards,
Dennis
-Original Message-
From: Jordan Justen [mailto:jljus...@gmail.com]
Sent: Monday, July 28, 2014 1:39 PM
To: Mendyke, DanielX; Alain Kalker; Keshav Amburay; Liu, Yingke D
Cc: edk2-devel@lists.sourceforge.net
Subject
42 matches
Mail list logo
