Re: [edk2] ShellPkg patch: Handle pool allocation failure

2013-09-20 Thread Ryan Harkin
This is exactly my use-case for wanting to change FreePool() to allow it to take a NULL pointer without throwing an ASSERT. Just saying... On 19 September 2013 18:21, Carsey, Jaben wrote: > Reviewed-by: Jaben Carsey > > I will commit this. > > -Jaben > > -Original Message- > From: Ser

[edk2] Comparing two device paths

2013-09-20 Thread duck wilson
Is there and EDK2 library function to compare two device paths for being the same or different, i.e., equal or not equal? TIA! -- LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99! 1,500+ hours of tutoria

[edk2] [PATCH] OvmfPkg: EFI handover flags are in Bp->hdr.xloadflags

2013-09-20 Thread Matt Fleming
From: Matt Fleming LoadLinux() is looking at the wrong field for the kernel's EFI handover protocol flags. It's not currently possible for JumpToUefiKernel() to ever be called (even accidentally) because BIT2 and BIT3 of Bp->hdr.load_flags are never set in modern kernels, which means that control

Re: [edk2] Comparing two device paths

2013-09-20 Thread Carsey, Jaben
Look in SortLib in the ShellPkg. It's signature will be a little odd since it's return is based on quicksorting... /** Function to compare 2 device paths for use as CompareFunction. @param[in] Buffer1The pointer to Device Path to compare. @param[in] Buffer2The poin

Re: [edk2] UEFI Shell Scripting - exit command to exit the Shell

2013-09-20 Thread Carsey, Jaben
I just did a build on the tip of the shellpkg and I can't seem to duplicate this issue. I had a very small script (pasted below). Is it possible something else is causing an error? -Jaben Echo test exit From: Michael Lorer [mailto:michael.lo...@opus.de] Sent: Thursday, September 19, 2013

Re: [edk2] ShellPkg patch: Handle pool allocation failure

2013-09-20 Thread Sergei Antonov
Another similar case. ShellPkg: Handle pool allocation failure FreePool() will receive NULL if AllocateZeroPool() fails. So a check for NULL is needed. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Sergei Antonov UefiFileHandleLib.c.patch Description: Binary data ---

Re: [edk2] [PATCH 8/8] ArmPlatformPkg/ArmFvpDxe: Added Virtio Block support

2013-09-20 Thread Paolo Bonzini
Il 17/09/2013 18:54, Olivier Martin ha scritto: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Olivier Martin > --- > .../ArmVExpressPkg/ArmFvpDxe/ArmFvpDxe.c | 49 > +++- > .../ArmVExpressPkg/ArmFvpDxe/ArmFvpDxe.inf |3 + > ...

Re: [edk2] [PATCH 1/6] UefiCpuPkg/ResetVector/Vtf0: Move Page Table/CR3 setting to a new file

2013-09-20 Thread Laszlo Ersek
On 09/18/13 01:24, Jordan Justen wrote: > Now, Transition32FlatTo64Flat calls SetCr3ForPageTables64 > which is located in Ia32/PageTables64.asm. > > This change is required so OVMF can replace the code in > Ia32/PageTables64.asm with code that generates page tables in > RAM. > > Note: Since this

Re: [edk2] [PATCH v2 04/10] OvmfPkg/VirtioPciDeviceDxe: Implement VIRTIO_DEVICE_PROTOCOL for VirtIo Devices over PCI

2013-09-20 Thread Paolo Bonzini
Il 19/09/2013 22:30, Laszlo Ersek ha scritto: > In a nutshell, VirtioPciSetDeviceStatus() breaks the interface contract > of VIRTIO_DEVICE_PROTOCOL.WriteDevice(). The former targets a common > virtio field, but the latter provides access to device-specific fields. > Consequently, the virtio device

Re: [edk2] Driver Diagnostics Protocol for GBE LAN 82579

2013-09-20 Thread Richardson, Brian
I gave this info to the product team who maintains the UNDI driver. This was their response: "I've tested diagnostics on 'Intel(R) 82579LM Gigabit Network Connection', but every try is successful (both with cable connected and disconnected, also on every speed - Auto Neg, 10 Mbps Half, 10 Mbps

Re: [edk2] [PATCH v2 04/10] OvmfPkg/VirtioPciDeviceDxe: Implement VIRTIO_DEVICE_PROTOCOL for VirtIo Devices over PCI

2013-09-20 Thread Paolo Bonzini
Il 19/09/2013 15:56, Olivier Martin ha scritto: > + // Note: We should detect if the Device has MSI-X capability. In case the > device has > + // MSI-X capability then the offset would be 24. > + Device->DeviceSpecificConfigurationOffset = 20; The offset does not move from 20 to 24 unles

Re: [edk2] [PATCH 2/6] OvmfPkg: Add platform specific reset vector code for X64

2013-09-20 Thread Laszlo Ersek
On 09/18/13 01:24, Jordan Justen wrote: > KVM has a bug that prevents using page tables in the ROM if the ROM > region utilizes the KVM READONLY memory feature. Therefore, we > avoid using page tables stored in the ROM. > > Since OVMF doesn't require memory initialization, we just build > page tabl

Re: [edk2] [PATCH 0/6] OvmfPkg: Fix KVM boot issue with QEMU 1.6 and no-EPT support

2013-09-20 Thread Laszlo Ersek
On 09/18/13 01:24, Jordan Justen wrote: > QEMU 1.6 enables using KVM READONLY memory regions. There > appears to be a bug when page tables are stored in the > READONLY memory region. To work-around this, we create > page table entries in RAM. Since RAM is present in QEMU/KVM > without any initializ

Re: [edk2] [PATCH 8/8] ArmPlatformPkg/ArmFvpDxe: Added Virtio Block support

2013-09-20 Thread Laszlo Ersek
On 09/20/13 17:37, Paolo Bonzini wrote: > Il 17/09/2013 18:54, Olivier Martin ha scritto: >> diff --git a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-AEMv8Ax4.fdf >> b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-AEMv8Ax4.fdf >> index 4210e6c..577b80b 100644 >> --- a/ArmPlatformPkg/ArmVExpre

Re: [edk2] [PATCH] OvmfPkg: resolve TpmMeasurementLib dependency introduced in r14687

2013-09-20 Thread Laszlo Ersek
Ping. Sorry for pushing (I sent this out just yesterday), but OVMF doesn't build with -D SECURE_BOOT after r14687, without this patch. (Or some other patch that resolves TpmMeasurementLib.) Thanks! Laszlo On 09/19/13 14:47, Laszlo Ersek wrote: > (1) OVMF depends on > > MdeModulePkg/Universal/

Re: [edk2] [PATCH v2 04/10] OvmfPkg/VirtioPciDeviceDxe: Implement VIRTIO_DEVICE_PROTOCOL for VirtIo Devices over PCI

2013-09-20 Thread Laszlo Ersek
On 09/20/13 17:42, Paolo Bonzini wrote: > Il 19/09/2013 22:30, Laszlo Ersek ha scritto: >> In a nutshell, VirtioPciSetDeviceStatus() breaks the interface contract >> of VIRTIO_DEVICE_PROTOCOL.WriteDevice(). The former targets a common >> virtio field, but the latter provides access to device-specif

Re: [edk2] [PATCH 6/6] OvmfPkg: Remove IndustryStandard/X64Paging.h

2013-09-20 Thread Laszlo Ersek
On 09/18/13 01:24, Jordan Justen wrote: > Since we no longer building page tables in SEC C code, we no > longer need this file. > > This reverts commit r14493. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jordan Justen > --- > OvmfPkg/Include/IndustryStandard/X64

Re: [edk2] [PATCH 4/6] OvmfPkg X64: Convert 24KB from uncompressed to compressed storage

2013-09-20 Thread Laszlo Ersek
On 09/18/13 01:24, Jordan Justen wrote: > Since we no longer require flash tables to be stored uncompressed > in the flash image, we can now give extra space to the main/compressed > storage area. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jordan Justen > --- >

Re: [edk2] [PATCH 8/8] ArmPlatformPkg/ArmFvpDxe: Added Virtio Block support

2013-09-20 Thread Paolo Bonzini
Il 20/09/2013 18:10, Laszlo Ersek ha scritto: > On 09/20/13 17:37, Paolo Bonzini wrote: >> Il 17/09/2013 18:54, Olivier Martin ha scritto: > >>> diff --git a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-AEMv8Ax4.fdf >>> b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-RTSM-AEMv8Ax4.fdf >>> index 421

[edk2] stdlib - socket, connect, inet_add, gethostbyname, send, recv, etc..

2013-09-20 Thread David F.
Hi, Before I go searching why getting unresolved external symbol for those in the subject .. does the stdlib include a working socket interface / library? TIA!! -- LIMITED TIME SALE - Full Year of Microsoft Training For J

Re: [edk2] [PATCH 3/6] OvmfPkg: For OvmfPkgX64, use OvmfPkg/ResetVector

2013-09-20 Thread Laszlo Ersek
On 09/18/13 01:24, Jordan Justen wrote: > This reset vector code will build page tables in RAM at address > 0x8, rather than relying on page tables to be present within > the flash image. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jordan Justen > --- > OvmfP

Re: [edk2] stdlib - socket, connect, inet_add, gethostbyname, send, recv, etc..

2013-09-20 Thread Leahy, Leroy P
The source is under StdLib/BsdSocketLib and the includes are under StdLib/Include/sys. Several example socket applications exist under AppPkg/Applications/Sockets. Lee From: David F. [mailto:df7...@gmail.com] Sent: Friday, September 20, 2013 4:31 PM To: edk2-devel@lists.sourceforge.net Subject

Re: [edk2] stdlib - socket, connect, inet_add, gethostbyname, send, recv, etc..

2013-09-20 Thread David F.
Okay, I need to include that library .. thanks. On Fri, Sep 20, 2013 at 4:46 PM, Leahy, Leroy P wrote: > The source is under StdLib/BsdSocketLib and the includes are under > StdLib/Include/sys. Several example socket applications exist under > AppPkg/Applications/Sockets. > > ** ** > > Lee

Re: [edk2] [PATCH 5/6] OvmfPkg/Sec: Stop building identity mapped pages in SEC

2013-09-20 Thread Laszlo Ersek
On 09/18/13 01:24, Jordan Justen wrote: > Now for X64 we use a VTF0 ResetVector which puts the page > tables in RAM. Therefore SEC no longer needs to do this. > > This reverts commit r14494. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jordan Justen > --- > OvmfP

Re: [edk2] ShellPkg patch: Handle pool allocation failure

2013-09-20 Thread Carsey, Jaben
reviewed-by: jaben carsey -Original Message- From: Sergei Antonov [mailto:sap...@gmail.com] Sent: Friday, September 20, 2013 8:05 AM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] ShellPkg patch: Handle pool allocation failure Another similar case. ShellPkg: Handle pool allo

[edk2] StdLib-BsdSocketLib - Patch to fix build under VS2008

2013-09-20 Thread David F.
Wouldn't build (warning treated as error). "Contributed-under: TianoCore Contribution Agreement 1.0" StdLib-BsdSocketLib-Fix-VS2008-Build.patch Description: Binary data -- LIMITED TIME SALE - Full Year of Microsoft Train

[edk2] Identify IDE devices and device information in UEFI

2013-09-20 Thread Murali Selvaraj
Hi All, I am developing UEFI driver which will identify ATA/ATAPI devices information on EFI shell. Find the algorithm of my driver and share your suggestions and ideas. 1. AHCI mode & IDE mode 2. scan PCI devices for class code 0x010601 and 0x0101 3. if AHCI mode, get AHCI bar, and check Ports