Re: [edk2] What status is returned by InstallMultipleProtocolInterfaces ?

2014-06-04 Thread Sergey Isakov
Hi Liming, Next question - Status = CoreLocateDevicePath (&gEfiDevicePathProtocolGuid, &DevicePath, &DeviceHandle); if (!EFI_ERROR (Status) && (DeviceHandle != NULL) && IsDevicePathEnd(DevicePath)) { Status = EFI_ALREADY_STARTED; continue; } - If

Re: [edk2] [RFC] Introduting Xen PV block driver to OVMF

2014-06-04 Thread Anthony PERARD
On Tue, Jun 03, 2014 at 04:02:16PM -0700, Jordan Justen wrote: > On Tue, May 20, 2014 at 8:11 AM, Anthony PERARD > wrote: > > Hi all, > > > > I've been working on writing a driver to use a Xen PV disk directly from > > OVMF. So far, I have a working prototype, a guest can boot from a PV > > devic

[edk2] MdeModulePkg/GraphicsConsoleDxe: Question about UEFI 'required' resolution

2014-06-04 Thread Olivier Martin
I am a bit confused by one of the comment in MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c. The comment at line 480 (https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Universal/Consol e/GraphicsConsoleDxe/GraphicsConsole.c#L480) is: // // if not

Re: [edk2] MdeModulePkg/GraphicsConsoleDxe: Question about UEFI 'required' resolution

2014-06-04 Thread Andrew Fish
On Jun 4, 2014, at 8:27 AM, Olivier Martin wrote: > I am a bit confused by one of the comment in > MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c. > The comment at line 480 > (https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/G

Re: [edk2] MdeModulePkg/GraphicsConsoleDxe: Question about UEFI 'required' resolution

2014-06-04 Thread Olivier Martin
Yes, I saw this requirement. But in this case why 800x600 and not 640x480? Or even trying both? If my platform supports 640x480 and not 800x600 and for some strange reason it goes in this part of the code it would fail. Even if it is compliant with the UEFI spec. And actually it might even be a o

Re: [edk2] MdeModulePkg/GraphicsConsoleDxe: Question about UEFI 'required' resolution

2014-06-04 Thread Andrew Fish
On Jun 4, 2014, at 9:49 AM, Olivier Martin wrote: > Yes, I saw this requirement. But in this case why 800x600 and not 640x480? Or > even trying both? > If my platform supports 640x480 and not 800x600 and for some strange reason > it goes in this part of the code it would fail. Even if it is co

Re: [edk2] MdeModulePkg/GraphicsConsoleDxe: Question about UEFI 'required' resolution

2014-06-04 Thread Olivier Martin
I tend to agree for the PCDs. My use case was I was debugging a third-party platform that was not implementing the GOP protocol (Get/SetMode() functions) correctly. And for some this reason the code path ends up in this condition. In my opinion, this CheckModeSupported (800x600) should be removed

Re: [edk2] MdeModulePkg/GraphicsConsoleDxe: Question about UEFI 'required' resolution

2014-06-04 Thread Andrew Fish
On Jun 4, 2014, at 10:35 AM, Olivier Martin wrote: > I tend to agree for the PCDs. > My use case was I was debugging a third-party platform that was not > implementing the GOP protocol (Get/SetMode() functions) correctly. And for > some this reason the code path ends up in this condition. > In