Hi Hess,
The patch looks good to me.
Reviewed-by: Yingke Liu
Dennis
From: Chen, Hesheng [mailto:hesheng.c...@intel.com]
Sent: Wednesday, September 03, 2014 3:20 PM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [BaseTools] [Patch] Update AutoGen to copy binary files to
output directory o
On 09/04/14 08:32, Ard Biesheuvel wrote:
> On 4 September 2014 04:09, Laszlo Ersek wrote:
>> Hi Ard,
>>
>> I started to review your v6 patchset in reverse order -- I first created
>> a map between your v5 and v6 patches (as much as it was possible), then
>> started to look at the DSC file(s) first
Patch is good. Checked with NASM version 2.09.08.
On Wed, 2014-09-03 at 10:33 -0700, Jordan Justen wrote:
> Without this change, NASM 2.09.04 will hang with OVMF+CSM on both IA32
> and X64.
>
> Tested on OVMF+CSM on GCC49 with NASM 2.07, 2.09.04 and 2.11.
>
> Contributed-under: TianoCore Contrib
Hi Jaben,
Can you help to review this patch? It refines the code style in ShellPkg and
makes the number of tags in comment match function parameters.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin mailto:shumin@intel.com>>
Thanks
Shumin
Shell.patch
Desc
one comment
On 08/28/14 22:29, Gabriel L. Somlo wrote:
>
> NOTE: I screwed up the mailing list address in the previous attempt,
> so please use this one to reply with feedback. Sorry about that !
>
>
> OvmfPkg/Library/AcpiTimerLib: Access power mgmt regs based on host bridge type
>
> Pick the
Reviewed-by: Jaben Carsey
From: Qiu, Shumin
Sent: Thursday, September 04, 2014 6:02 AM
To: Carsey, Jaben
Cc: 'edk2-devel@lists.sourceforge.net'
Subject: [edk2][Patch]ShellPkg: Refine the code style and comment.
Importance: High
Hi Jaben,
Can you help to review this patch? It refines the code st
On Sep 3, 2014, at 7:12 PM, Gao, Liming wrote:
> Andrew:
> The original code is “while (Counter > 0x) {“, we meet with the
> same issue in UNIXGCC tool chain. So, we change the code to “while ((Counter
> & 0xULL) != 0) {“. Now, you meet with this issue again in
> XC
Vadim Rozenfeld's QXL WDDM driver now works in Windows Server 2012 even
when the latter runs on OVMF. It has no VGA BIOS dependencies and it
supports S3. (IOW with this driver OVMF win2012 guests too can be
suspended and resumed.) Another benefit is the runtime video mode
selection; the user is no
There are used to grant access of pages to other Xen domains.
This code originaly comes from the Xen Project, and more precisely from
MiniOS.
Signed-off-by: Steven Smith
Signed-off-by: Grzegorz Milos
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Anthony PERARD
---
Cha
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Anthony PERARD
---
Change in V2:
- Coding style
- Error handler
---
OvmfPkg/XenBusDxe/XenBusDxe.c | 18 ++
OvmfPkg/XenBusDxe/XenBusDxe.h | 1 +
2 files changed, 19 insertions(+)
diff --git a/OvmfPkg/XenBusDx
This first function is used to notify the other side that there is
something to do. The other side is another Xen domain.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Anthony PERARD
---
Change in V2:
- file header
- coding style
- adding comment to functions
- Licenses
Hi all,
This patch series is implementing the necessary in order to access a PV block
device. For that, one need a XenStore client, a XenBus client, and the PV block
driver.
There are two new drivers, XenbusDxe and XenPvBlkDxe. The first one implement a
bus drivers, and the second is a block driv
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Anthony PERARD
---
Change in V2:
- file header, copyright
- Add License
- Add push/pop instruction.
- fix types
- Comment of exported functions
- Improve coding style
- Add error handling in the main init function (of the driv
This includes Component Name and Driver Binding.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Anthony PERARD
---
Change in V2:
- Simple support of controller name.
- Cleaning up comments, files header.
- Add Licenses
- Rename XenbusDxe to XenBusDxe.
---
OvmfPkg/OvmfPkg
This is a copy of InterlockedCompareExchange32 from the
BaseSynchronizationLib.
The function will be used in the next patch.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Anthony PERARD
---
Change in V2:
- Add intel compilation code
MSFT code is not compied over becau
This protocol will be used for communication between a PV driver (like a
PV block driver) and the XenBus/XenStore.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Anthony PERARD
--
Change in V2:
- Comment, file header
- Protocol License
- Declare xen interface version earl
The ExitBoot event is used to disconnect from the device before the
next operating system start using them.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Anthony PERARD
---
OvmfPkg/XenBusDxe/XenBusDxe.c | 38 --
OvmfPkg/XenBusDxe/XenBu
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Anthony PERARD
---
OvmfPkg/Include/Protocol/XenBus.h | 103
OvmfPkg/XenBusDxe/XenStore.c | 160 ++
OvmfPkg/XenBusDxe/XenStore.h | 87 +
A ParaVirtualize block driver.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Anthony PERARD
---
Change in V2:
- Add minimal support for controller name
- Remove stuff about BlockIo2
- Little cleanup
- Licenses and file headers
- Rename XenbusIo into XenBusIo
---
OvmfPkg
XenStore is a key/value database, which is running on another virtual
machine. It can be accessed through shared memory. This is a client
implementation.
Origin: FreeBSD 10.0
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Anthony PERARD
---
Change in V2:
- Change comment
This is a bus-like on top of XenStore. It will look for advertised
ParaVirtualized devices and initialize them by producing XenBus
protocol.
Origin: FreeBSD 10.0
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Anthony PERARD
---
Change in V2:
- comment, file header
- Fix
This atomically test and clear a bit.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Anthony PERARD
---
Change in V2:
- Adding .asm version
- Comment the function
---
OvmfPkg/XenBusDxe/X64/TestAndClearBit.S | 13 +
OvmfPkg/XenBusDxe/X64/TestAndClearBit.asm
This is the code that will do the actual communication between OVMF and
a PV block backend, where the block device lives.
This implementation originally comes from Mini-OS, a part of the Xen
Project.
Signed-off-by: Samuel Thibault
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-of
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Anthony PERARD
---
Change in V2:
- coding style
- adding comment to functions
- Rename Xenbus to XenBus.
---
OvmfPkg/Include/Protocol/XenBus.h | 27 +++
OvmfPkg/XenBusDxe/EventChannel.c | 55 +
Install the BlockIo protocol.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Anthony PERARD
---
Change in V2:
- Remove blockIo2 headers.
- Fix few comment.
- file header, copyright
- Rewrite few comment and error messages
- No more callback
- Improving block read/write, i
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Anthony PERARD
---
OvmfPkg/XenBusDxe/Helpers.c | 9 +
OvmfPkg/XenBusDxe/XenBusDxe.h | 5 +
2 files changed, 14 insertions(+)
create mode 100644 OvmfPkg/XenBusDxe/Helpers.c
diff --git a/OvmfPkg/XenBusDxe/Helpers
On 09/04/14 18:50, Anthony PERARD wrote:
> Hi all,
>
> This patch series is implementing the necessary in order to access a PV block
> device. For that, one need a XenStore client, a XenBus client, and the PV
> block
> driver.
>
> There are two new drivers, XenbusDxe and XenPvBlkDxe. The first o
Hi Andrew,
One more problem with Clang compilation.
I modified MdeModulePkg/Application/HelloWorld/HelloWorld.c with two lines
———
Index = 1234;
AsciiPrint("Index=%d\n", Index);
——
And compile it with GCC49 and with Clang.
First printed 1234, second printed address instead of value
Sergey
Erik and Tapan,
Can you please look at this patch?
This will be merged into both bcfg.c files (I need to refactor those into a
separate library).
ShellPkg: Update BCFG command for correct use and errors on moving
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Cars
Reviewed-by: Tapan Shah mailto:tapands...@hp.com>>
From: Carsey, Jaben [mailto:jaben.car...@intel.com]
Sent: Thursday, September 04, 2014 3:09 PM
To: Shah, Tapan; Bjorge, Erik C
Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben
Subject: ShellPkg: Update BCFG command for correct use and errors on
Reviewed-by: Erik Bjorge
From: Carsey, Jaben
Sent: Thursday, September 04, 2014 1:09 PM
To: Shah, Tapan (tapands...@hp.com); Bjorge, Erik C
Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben
Subject: ShellPkg: Update BCFG command for correct use and errors on moving
Erik and Tapan,
Can you ple
Eric -
Here is the basic idea:
typedef struct _EFI_IFR_ONE_OF_OPTION {
EFI_IFR_OP_HEADER Header;
EFI_STRING_ID Option;
UINT8 Flags;
UINT8 Type; <<= For ORDERED_LIST, can be EFI_IFR_TYPE_NUM_SIZE_8 or
EFI_IFR_TYPE_BUFFER
EFI_IFR_TYPE_VALUE Value;
} EFI_IFR_ONE_OF_OPTION;
typedef struc
Andrew:
Could you help review this patch?
MdeModulePkg: Fix XCODE Link Issue in DxeCore
In XCODE tool chain, the 64-bit bit wise and operation is causing the compiler
to emit an __umoddi3.
This patch uses BaseLib API to replace 64-bit bit operation.
Contributed-under: TianoCore Contribution A
Tim,
For option, current it only has one value and one prompt string " EFI_STRING_ID
Option; ". For below example:
orderedlist
varid = MyIfrNVData.BootOrder,
prompt = STRING_TOKEN(0x006D),
help= STRING_TOKEN(0x0059),
Hi all,
I'm trying to get PARTITION_PRIVATE_DATA from *BlockIo using
PARTITION_DEVICE_FROM_BLOCK_IO_THIS, then I access to attributes of DiskIo
in PARTITION_PRIVATE_DATA (e.g *->DiskIo->Revision). But a synchronous
exception error will occur if I access it.
//Open BlockIo protocol
Status = gB
This usage is wrong.
The PARTITION_PRIVATE_DATA is a hidden private data only referred by Partition
driver internally. It’s not exposed for external user.
From: Nguyễn Văn Hiễn [mailto:nvhien1...@gmail.com]
Sent: Friday, September 05, 2014 11:48
To: edk2-devel@lists.sourceforge.net
Subject: [edk
Building AppPkg for IA32 using VS2013 fails with unresolved external symbol
__dtoui3.
__dtoui3 is a helper function called by the generated code. It is analogous to
the
__ftol2 helper function call generated by older Microsoft compilers. VS2013
calls
__dtoui3 instead of __ftol2. Apparently the n
37 matches
Mail list logo
