[edk2] compilation error adding a Library object instead of the source code

2015-04-14 Thread partha sarathi swain
Hi all, i am writing an utility dummyapp.efi (application) which will consume the one library dummylib.lib Now ".inf" file has some following code ** [Defines] INF_VERSION= 0x00010005 BASE_NAME = dum

Re: [edk2] [PATCH v4 2/5] ArmPlatformPkg: do not fulfil MemoryInitPeiLib dependency directly via .c file

2015-04-14 Thread Olivier Martin
FYI, the patchset has been committed. Thanks Ard for the contribution (and for the cache maintenance fix that should affect all the ARM platforms)! -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: 13 April 2015 16:56 To: Olivier Martin Cc: edk2-devel@lists

Re: [edk2] compilation error adding a Library object instead of the source code

2015-04-14 Thread Olivier Martin
You also need to provide an implementation for your ‘DummyLib’ interface. The implementation is generally/always an EDK2 module with an INF file and probably a C-file. Have a look at the ‘null’ implementation of DebugLib interface in \MdePkg\Library\BaseDebugLibNull From: partha sarathi swain [m

[edk2] SmmCorePerformanceLib

2015-04-14 Thread Anbazhagan, Baraneedharan
SmmCorePerformaceLib is using SmmServicesTableLib which cannot be used in SMM_CORE modules(SVN#10183) and leads to build error. SmmCorePerformaceLib needs to access SmmAllocatePool, SmmInstallProtocolInterface and SmiHandlerRegister without gSmst - either integrate SmmCorePerformaceLib as part

[edk2] [Patch 4/8] SourceLevelDebugPkg: PeCoffExtraActionLibDebug: Add Quark SoC compatibility

2015-04-14 Thread Kinney, Michael D
Please review the attached patch that adds Quark SoC compatibility to the PeCoffExtraActionLibDebug in the SourceLevelDebugPkg. Some EDK II libraries assume capabilities that are not available on Quark SoC. With these changes, applications and drivers built for IA32 are compatible with Quark S

[edk2] [Patch 5/8] SourceLevelDebugPkg: DebugAgentLib: Add Quark SoC compatibility

2015-04-14 Thread Kinney, Michael D
Please review the attached patch that adds Quark SoC compatibility to the DebugAgentLib in the SourceLevelDebugPkg. Some EDK II libraries assume capabilities that are not available on Quark SoC. With these changes, applications and drivers built for IA32 are compatible with Quark SoC. These pa

[edk2] [Patch 8/8] MdeModulePkg: SerialPortLib: Add Quark SoC compatibility

2015-04-14 Thread Kinney, Michael D
Please review the attached patch that adds Quark SoC compatibility to the SerialPortLib in the MdeModulePkg. Some EDK II libraries assume capabilities that are not available on Quark SoC. With these changes, applications and drivers built for IA32 are compatible with Quark SoC. These patches d

[edk2] [Patch 3/8] MdePkg: BaseMemoryLibRepStr: Add Quark SoC compatibility

2015-04-14 Thread Kinney, Michael D
Please review the attached patch that adds Quark SoC compatibility to the BaseMemoryLibRepStr in the MdePkg. Some EDK II libraries assume capabilities that are not available on Quark SoC. With these changes, applications and drivers built for IA32 are compatible with Quark SoC. These patches d

[edk2] [Patch 1/8] MdePkg: BaseCacheMaintenanceLib: Add Quark SoC compatibility

2015-04-14 Thread Kinney, Michael D
Please review the attached patch that adds Quark SoC compatibility to the BaseCacheMaintenanceLib in the MdePkg. Some EDK II libraries assume capabilities that are not available on Quark SoC. With these changes, applications and drivers built for IA32 are compatible with Quark SoC. These patch

[edk2] [Patch 7/8] UefiCPuPkg: ApicLibs: Add Quark SoC compatibility

2015-04-14 Thread Kinney, Michael D
Please review the attached patch that adds Quark SoC compatibility to the APIC Libraries in the UefiCpuPkg. Some EDK II libraries assume capabilities that are not available on Quark SoC. With these changes, applications and drivers built for IA32 are compatible with Quark SoC. These patches do

[edk2] [Patch 6/8] UefiCPuPkg: CpuExceptionHandlerLib: Add Quark SoC compatibility

2015-04-14 Thread Kinney, Michael D
Please review the attached patch that adds Quark SoC compatibility to the CpuExceptionHandlerLib in the UefiCpuPkg. Some EDK II libraries assume capabilities that are not available on Quark SoC. With these changes, applications and drivers built for IA32 are compatible with Quark SoC. These pa

[edk2] [Patch 2/8] MdePkg: BaseLib: Add Quark SoC compatibility

2015-04-14 Thread Kinney, Michael D
Please review the attached patch that adds Quark SoC compatibility to the BaseLib in the MdePkg. Some EDK II libraries assume capabilities that are not available on Quark SoC. With these changes, applications and drivers built for IA32 are compatible with Quark SoC. These patches do not modify

Re: [edk2] [PATCH] MdePkg/DevicePath.h: Fixed 'integer operation result is out of range'

2015-04-14 Thread Kinney, Michael D
Martin and Liming, I have attached the revised patch. Can you please review? Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off by: Michael Kinney Tested-by: Olivier Martin I agree that adding ul to the constant 0x01 will also work. I reviewed other source code changes that

Re: [edk2] SmmCorePerformanceLib

2015-04-14 Thread Zeng, Star
You need to use PiSmmCoreSmmServicesTableLib SmmServicesTableLib instance. From: Anbazhagan, Baraneedharan [mailto:anbazha...@hp.com] Sent: Tuesday, April 14, 2015 8:30 PM To: edk2-devel@lists.sourceforge.net Subject: [edk2] SmmCorePerformanceLib SmmCorePerformaceLib is using SmmServicesTableLib

[edk2] [PATCH] MdeModulePkg: PCD/Pei: eliminate unused but set variable

2015-04-14 Thread Laszlo Ersek
- SVN r14866: MdePkg and MdeModulePkg Pcd: Add the new EFI_GET_PCD_INFO_PROTOCOL and EFI_GET_PCD_INFO_PPI support for PI 1.2.1 compliance. added the "DataBase" local variable to PcdPeimInit(), and both set it and used it. - SVN r14869: MdeModulePkg and Nt32Pkg Pcd: Add the new EFI_GET_PCD

Re: [edk2] [PATCH] MdeModulePkg: PCD/Pei: eliminate unused but set variable

2015-04-14 Thread Zeng, Star
Laszlo, Reviewed-by: Star Zeng Yes, go ahead to check in the patch, please. Thanks very much. Star -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, April 15, 2015 8:46 AM To: edk2-devel@lists.sourceforge.net Cc: Zeng, Star Subject: [PATCH] MdeModulePkg:

Re: [edk2] MdeModulePkg:Fix required in NvmExpressDxe driver

2015-04-14 Thread Tian, Feng
Hi, Devkate If the last entry in the first Prp list points to the last 4K data range rather than a next Prp list, how does h/w distinguish the last entry is a pointer to next Prp list or a valid entry to buffer? I am consulting NVMe org and if I have some feedbacks I will get back to you. Than

Re: [edk2] [PATCH] MdeModulePkg: PCD/Pei: eliminate unused but set variable

2015-04-14 Thread Laszlo Ersek
On 04/15/15 02:57, Zeng, Star wrote: > Laszlo, > > Reviewed-by: Star Zeng > > Yes, go ahead to check in the patch, please. Done, SVN r17179. Thanks for the quick review! Laszlo > Thanks very much. > Star > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: We

Re: [edk2] [PATCH] MdePkg/DevicePath.h: Fixed 'integer operation result is out of range'

2015-04-14 Thread Gao, Liming
Mike: The patch is good to me. Reviewed-by: Liming Gao Thanks Liming -Original Message- From: Kinney, Michael D Sent: Wednesday, April 15, 2015 7:09 AM To: Gao, Liming; edk2-devel@lists.sourceforge.net; Laszlo Ersek Cc: Kinney, Michael D Subject: RE: [edk2] [PATCH] MdePkg/DevicePath.h:

Re: [edk2] [PATCH 09/11] Add a fake ESRT driver to go with Fake Capsule driver.

2015-04-14 Thread Tian, Feng
Hi, Jones Could you let me know what's the benefit of putting these Fake FSRT and Fake Capsule lib to MdeModulePkg? Why not purely for Ovmf platform? Thanks Feng -Original Message- From: Peter Jones [mailto:pjo...@redhat.com] Sent: Saturday, April 11, 2015 03:02 To: edk2-devel@lists.so

Re: [edk2] [Patch 8/8] MdeModulePkg: SerialPortLib: Add Quark SoC compatibility

2015-04-14 Thread Tian, Feng
It looks good to me. Reviewed-by: Feng Tian From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Wednesday, April 15, 2015 00:50 To: edk2-devel@lists.sourceforge.net Subject: [edk2] [Patch 8/8] MdeModulePkg: SerialPortLib: Add Quark SoC compatibility Please review the attached pat

Re: [edk2] compilation error adding a Library object instead of the source code

2015-04-14 Thread partha sarathi swain
Hi Martin, Yes. That is straight way to use the library (Having the definition of the file "*.c" and one makefile "*.inf" for the Library). But i dont have that, all i have is the library object ".lib" and all its header files. As per my understanding when you build UEFI it builds all the Pkgs(mo

Re: [edk2] compilation error adding a Library object instead of the source code

2015-04-14 Thread Andrew Fish
> On Apr 14, 2015, at 9:52 PM, partha sarathi swain > wrote: > > Hi Martin, > Yes. That is straight way to use the library (Having the definition of the > file "*.c" and one makefile "*.inf" for the Library). But i dont have that, > all i have is the library object ".lib" and all its header

Re: [edk2] [Patch 5/8] SourceLevelDebugPkg: DebugAgentLib: Add Quark SoC compatibility

2015-04-14 Thread Fan, Jeff
Reviewed-by: Jeff Fan mailto:jeff@intel.com>> From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Wednesday, April 15, 2015 12:50 AM To: edk2-devel@lists.sourceforge.net Subject: [edk2] [Patch 5/8] SourceLevelDebugPkg: DebugAgentLib: Add Quark SoC compatibility Please review th

Re: [edk2] [Patch 4/8] SourceLevelDebugPkg: PeCoffExtraActionLibDebug: Add Quark SoC compatibility

2015-04-14 Thread Fan, Jeff
Reviewed-by: Jeff Fan mailto:jeff@intel.com>> From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Wednesday, April 15, 2015 12:49 AM To: edk2-devel@lists.sourceforge.net Subject: [edk2] [Patch 4/8] SourceLevelDebugPkg: PeCoffExtraActionLibDebug: Add Quark SoC compatibility Plea

Re: [edk2] [Patch 7/8] UefiCPuPkg: ApicLibs: Add Quark SoC compatibility

2015-04-14 Thread Fan, Jeff
Reviewed-by: Jeff Fan mailto:jeff@intel.com>> From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Wednesday, April 15, 2015 12:50 AM To: edk2-devel@lists.sourceforge.net Subject: [edk2] [Patch 7/8] UefiCPuPkg: ApicLibs: Add Quark SoC compatibility Please review the attached patc

Re: [edk2] [Patch 3/8] MdePkg: BaseMemoryLibRepStr: Add Quark SoC compatibility

2015-04-14 Thread Fan, Jeff
Reviewed-by: Jeff Fan mailto:jeff@intel.com>> From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Wednesday, April 15, 2015 12:49 AM To: edk2-devel@lists.sourceforge.net Subject: [edk2] [Patch 3/8] MdePkg: BaseMemoryLibRepStr: Add Quark SoC compatibility Please review the attac

Re: [edk2] [Patch 6/8] UefiCPuPkg: CpuExceptionHandlerLib: Add Quark SoC compatibility

2015-04-14 Thread Fan, Jeff
Reviewed-by: Jeff Fan mailto:jeff@intel.com>> From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Wednesday, April 15, 2015 12:50 AM To: edk2-devel@lists.sourceforge.net Subject: [edk2] [Patch 6/8] UefiCPuPkg: CpuExceptionHandlerLib: Add Quark SoC compatibility Please review th

Re: [edk2] [Patch 1/8] MdePkg: BaseCacheMaintenanceLib: Add Quark SoC compatibility

2015-04-14 Thread Fan, Jeff
Reviewed-by: Jeff Fan mailto:jeff@intel.com>> From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Wednesday, April 15, 2015 12:49 AM To: edk2-devel@lists.sourceforge.net Subject: [edk2] [Patch 1/8] MdePkg: BaseCacheMaintenanceLib: Add Quark SoC compatibility Please review the a

Re: [edk2] [Patch 2/8] MdePkg: BaseLib: Add Quark SoC compatibility

2015-04-14 Thread Fan, Jeff
Reviewed-by: Jeff Fan mailto:jeff@intel.com>> From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Wednesday, April 15, 2015 12:49 AM To: edk2-devel@lists.sourceforge.net Subject: [edk2] [Patch 2/8] MdePkg: BaseLib: Add Quark SoC compatibility Please review the attached patch tha

Re: [edk2] [Patch 1/8] MdePkg: BaseCacheMaintenanceLib: Add Quark SoC compatibility

2015-04-14 Thread Jordan Justen
On 2015-04-14 09:49:00, Kinney, Michael D wrote: >Please review the attached patch that adds Quark SoC compatibility to the >BaseCacheMaintenanceLib in the MdePkg. > > > >Some EDK II libraries assume capabilities that are not available on Quark >SoC. With these changes, appl