[edk2] Concerns with IP4Config2 - Part 3 - No RegisterDataNotify() on DHCP config

2015-07-31 Thread El-Haj-Mahmoud, Samer
This is Part 3 of the issues we observed in IP4Config2 in EDK2 The UEFI 2.5 spec provides a method RegisterDataNotify() as part of the Ip4Config2 protocol that is used by callers to get notified of asynchronous configuration completion. The current EDK2 implementation is covering setting the

[edk2] [PATCH v2 2/2] ArmPkg/ArmGicArchLib: use common source file

2015-07-31 Thread Ryan Harkin
Now that the Arm and Aarch64 source files are identical and rely on conditional compilation to provide arch specific code, remove the duplicated files and use one common file. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ryan Harkin ryan.har...@linaro.org Reviewed-by:

[edk2] Concerns with IP4Config2 - Part 1 - DHCP default policy

2015-07-31 Thread El-Haj-Mahmoud, Samer
We have observed an interesting behavior in the IP4Config2 implementation in EDK2 and have a concern with it. This is Part 1 of multiple parts, sent in separate email threads to make it easier to track the discussion on each issue The IPv4 config policy for all NICs defaults to DHCP.

Re: [edk2] [PATCH v2 2/2] ArmPkg/ArmGicArchLib: use common source file

2015-07-31 Thread Ryan Harkin
On 31 July 2015 at 15:49, Ryan Harkin ryan.har...@linaro.org wrote: Now that the Arm and Aarch64 source files are identical and rely on conditional compilation to provide arch specific code, remove the duplicated files and use one common file. Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH 1/2] ArmPkg/ArmGicLibArchLib: common check for GICv3

2015-07-31 Thread Ard Biesheuvel
On 31 July 2015 at 14:21, Ryan Harkin ryan.har...@linaro.org wrote: On 31 July 2015 at 13:13, Ard Biesheuvel ard.biesheu...@linaro.org wrote: On 31 July 2015 at 14:06, Ryan Harkin ryan.har...@linaro.org wrote: Make Arm and Aarch64 both use the same code, conditionally compiled, to check

Re: [edk2] [PATCH v2 1/2] ArmPkg/ArmGicLibArchLib: common check for GICv3

2015-07-31 Thread Ryan Harkin
On 31 July 2015 at 17:16, Andrew Fish af...@apple.com wrote: On Jul 31, 2015, at 7:49 AM, Ryan Harkin ryan.har...@linaro.org wrote: Make Arm and Aarch64 both use the same code, conditionally compiled, to check if the platform has GICv3. Both source files for Arm and Aarch64 are now

Re: [edk2] [PATCH v2 1/2] ArmPkg/ArmGicLibArchLib: common check for GICv3

2015-07-31 Thread Andrew Fish
On Jul 31, 2015, at 9:37 AM, Ryan Harkin ryan.har...@linaro.org wrote: On 31 July 2015 at 17:16, Andrew Fish af...@apple.com wrote: On Jul 31, 2015, at 7:49 AM, Ryan Harkin ryan.har...@linaro.org wrote: Make Arm and Aarch64 both use the same code, conditionally compiled, to check if

Re: [edk2] [PATCH v2 1/2] ArmPkg/ArmGicLibArchLib: common check for GICv3

2015-07-31 Thread Andrew Fish
On Jul 31, 2015, at 7:49 AM, Ryan Harkin ryan.har...@linaro.org wrote: Make Arm and Aarch64 both use the same code, conditionally compiled, to check if the platform has GICv3. Both source files for Arm and Aarch64 are now identical and the next step is to move to a common source file.

[edk2] [PATCH 0/9] OvmfPkg, ArmVirtPkg: SMBIOS 3.0, round 2

2015-07-31 Thread Laszlo Ersek
The SMBIOS 3.x entry point is structurally different from the 2.x variant, therefore the current code used by OvmfPkg and ArmVirtPkg doesn't recognize an SMBIOS 3.0 entry point structure even if QEMU exports one. This series rectifies that. The first four patches implement Jordan's great idea:

[edk2] [PATCH 1/9] OvmfPkg: SmbiosVersionLib: add plugin for detecting SMBIOS version

2015-07-31 Thread Laszlo Ersek
Introduce a minimal library instance for fetching and validating the SMBIOS entry point structure exposed by QEMU over fw_cfg. This library is meant to be hooked into MdeModulePkg/Universal/SmbiosDxe by platform DSC files, so that the library can set the PCD(s) that SmbiosDxe consumes at the right

[edk2] [PATCH 3/9] ArmVirtPkg: set SMBIOS version in DetectSmbiosVersionLib instead of QemuFwCfgToPcdDxe

2015-07-31 Thread Laszlo Ersek
This patch de-duplicates the logic added in commit ArmVirtPkg: QemuFwCfgToPcdDxe: set SMBIOS entry point version dynamically (git c98da334, SVN r18043) by hooking DetectSmbiosVersionLib into SmbiosDxe. Although said commit was supposed to work with SMBIOS 3.0 payloads from QEMU, in practice

[edk2] [PATCH 4/9] ArmVirtPkg: revert ArmVirtPkg: add QemuFwCfgToPcdDxe

2015-07-31 Thread Laszlo Ersek
This reverts git commit d2733aa9 (SVN r18042), because it is empty now. The original problem: Many universal DXE drivers in edk2 can be controlled by setting dynamic PCDs. Such a PCD must be set before the consumer DXE driver is dispatched. should be hereafter solved similarly to how

[edk2] [PATCH 6/9] ArmVirtPkg/ArmVirtQemu.dsc: set default for PcdQemuSmbiosValidated

2015-07-31 Thread Laszlo Ersek
The upcoming OvmfPkg patches will implicitly affect the ArmVirtQemu.dsc build, necessitating a default value for the new dynamic PcdQemuSmbiosValidated. Add it. Cc: Ard Biesheuvel ard.biesheu...@linaro.org Cc: Wei Huang w...@redhat.com Contributed-under: TianoCore Contribution Agreement 1.0

[edk2] [PATCH 7/9] OvmfPkg: SmbiosPlatformDxe: eliminate duplicate entry point validation

2015-07-31 Thread Laszlo Ersek
At this point all platforms that use OvmfPkg/SmbiosPlatformDxe in edk2, namely ArmVirtQemu.dsc and OvmfPkg*.dsc, have been migrated to SmbiosVersionLib. Therefore SmbiosPlatformDxe itself can forego verifying QEMU's SMBIOS entry point; if SmbiosVersionLib's validation was successful, it should

[edk2] [PATCH 9/9] OvmfPkg: SmbiosVersionLib: recognize SMBIOS 3.x entry point

2015-07-31 Thread Laszlo Ersek
Also set the DocRev field the way QEMU exposes it, because MdeModulePkg/Universal/SmbiosDxe lets us control that field too. Cc: Ard Biesheuvel ard.biesheu...@linaro.org Cc: Wei Huang w...@redhat.com Cc: Jordan Justen jordan.l.jus...@intel.com Cc: Gabriel L. Somlo so...@cmu.edu Contributed-under:

[edk2] [PATCH 8/9] ArmVirtPkg: set default for PcdSmbiosDocRev

2015-07-31 Thread Laszlo Ersek
When MdeModulePkg/Universal/SmbiosDxe is instructed to compose install an SMBIOS 3.0 entry point, it keys the Docrev (specification document revision) field of that structure off of PcdSmbiosDocRev. An upcoming OvmfPkg patch will have OvmfPkg/Library/SmbiosVersionLib set this PCD dynamically.

[edk2] [PATCH 2/9] OvmfPkg: set SMBIOS version in DetectSmbiosVersionLib instead of PlatformPei

2015-07-31 Thread Laszlo Ersek
This patch de-duplicates the logic added in commit OvmfPkg: PlatformPei: set SMBIOS entry point version dynamically (git 37baf06b, SVN r17676) by hooking DetectSmbiosVersionLib into SmbiosDxe. Although said commit was supposed to work with SMBIOS 3.0 payloads from QEMU, in practice that never

Re: [edk2] [PATCH v2 1/2] ArmPkg/ArmGicLibArchLib: common check for GICv3

2015-07-31 Thread Cohen, Eugene
The .inf/source file approach is the way to be consistent with the rest of edk2. I think it would be messy for the rest of edk2 to use .inf binding and for Arm packages to use a combination of #ifdef and .inf techniques. As someone who has ported UEFI to a new processor architecture I

Re: [edk2] [PATCH v2 0/4] FFS/FV aligment optimization

2015-07-31 Thread Ard Biesheuvel
On 31 July 2015 at 02:02, Laszlo Ersek ler...@redhat.com wrote: On 07/31/15 01:49, Ard Biesheuvel wrote: On 31 July 2015 at 01:17, Laszlo Ersek ler...@redhat.com wrote: On 07/27/15 15:52, Ard Biesheuvel wrote: On 27 July 2015 at 15:34, Liu, Yingke D yingke.d@intel.com wrote: Reviewed-by:

[edk2] [PATCH 0/2] ArmPkg/ArmGicArchLib: use common source file

2015-07-31 Thread Ryan Harkin
The Arm and Aarch64 source files for ArmGicArchLib are copy/paste of each other with one minor difference to how they check for if the platform has GICv3. I made the change in two patches so that the diff could be identified separately from the move commit. The first patch makes both the Arm

[edk2] [PATCH 2/2] ArmPkg/ArmGicArchLib: use common source file

2015-07-31 Thread Ryan Harkin
Now that the Arm and Aarch64 source files are identical and rely on conditional compilation to provide arch specific code, remove the duplicated files and use one common file. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ryan Harkin ryan.har...@linaro.org ---

Re: [edk2] [PATCH v2 1/2] ArmPkg/ArmGicLibArchLib: common check for GICv3

2015-07-31 Thread Ryan Harkin
On 31 Jul 2015 21:21, Cohen, Eugene eug...@hp.com wrote: The .inf/source file approach is the way to be consistent with the rest of edk2. I think it would be messy for the rest of edk2 to use .inf binding and for Arm packages to use a combination of #ifdef and .inf techniques. As someone who

Re: [edk2] [PATCH 2/4] ArmVirtPkg: use 'auto' alignment and FIXED placement for XIP modules

2015-07-31 Thread Ard Biesheuvel
On 31 July 2015 at 02:10, Laszlo Ersek ler...@redhat.com wrote: On 07/28/15 18:42, Ard Biesheuvel wrote: Now that GenFw correctly propagates the minimum alignment of the ELF input sections to the PE/COFF binary, we can simply select 'auto' alignment in the FDF Rule section instead of tweaking

Re: [edk2] [PATCH v2 0/4] FFS/FV aligment optimization (was: [RFC] small C model and LLVM/clang support for AARCH64)

2015-07-31 Thread Ard Biesheuvel
On 31 July 2015 at 03:57, Gao, Liming liming@intel.com wrote: Ard: This way may not work. I need to confirm it. I think you can provide the two Ffs Rules. One is with Fixed and 4K, another is no. They have the different Rule names. Then, apply the different one in the different