Re: [edk2] [Patch 07/11] MdeModulePkg: Add Platform recovery support

2015-11-11 Thread Wang, Sunny (HPS SW)
Hi Ray, Yes, you are right! Thanks for pointing it out. :) I took an inappropriate reference (in ArmPlatformPkg\Bds\Bds.c) which caused my misunderstanding. Regards, Sunny Wang -Original Message- From: Ni, Ruiyu [mailto:ruiyu...@intel.com] Sent: Monday, November 09, 2015 7:25 PM To:

[edk2] [PATCH] MdeModulePkg PeiCore: PEI dispatcher need retry to process NOT_DISPATCHED FV

2015-11-11 Thread Star Zeng
A corner case like below will cause a NOT_DISPATCHED FV has no opportunity to be dispatched. 1. FV_RECOVERY has SecCore, PeiCore and some other PEI modules, a module will report FVMAIN_COMPACT and FV_RECOVERY2 in sequence. 2. FVMAIN_COMPACT has a FV image file with GUIDED FV image section

Re: [edk2] Armv8 64bit: System error booting linux from the UEFI

2015-11-11 Thread Ard Biesheuvel
On 11 November 2015 at 01:20, Vladimir Olovyannikov wrote: > Hello, > > I am not sure this is the right forum to ask this question, so I am sorry in > advance if this is an offtopic here (please point me to the proper one). > > I brought up UEFI on the device and am trying

Re: [edk2] Authentication status for signed FVs extracted in PEI

2015-11-11 Thread Cohen, Eugene
Mike, > If content is only required in DXE, then consider deferring the FV > publication and authentication to DXE. That may involve adjusting your FV > layout. Originally we had an uncompressed DxeCore.efi decompress the FV with the rest of the components. But the signing already

Re: [edk2] [PATCH] MdeModulePkg PeiCore: PEI dispatcher need retry to process NOT_DISPATCHED FV

2015-11-11 Thread Cohen, Eugene
Good catch. Reviewed-by: Eugene Cohen -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star Zeng Sent: Wednesday, November 11, 2015 3:07 AM To: edk2-devel@lists.01.org Cc: Liming Gao Subject: [edk2] [PATCH]

Re: [edk2] [Patch V2 5/5] Nt32Pkg: Use LogoLib for LOGO and progress bar drawing.

2015-11-11 Thread Dong, Eric
Reviewed-by: Eric Dong -Original Message- From: Ni, Ruiyu Sent: Monday, November 09, 2015 1:24 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Dong, Eric Subject: [Patch V2 5/5] Nt32Pkg: Use LogoLib for LOGO and progress bar drawing. Contributed-under: TianoCore

[edk2] [Patch] MdeModulePkg/BmpImageDecoderLib: Support ImageFormatUnknown type

2015-11-11 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Feng Tian --- MdeModulePkg/Library/BmpImageDecoderLib/BmpImageDecoderLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [edk2] ShellPkg: Network commands (ifconfig/ping) broken

2015-11-11 Thread Andrew Fish
> On Nov 11, 2015, at 8:03 PM, El-Haj-Mahmoud, Samer > wrote: > > I remember we specifically discussed this in the UEFI Forum and decided to > drop the If4ConfigProtocol compatability from the spec. > > If edk2 would like to keep it, it can be done, but will

Re: [edk2] ShellPkg: Network commands (ifconfig/ping) broken

2015-11-11 Thread El-Haj-Mahmoud, Samer
I remember we specifically discussed this in the UEFI Forum and decided to drop the If4ConfigProtocol compatability from the spec. If edk2 would like to keep it, it can be done, but will complicate things. I would recommend a build option to disable /remove the legacy support as new platforms

Re: [edk2] Armv8 64bit: System error booting linux from the UEFI

2015-11-11 Thread Vladimir Olovyannikov
> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Wednesday, November 11, 2015 1:08 AM > To: Vladimir Olovyannikov > Cc: edk2-devel@lists.01.org > Subject: Re: Armv8 64bit: System error booting linux from the UEFI > > On 11 November 2015 at 01:20,

Re: [edk2] ShellPkg: Network commands (ifconfig/ping) broken

2015-11-11 Thread Ye, Ting
One solution to support UEFI 2.4 network modules with UEFI 2.5 ifconfig is to add the code back to use HII services to perform setting. The definition of NIC_IP4_CONFIG_INFO and a private GUID gEfiNicIp4ConfigVariableGuid should be added into ShellPkg as UEFI 2.5 no longer keep the definition

Re: [edk2] [PATCH v4 07/41] OvmfPkg: add PEIM for providing TSEG-as-SMRAM during PEI

2015-11-11 Thread Yao, Jiewen
Thanks Jorden, for your reminder. Hi Laszlo Per my understand, you add NULL implementation for PiSmmCommunicationPpi, just because SmmLockBoxPeiLib depends on it. Right? How about we update SmmLockBoxPeiLib to call InternalRestoreLockBoxFromSmram(), if PiSmmCommunicationPpi is not located?

Re: [edk2] [PATCH] ArmPlatformPkg: bring DS-5 scripts in line with linker script changes

2015-11-11 Thread Ard Biesheuvel
On 10 November 2015 at 20:06, Leif Lindholm wrote: > On 10 November 2015 at 18:10, Ard Biesheuvel > wrote: >> On 6 November 2015 at 08:25, Ard Biesheuvel >> wrote: >>> The ARM and AARCH64 linker scripts have

Re: [edk2] [Patch] MdeModulePkg/BmpImageDecoderLib: Support ImageFormatUnknown type

2015-11-11 Thread Tian, Feng
Shall you change the commit title to something like "error handling enhancement"? Other looks good to me Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Ni, Ruiyu Sent: Thursday, November 12, 2015 14:11 To: edk2-devel@lists.01.org Cc: Ni, Ruiyu;

[edk2] [patch] NetworkPkg: Httpboot will fail the 2nd time result by wrong TCP state.

2015-11-11 Thread Zhang Lubo
If the 2nd boot quickly after the first succeed boot, it will function well, but if you wait for some time and boot again, until the TCP state changed from established to closed wait as the http server send fin flag, then boot fail occurred. Cc: Ye Ting Cc: Fu Siyuan

Re: [edk2] EFI GOP with manual vsync trigger

2015-11-11 Thread Michael Zimmermann
I've started investigating in the timer event problem and I think I have some weird problem with my platform drivers(I hope, so it's not a EDK2 bug). If I create a timer that runs every 100ms which does nothing but a stall(1), the thread mode code stops after some random time(usually in edk2

Re: [edk2] [PATCH v4 02/41] OvmfPkg: Sec: force reinit of BaseExtractGuidedSectionLib handler table

2015-11-11 Thread Jordan Justen
On 2015-11-03 13:00:38, Laszlo Ersek wrote: > BaseExtractGuidedSectionLib uses a table at the static physical address > PcdGuidedExtractHandlerTableAddress, and modules that are linked against > BaseExtractGuidedSectionLib are expected to work together on that table. > Namely, some modules can

Re: [edk2] [PATCH v4 15/41] OvmfPkg: resolve ReportStatusCodeLib for DXE_SMM_DRIVER modules

2015-11-11 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2015-11-03 13:00:51, Laszlo Ersek wrote: > PiSmmCpuDxeSmm depends on this library class, and it's okay to resolve it > generally for all DXE_SMM_DRIVER modules. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by:

Re: [edk2] [PATCH v4 11/41] OvmfPkg: pull in CpuIo2Smm driver

2015-11-11 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2015-11-03 13:00:47, Laszlo Ersek wrote: > This driver provides EFI_SMM_CPU_IO2_PROTOCOL, which the SMM core depends > on in its gEfiDxeSmmReadyToLockProtocolGuid callback > (SmmReadyToLockHandler(),

Re: [edk2] [PATCH v4 16/41] OvmfPkg: resolve CpuExceptionHandlerLib for DXE_SMM_DRIVER modules

2015-11-11 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2015-11-03 13:00:52, Laszlo Ersek wrote: > UefiCpuPkg/PiSmmCpuDxeSmm depends on this library (the > RegisterCpuInterruptHandler() function specifically) to set up its > specialized page fault handler (SmiPFHandler() ->

Re: [edk2] [PATCH v4 10/41] OvmfPkg: pull in the SMM IPL and SMM core

2015-11-11 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2015-11-03 13:00:46, Laszlo Ersek wrote: > "MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf" (a DXE_RUNTIME_DRIVER) > implements the SMM Initial Program Loader. It produces > EFI_SMM_BASE2_PROTOCOL and EFI_SMM_COMMUNICATION_PROTOCOL, relying on:

Re: [edk2] [PATCH v4 12/41] OvmfPkg: AcpiS3SaveDxe: don't fake LockBox protocol if SMM_REQUIRE

2015-11-11 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2015-11-03 13:00:48, Laszlo Ersek wrote: > In SVN r15306 (git commit d4ba06df), "OvmfPkg: S3 Resume: fake LockBox > protocol for BootScriptExecutorDxe", we installed a fake LockBox protocol > in OVMF's AcpiS3SaveDxe clone. While our other

Re: [edk2] [PATCH v4 07/41] OvmfPkg: add PEIM for providing TSEG-as-SMRAM during PEI

2015-11-11 Thread Jordan Justen
On 2015-11-05 07:45:21, Kinney, Michael D wrote: > Laszlo, > > Thanks for the details. Your implementation looks good. > > I will discuss this further with Jiewen to see if it makes sense to > provide additional implementations of this PPI that could be shared > by multiple platforms. Mike,

[edk2] [patch 5/7] MdeModulePkg/Include/Guid:Add Guid file

2015-11-11 Thread Dandan Bi
Add the FrontPage Guid and SetupEnter Guid used by new added libraries. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Include/Guid/HiiFrontPageFormset.h | 26 +

[edk2] [patch 6/7] MdeModulePkg: To support new UiApp.

2015-11-11 Thread Dandan Bi
Add the new added Guid and libraries to the dec and dsc file in MdeModulePkg. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/MdeModulePkg.dec | 6 ++ MdeModulePkg/MdeModulePkg.dsc | 4 2 files changed, 10

[edk2] [patch 2/7] MdeModulePkg:Create Device Manager Library.

2015-11-11 Thread Dandan Bi
Split the device manager library from UiApp in MdeModulePkg/Application and put the library in MdeModulePkg/Library. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Library/DeviceManagerLib/DeviceManager.c | 953

[edk2] [patch 1/7] MdeModulePkg:Create Boot Manager Library

2015-11-11 Thread Dandan Bi
Split the boot manager library from UiApp in MdeModulePkg/Application and put the library in MdeModulePkg/Library. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Library/BootManagerLib/BootManager.c | 820

[edk2] [patch 7/7] Nt32Pk: To support new UiApp.

2015-11-11 Thread Dandan Bi
Add the new added libraries to the Nt32 platform. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- Nt32Pkg/Nt32Pkg.dsc | 4 1 file changed, 4 insertions(+) diff --git a/Nt32Pkg/Nt32Pkg.dsc b/Nt32Pkg/Nt32Pkg.dsc index

[edk2] [patch 0/7]MdeModulePkg:UiApp remodeling task

2015-11-11 Thread Dandan Bi
Our current UiApp code is huge and hard to understand and maintain. So we split it to several independent libraries:device manager,boot manager, boot maintenance manager.Make the code clear and easy to maintain. Dandan Bi (7): MdeModulePkg:Create Boot Manager Library MdeModulePkg:Create