Re: [edk2] Enabling boot menu via serial & PXE boot in CorebootPayloadPkg

Hi Cameron, BTW, please use debug build for Coreboot Payload, such that debug information can be shown in serial console from the very early stage in the Payload's execution. This would help validating the functioning of serial. Thanks, - ben > -Original Message- > From: edk2-devel

Re: [edk2] [PATCH] ArmPlatformPkg: remove ArmGetCpuCountPerCluster () from ArmPlatformLib

On 24 November 2017 at 17:04, Leif Lindholm wrote: > On Wed, Nov 15, 2017 at 02:20:48PM +, Ard Biesheuvel wrote: >> The only user of ArmPlatformLib's ArmGetCpuCountPerCluster () is itself >> an ArmPlatformLib implementation, i.e., ArmVExpressLibRTSM. >> >> Given that

Re: [edk2] [PATCH 0/2] Delete BdsLib dependency from Android loaders

On Sat, Nov 25, 2017 at 03:25:21PM +, Ard Biesheuvel wrote: > On 25 November 2017 at 13:27, Leif Lindholm wrote: > > AndroidBoot and AndroidFastboot (as well as their shared component > > AndroidBootImgLib) have minor dependencies on BdsLib. > > > > First fix up a

Re: [edk2] [RFC] ACPI table HID/CID allocation

> On Nov 25, 2017, at 4:56 AM, Udit Kumar wrote: > > > >> -Original Message- >> From: Daniel Thompson [mailto:daniel.thomp...@linaro.org] >> Sent: Thursday, November 23, 2017 1:42 AM >> To: Ard Biesheuvel >> Cc: Udit Kumar

Re: [edk2] [platforms: PATCH v2 1/4] Platform/Marvell: Introduce MvFvbDxe variable support driver

On Tue, Nov 21, 2017 at 07:46:18AM +0100, Marcin Wojtas wrote: > MvFvbDxe driver introduces non-volatile EFI variable support > for Armada platforms. It relies on memory-mapped SPI read access. > Implementation of EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL > is done with using existing Marvell SPI

Re: [edk2] [platforms: PATCH v2 0/4] Armada 7k/8k variable support

On Tue, Nov 21, 2017 at 07:46:17AM +0100, Marcin Wojtas wrote: > Hi, > > I submit v2 of the Armada variable support with the style of > the MvFvbDxe driver fixed and other minor modifications. Depex > configuration was moved from 4/4 to previous patches. Details > can be found in the changelog

Re: [edk2] [PATCH] [edk2-platforms]: Adding usb Host driver support from OpenPlatformPkg hikey-wip branch

Hi Kalyan, This is a huge (and much appreciated) contribution. However, in order to simplify reviewing, could you please: 1) Configure your edk2-platforms clone as described in

Re: [edk2] [PATCH 0/2] Delete BdsLib dependency from Android loaders

On 25 November 2017 at 13:27, Leif Lindholm wrote: > AndroidBoot and AndroidFastboot (as well as their shared component > AndroidBootImgLib) have minor dependencies on BdsLib. > > First fix up a missing mapping in EmbeddedPkg.dsc to let the modules > build standalone.

Re: [edk2] Enabling boot menu via serial & PXE boot in CorebootPayloadPkg

Hi Cameron, CorebootPayloadPkg does support serial output as user interface. To enable serial, the CorebootPayloadPkg retrieves serial information from Coreboot through CorebootModulePkg\Library\CbParseLib\CbParseLib.c => CbParseSerialInfo(), which is called by CorebootPayloadPkg\Library\

Re: [edk2] [RFC] Add EFI lock when creating new gauge record

Hi Star, Sorry to make a mistake with the code package :) Please see my test results below. 在 11/24/2017 5:41 PM, Zeng, Star 写道: Good problem statement. EndGaugeEx and GetGaugeEx also need to be updated as they are operating same memory buffer, otherwise the performance data may be messed

Re: [edk2] [PATCH edk2-platforms v2 00/13] Move ArmPlatformPkg stuff into edk2-platforms

On Thu, Nov 16, 2017 at 05:58:30PM +, Ard Biesheuvel wrote: > This is mostly a preparatory series that will allow us to get rid of a lot > of code that is specific to only a single ARM development platform out of > the main EDK2 tree. > > First of all, it removes a couple of false

Re: [edk2] [PATCH edk2-platforms v5 1/6] Silicon/SynQuacer: implement 'clear NVRAM' feature using a DIP switch

On Fri, Nov 17, 2017 at 07:04:18PM +, Ard Biesheuvel wrote: > Ordinary computers typically have a physical switch or jumper on the > board that allows non-volatile settings to be cleared. Let's implement > the same using DIP switch #1 on block #3, and clear the EFI variable > store if it is

Re: [edk2] [PATCH edk2-platforms v5 0/6] add remaining support for Socionext SynQuacer

On Fri, Nov 17, 2017 at 07:04:17PM +, Ard Biesheuvel wrote: > These are the remaining patches that still need review after the majority > of the Socionext SynQuacer support patches were merged. All remaining patches in series: Reviewed-by: Leif Lindholm > Changes

Re: [edk2] [RFC] ACPI table HID/CID allocation

> -Original Message- > From: Daniel Thompson [mailto:daniel.thomp...@linaro.org] > Sent: Thursday, November 23, 2017 1:42 AM > To: Ard Biesheuvel > Cc: Udit Kumar ; Leif Lindholm > ; edk2-devel@lists.01.org; Varun

[edk2] 答复: [PATCH v2 7/8] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

Hi, About 1.1), I agree with Jiewen’s suggestion. Besides it, we also need to provide dummy function of InitializeCpuExceptionStackSwitchHandlers() in NULL instance in MdeModulePkg/Library/CpuExceptionHandlerLibNull. But we need to think about the return status carefully. For example, if

[edk2] [PATCH 1/2] EmbeddedPkg: add UefiRuntimeLib resolution to package .dsc

Required to build Android*Boot standalone. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Leif Lindholm --- EmbeddedPkg/EmbeddedPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/EmbeddedPkg/EmbeddedPkg.dsc b/EmbeddedPkg/EmbeddedPkg.dsc

[edk2] [PATCH 2/2] EmbeddedPkg: get rid of BdsLib dependency from Android*Boot

The sum use these applications made of BdsLib was one invocation of the IS_DEVICE_PATH_NODE macro, and (incorrectly) being able to leave out a dependency on gEfiLoadedImageProtocolGuid. So expand the macro in place and add the missing dependency. Then clean up the .dsc, .inf and #includes

[edk2] [PATCH 0/2] Delete BdsLib dependency from Android loaders

AndroidBoot and AndroidFastboot (as well as their shared component AndroidBootImgLib) have minor dependencies on BdsLib. First fix up a missing mapping in EmbeddedPkg.dsc to let the modules build standalone. Then get rid of the use of BdsLib. Leif Lindholm (2): EmbeddedPkg: add UefiRuntimeLib

Re: [edk2] [PATCH edk2-platforms 0/4] Platform/ARM: import BdsLib and FdtPlatformDxe

On Mon, Nov 20, 2017 at 11:37:10AM +, Ard Biesheuvel wrote: > The only remnant of the deprecated ARM BDS in EDK2 is its BdsLib, which is > depended upon by FdtPlatformDxe in EmbeddedPkg, which itself is something > we'd prefer to get rid of. Since only TC2 and Juno actually use this driver, >

Re: [edk2] [PATCH 0/2] remove ARM BdsLib and FdtPlatformDxe

On Mon, Nov 20, 2017 at 11:45:03AM +, Ard Biesheuvel wrote: > Remove two pieces of legacy that are only used by platforms residing under > Platform/ARM in edk2-platforms, and really shouldn't serve as examples for > new contributions. So after migrating the code to edk2-platforms, remove it >

[edk2] 答复: [PATCH v2 0/8] Implement stack guard feature

Jian, I reviewed your patches and sent my minimal comments in other separate mail. They should not impact the functionality. I am ok if you push the v2 patches now and do the updating based on my comments in separate patches later. Reviewed-by: Jeff Fan Thanks! Jeff

Re: [edk2] [PATCH 00/19] ArmPlatformPkg: remove unused or migrated modules

On Wed, Nov 15, 2017 at 04:56:18PM +, Ard Biesheuvel wrote: > Remove everything from ArmPlatformPkg that is either unused, or so highly > specific to development platforms manufactured by ARM Ltd. that they really > don't belong in the main branch. > > Note that the migration involves patches

Re: [edk2] [RFC] ACPI table HID/CID allocation

Thanks Andrew, We have one ACPI PNP ID. I am looking for better way to define ACPI tables. Say a driver (could be slave or master) can work with PRP0001, (example flashes, i2c slaves) then do we need to define HID for the same or not . With condition such driver don’t expose or need some AML

Re: [edk2] [RFC] ACPI table HID/CID allocation

> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Thursday, November 23, 2017 1:10 AM > To: Daniel Thompson > Cc: Udit Kumar ; Leif Lindholm > ; edk2-devel@lists.01.org; Varun

[edk2] 答复: [PATCH v2 2/8] MdeModulePkg/CpuExceptionHandlerLib.h: Add a new API

Hi, I am not sure if this is good idea to define such arch specific definitions in MdeModulePkg. Moreover, we don’t know how ARM or other processors define this definition, either. Jeff From: edk2-devel on behalf of

[edk2] 答复: [PATCH v2 7/8] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

Jian, EFIAPI is not required for ArchSetupExcpetionStack(). Reviewed-by: Jeff Fan Jeff From: edk2-devel on behalf of Jian J Wang Sent: Wednesday, November 22, 2017

Re: [edk2] 答复: [PATCH v2 0/8] Implement stack guard feature

I do not think it is a good idea to push it now. I think we need more thought on API design especially for pei/smm in the future. (My comment for 1.2/1.3/1.4) thank you! Yao, Jiewen > 在 2017年11月25日，下午9:44，Fan Jeff 写道： > > Jian, > > I reviewed your patches and sent