[edk2] [RFC v5 7/8] UefiCpuPkg/CpuExceptionHandlerLib: Validate memory address ranges

2018-01-14 Thread Paulo Alcantara
Introduce a new IsLinearAddressRangeValid() function to validate a given address range and check whether or not it is valid. This function is useful for validating ranges of memory addresses during stack traces in X64. Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Eric Dong

[edk2] [RFC v5 0/8] Stack trace support in X64 exception handling

2018-01-14 Thread Paulo Alcantara
Hi, This series adds stack trace support during IA32 and X64 CPU exceptions. Informations like back trace, stack contents and image module names (that were part of the call stack) will be dumped out. The current limitation is that it relies on available frame pointers (GCC only) in order to

[edk2] [RFC v5 4/8] UefiCpuPkg/CpuExceptionHandlerLib: Add helper to validate memory addresses

2018-01-14 Thread Paulo Alcantara
Introduce IsLinearAddressValid() function that will be used for validating memory addresses that would get dereferenced during stack traces in IA32 and X64 CPU exceptions. Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Eric Dong Cc: Laszlo Ersek

[edk2] [RFC v5 8/8] UefiCpuPkg/CpuExceptionHandlerLib: Add early check in DumpStackContents

2018-01-14 Thread Paulo Alcantara
Add an early check in DumpStackContens() to abort in case of no unwound stacks. Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Eric Dong Cc: Laszlo Ersek Signed-off-by: Paulo Alcantara ---

[edk2] [RFC v5 6/8] UefiCpuPkg/CpuExceptionHandlerLib: Correctly print IP addresses

2018-01-14 Thread Paulo Alcantara
Remove the supurious '- 1' when calculating the IP addresses during the stack traces. Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Eric Dong Cc: Laszlo Ersek Requested-by: Jeff Fan Signed-off-by: Paulo Alcantara

[edk2] [RFC v5 3/8] UefiCpuPkg/CpuExceptionHandlerLib/Ia32: Add stack trace support

2018-01-14 Thread Paulo Alcantara
This patch adds stack trace support during a IA32 CPU exception. It will dump out back trace, stack contents as well as image module names that were part of the call stack. Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Eric Dong Cc: Laszlo Ersek

[edk2] [RFC v5 1/8] UefiCpuPkg/CpuExceptionHandlerLib/X64: Add stack trace support

2018-01-14 Thread Paulo Alcantara
This patch adds stack trace support during a X64 CPU exception. It will dump out back trace, stack contents as well as image module names that were part of the call stack. Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Eric Dong Cc: Laszlo Ersek

[edk2] [RFC v5 5/8] UefiCpuPkg/CpuExceptionHandlerLib: Ensure valid frame/stack pointers

2018-01-14 Thread Paulo Alcantara
Validate all possible memory dereferences during stack traces in IA32 and X64 CPU exceptions. Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Eric Dong Cc: Laszlo Ersek Requested-by: Brian Johnson Requested-by: Jiewen

[edk2] [RFC v5 2/8] UefiCpuPkg/CpuExceptionHandlerLib: Export GetPdbFileName()

2018-01-14 Thread Paulo Alcantara
This function will be used by both IA32 and X64 exception handling in order to print out image module names during stack unwinding. Cc: Eric Dong Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Paulo Alcantara

[edk2] [PATCH] IntelSiliconPkg IntelVTdDxe: Fix potential NULL pointer dereference

2018-01-14 Thread Star Zeng
The implementation of MdeModulePkg\Universal\Acpi\AcpiTableDxe reserves first entry of RSDT/XSDT to FADT, the first entry value is 0 when FADT is installed. So the RSDT/XSDT parsing code should check the entry value first before checking the table signature. Cc: Jiewen Yao

Re: [edk2] [PATCH] IntelSiliconPkg IntelVTdDxe: Fix potential NULL pointer dereference

2018-01-14 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star > Zeng > Sent: Monday, January 15, 2018 10:35 AM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Zeng, Star >

[edk2] [PATCH 3/3] MdeModulePkg/FrameBufferBltLib: Fix copying of unaligned memory

2018-01-14 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1 Reported-by: Christian Ehrhardt Signed-off-by: Christian Ehrhardt Cc: Star Zeng Reviewed-by: Ruiyu Ni ---

[edk2] [PATCH 0/3] Fix two bugs in FrameBufferBltLib.

2018-01-14 Thread Ruiyu Ni
Ruiyu Ni (3): MdeModulePkg/FrameBufferBltLib: Use UINT32 type for internal data MdeModulePkg/FrameBufferBltLib: Fix a bug causing display corrupted MdeModulePkg/FrameBufferBltLib: Fix copying of unaligned memory .../Library/FrameBufferBltLib/FrameBufferBltLib.c | 61 --

[edk2] [PATCH 2/3] MdeModulePkg/FrameBufferBltLib: Fix a bug causing display corrupted

2018-01-14 Thread Ruiyu Ni
The Graphics Output Protocol's mode information specifies the PixelsPerScanLine property. Most of the time this is identical to HorizontalResolution. However, due to alignment requirements etc. it may be slightly larger. I.e. each scan line will have some "pixels" that are not visible on the

[edk2] [PATCH 1/3] MdeModulePkg/FrameBufferBltLib: Use UINT32 type for internal data

2018-01-14 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Star Zeng --- .../Library/FrameBufferBltLib/FrameBufferBltLib.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git

[edk2] Question about merge efi application into BIOS

2018-01-14 Thread 高念慈
Hello I write an efi tool and try to merge to BIOS, then execute from BIOS. My idea as follow, but i don't know my concept is right or not 1. write .inf file to produce firmware volume(FV) 2. Copy FV to memory (load image ?) 3. start image to execute my efi tool [On step1] , my efi tool could

Re: [edk2] [PATCH] UefiCpuPkg: Enhance feature dependency check

2018-01-14 Thread Dong, Eric
Reviewed-by: Eric Dong -Original Message- From: Song, BinX Sent: Friday, January 12, 2018 10:19 AM To: edk2-devel@lists.01.org Cc: Dong, Eric ; ler...@redhat.com Subject: [PATCH] UefiCpuPkg: Enhance feature dependency check Enhance MCA feature

Re: [edk2] [Patch 2/2] MdeModulePkg: Did some code enhancement for DxeIpIpLib.

2018-01-14 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Wang Fan > Sent: Wednesday, January 10, 2018 11:16 AM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Fu, Siyuan

Re: [edk2] [Patch 1/2] MdeModulePkg: Freed the received packet buffer if it is not expected.

2018-01-14 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan > -Original Message- > From: Wang, Fan > Sent: Wednesday, January 10, 2018 11:16 AM > To: edk2-devel@lists.01.org > Cc: Wu, Jiaxin ; Ye, Ting ; Fu, > Siyuan > Subject: [Patch 1/2]

[edk2] [PATCH] CrptoPkg/BaseCryptLib: Fix type mismatch when calling OpenSSL function

2018-01-14 Thread Zhang, Chao B
Type definition in UEFI & OpeenSSL is different. Sometime it could cause write overflow. Should use same data type when accessing the same region Cc: Long Qin Cc: Chen Chen Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chao

Re: [edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Add support for Sony camera imx219

2018-01-14 Thread Wei, David
Reviewed-by: zwei4 Thanks, David Wei Intel SSG/STO/UEFI BIOS > -Original Message- > From: Rytkonen, Teemu S > Sent: Saturday, January 13, 2018 2:46 AM > To: edk2-devel@lists.01.org > Cc: Wei, David ;

[edk2] [PATCH v2] MdeModulePkg/DebugLib: Print partial when format string is too long

2018-01-14 Thread Ruiyu Ni
Today's implementation prints nothing when the format string cannot fit in the report status extended data buffer. It confuses user. The patch changes to print partial message by truncating the format string when it's too long. The missing enhancement is the extended data buffer only reserves 96

Re: [edk2] [PATCH v2] MdeModulePkg/DebugLib: Print partial when format string is too long

2018-01-14 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Ni, Ruiyu >Sent: Monday, January 15, 2018 12:00 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [PATCH v2] MdeModulePkg/DebugLib: Print partial when format >string is too long >

Re: [edk2] [PATCH] CrptoPkg/BaseCryptLib: Fix type mismatch when calling OpenSSL function

2018-01-14 Thread Long, Qin
Chao, Could you leverage the EFI type instead of C type here for consistence? We can use "INT32" type for Asn1Tag and ObjClass, and one "UINTN" Length should be OK with one extra zeroing here. Best Regards & Thanks, LONG, Qin -Original Message- From: Zhang, Chao B Sent: Monday,

Re: [edk2] [PATCH] CrptoPkg/BaseCryptLib: Fix type mismatch when calling OpenSSL function

2018-01-14 Thread Zhang, Chao B
Qin: That makes sense to me. Thanks for the comment. -Original Message- From: Long, Qin Sent: Monday, January 15, 2018 2:04 PM To: Zhang, Chao B ; edk2-devel@lists.01.org Cc: Chen, Chen A Subject: RE: [PATCH] CrptoPkg/BaseCryptLib: Fix

[edk2] [PATCH] SecurityPkg/PhysicalPresenceLib: Reject illegal PCR bank allocation

2018-01-14 Thread Zhang, Chao B
According to TCG PP1.3 spec, error PCR bank allocation input should be rejected by Physical Presence. Firmware has to ensure that at least one PCR banks is active. Cc: Long Qin Cc: Yao Jiewen Contributed-under: TianoCore Contribution Agreement 1.1

Re: [edk2] [PATCH] SecurityPkg/PhysicalPresenceLib: Reject illegal PCR bank allocation

2018-01-14 Thread Long, Qin
Reviewed-by: Long Qin Best Regards & Thanks, LONG, Qin -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang, Chao B Sent: Monday, January 15, 2018 3:29 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen ;