[edk2] [PATCH 2/2] MdeModulePkg/SdMmcPciHcDxe: Add V4 64bit ADMA2 support.

2018-11-08 Thread Ashish Singhal
If V4 64 bit address mode is enabled in compatibility register, program controller to enable V4 host mode and use appropriate ADMA descriptors supporting 64 bit addresses. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ashish Singhal --- MdeModulePkg/Bus/Pci

[edk2] [PATCH 1/2] MdeModulePkg/SdMmcPciHcDxe: Declare V4 64 bit address capability

2018-11-08 Thread Ashish Singhal
check as spec for previous SDMMC versions defines this field as reserved with default value of 0. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ashish Singhal --- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 4 ++-- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe

Re: [edk2] [PATCH v2 3/4] MdePkg/UefiLib: Simplify protocol un/installation abstraction

2019-01-06 Thread Ashish Singhal
as in patch 1/4, I am OK submitting a new patch where I can squash 1/4 and 3/4 together into a single commit and keep API as in 1/4. Thanks Ashish -Original Message- From: Gao, Liming Sent: Sunday, January 6, 2019 5:33 PM To: Ashish Singhal ; edk2-devel@lists.01.org Subject: RE: [edk2

[edk2] [PATCH v3 2/2] NetworkPkg/IScsiDxe: Use UEFILib APIs to uninstall protocols.

2019-01-06 Thread Ashish Singhal
During cleanup in case of initialization failure, some driver bindings are not installed. Using abstractions in UEFILib takes care of it. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1428 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ashish Singhal

[edk2] [PATCH v3 0/2] Provide UEFILib functions for protocol uninstallation.

2019-01-06 Thread Ashish Singhal
in the future. Bug 1429 was found to track this. The first 2 patches take care of this. Patch number 1 also simplifies the UEFILib protocol installation and uninstallation abstraction by adding a helper function doing operations instead of every public function. Ashish Singhal (2): MdePkg

[edk2] [PATCH v3 1/2] MdePkg/UefiLib: Abstract driver model protocol uninstallation

2019-01-06 Thread Ashish Singhal
it by itself. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1429 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ashish Singhal --- MdePkg/Include/Library/UefiLib.h | 103 +++ MdePkg/Library/UefiLib/UefiDriverModel.c | 1186 -- 2

Re: [edk2] [PATCH v6 2/2] MdeModulePkg/SdMmcPciHcDxe: Add SDMMC HC v4 and above Support.

2018-12-18 Thread Ashish Singhal
From: Wu, Hao A Sent: Friday, November 30, 2018 1:03:15 AM To: Ashish Singhal; edk2-devel@lists.01.org Subject: RE: [edk2] [PATCH v6 2/2] MdeModulePkg/SdMmcPciHcDxe: Add SDMMC HC v4 and above Support. Hello, Please refer to the inline comments below: > -Original Mess

[edk2] [PATCH v7] MdeModulePkg/SdMmcPciHcDxe: Add SDMMC HC v4 and above Support.

2018-12-18 Thread Ashish Singhal
appropriately. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ashish Singhal --- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c| 2 +- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c | 4 +- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 21 +- MdeModulePkg/Bus

Re: [edk2] [PATCH v7] MdeModulePkg/SdMmcPciHcDxe: Add SDMMC HC v4 and above Support.

2018-12-26 Thread Ashish Singhal
Hello Hao, Do you happen to have any update on this? Thanks Ashish -Original Message- From: Wu, Hao A Sent: Tuesday, December 18, 2018 6:47 PM To: Ashish Singhal ; edk2-devel@lists.01.org Subject: RE: [edk2] [PATCH v7] MdeModulePkg/SdMmcPciHcDxe: Add SDMMC HC v4 and above Support

Re: [edk2] [PATCH v7] MdeModulePkg/SdMmcPciHcDxe: Add SDMMC HC v4 and above Support.

2018-12-19 Thread Ashish Singhal
No problem. Please let me know when you have reviewed it and I will send the final patch with your name as reviewer. Thanks Ashish From: Wu, Hao A Sent: Tuesday, December 18, 2018 6:46:57 PM To: Ashish Singhal; edk2-devel@lists.01.org Subject: RE: [edk2

Re: [edk2] [PATCH v3 2/2] MdeModulePkg/SdMmcPciHcDxe: Add V4 64bit SDMA and ADMA2 support.

2018-11-29 Thread Ashish Singhal
Missed one of your suggested compiler related change in Patch 5. Have posted patch 6. Thanks Ashish Singhal -Original Message- From: Ashish Singhal Sent: Thursday, November 29, 2018 11:48 AM To: 'Wu, Hao A' ; edk2-devel@lists.01.org Subject: RE: [edk2] [PATCH v3 2/2] MdeModulePkg

[edk2] [PATCH v5 2/2] MdeModulePkg/SdMmcPciHcDxe: Add SDMMC HC v4 and above Support.

2018-11-29 Thread Ashish Singhal
appropriately. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1359 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ashish Singhal --- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 4 +- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 328

[edk2] [PATCH v5 1/2] MdeModulePkg/SdMmcPciHcDxe: Declare V4 64 bit address capability

2018-11-29 Thread Ashish Singhal
check as spec for previous SDMMC versions defines this field as reserved with default value of 0. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1359 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ashish Singhal --- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c

Re: [edk2] [PATCH v3 2/2] MdeModulePkg/SdMmcPciHcDxe: Add V4 64bit SDMA and ADMA2 support.

2018-11-29 Thread Ashish Singhal
, November 28, 2018 12:25 AM To: Ashish Singhal ; edk2-devel@lists.01.org Subject: RE: [edk2] [PATCH v3 2/2] MdeModulePkg/SdMmcPciHcDxe: Add V4 64bit SDMA and ADMA2 support. Hello, Sorry for the delayed response. Apart from inserting the Bugzilla tracker information, several more general level

Re: [edk2] [PATCH v3 2/2] MdeModulePkg/SdMmcPciHcDxe: Add V4 64bit SDMA and ADMA2 support.

2018-11-27 Thread Ashish Singhal
Hello, Any feedback on this patch yet? Thanks Ashish -Original Message- From: Ashish Singhal Sent: Monday, November 19, 2018 1:59 PM To: edk2-devel@lists.01.org Cc: Ashish Singhal Subject: [PATCH v3 2/2] MdeModulePkg/SdMmcPciHcDxe: Add V4 64bit SDMA and ADMA2 support. If V4 64 bit

Re: [edk2] [PATCH v3 1/2] MdeModulePkg/SdMmcPciHcDxe: Declare V4 64 bit address capability

2018-11-28 Thread Ashish Singhal
Separate V4 1/2 patch has been submitted with changes made as per feedback. Thanks Ashish -Original Message- From: Wu, Hao A Sent: Wednesday, November 28, 2018 12:25 AM To: Ashish Singhal ; edk2-devel@lists.01.org Subject: RE: [edk2] [PATCH v3 1/2] MdeModulePkg/SdMmcPciHcDxe: Declare

[edk2] [PATCH v4 1/2] MdeModulePkg/SdMmcPciHcDxe: Declare V4 64 bit address capability

2018-11-28 Thread Ashish Singhal
check as spec for previous SDMMC versions defines this field as reserved with default value of 0. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1359 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ashish Singhal --- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c

[edk2] [PATCH v2 1/2] MdeModulePkg/SdMmcPciHcDxe: Declare V4 64 bit address capability

2018-11-19 Thread Ashish Singhal
check as spec for previous SDMMC versions defines this field as reserved with default value of 0. Change-Id: I64fcb674ec566c46a37ea6597ae06cb194625cae Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ashish Singhal --- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 4

[edk2] [PATCH v2 2/2] MdeModulePkg/SdMmcPciHcDxe: Add V4 64bit SDMA and ADMA2 support.

2018-11-19 Thread Ashish Singhal
: TianoCore Contribution Agreement 1.1 Signed-off-by: Ashish Singhal --- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 4 +- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 273 + MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h | 28 ++- 3 files changed, 260

Re: [edk2] [PATCH 2/2] MdeModulePkg/SdMmcPciHcDxe: Add V4 64bit ADMA2 support.

2018-11-19 Thread Ashish Singhal
with and without enabling 64b addressing support. Thanks Ashish -Original Message- From: Wu, Hao A Sent: Friday, November 16, 2018 1:27 AM To: Ashish Singhal ; edk2-devel@lists.01.org Subject: RE: [edk2] [PATCH 2/2] MdeModulePkg/SdMmcPciHcDxe: Add V4 64bit ADMA2 support. > -Original Mess

Re: [edk2] [PATCH v3 0/2] Provide UEFILib functions for protocol uninstallation.

2019-01-08 Thread Ashish Singhal
: Tuesday, January 8, 2019 7:58 PM To: Ashish Singhal ; edk2-devel@lists.01.org; Gao, Liming ; Fu, Siyuan ; Wu, Jiaxin ; Kinney, Michael D Subject: RE: [PATCH v3 0/2] Provide UEFILib functions for protocol uninstallation. Ashish, When I do full platform builds and individual driver builds

Re: [edk2] [PATCH v4 0/2] Provide UEFILib functions for protocol uninstallation

2019-01-09 Thread Ashish Singhal
v4. Please let me know if you have any issues with this going in. Thanks Ashish -Original Message- From: Kinney, Michael D Sent: Wednesday, January 9, 2019 5:56 PM To: Ashish Singhal ; edk2-devel@lists.01.org; Kinney, Michael D Cc: Gao, Liming ; Fu, Siyuan ; Wu, Jiaxin Subject: RE

Re: [edk2] [PATCH v4 0/2] Provide UEFILib functions for protocol uninstallation

2019-01-10 Thread Ashish Singhal
Siyuan approved the patch from PATCH v2 which is exactly same as in PATCH v4. Thanks Ashish -Original Message- From: Gao, Liming Sent: Thursday, January 10, 2019 8:23 AM To: Ashish Singhal ; Kinney, Michael D ; edk2-devel@lists.01.org Cc: Fu, Siyuan ; Wu, Jiaxin Subject: RE: [PATCH v4

Re: [edk2] [PATCH v4 0/2] Provide UEFILib functions for protocol uninstallation

2019-01-10 Thread Ashish Singhal
Thanks everyone. -Original Message- From: Gao, Liming Sent: Thursday, January 10, 2019 8:39 AM To: Ashish Singhal ; Kinney, Michael D ; edk2-devel@lists.01.org Cc: Fu, Siyuan ; Wu, Jiaxin Subject: RE: [PATCH v4 0/2] Provide UEFILib functions for protocol uninstallation Pushed them

[edk2] [PATCH] NetworkPkg: Protocol Uninstallation Cleanup

2019-01-10 Thread Ashish Singhal
Use UEFILib provided protocol uninstallation abstraction instead of direct API for a proper cleanup. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1444 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ashish Singhal --- NetworkPkg/DnsDxe/DnsDriver.c | 30

Re: [edk2] [PATCH v3 0/2] Provide UEFILib functions for protocol uninstallation.

2019-01-07 Thread Ashish Singhal
+ Maintainers -Original Message- From: Ashish Singhal Sent: Sunday, January 6, 2019 9:38 PM To: edk2-devel@lists.01.org Cc: Ashish Singhal Subject: [PATCH v3 0/2] Provide UEFILib functions for protocol uninstallation. An issue was seen in IScsiDxe in NetworkPkg where driver cleanup

Re: [edk2] [PATCH v3 0/2] Provide UEFILib functions for protocol uninstallation.

2019-01-07 Thread Ashish Singhal
at was used to install. Thanks, Mike > -Original Message- > From: Ashish Singhal [mailto:ashishsin...@nvidia.com] > Sent: Monday, January 7, 2019 6:02 AM > To: edk2-devel@lists.01.org; Kinney, Michael D > ; Gao, Liming ; Fu, > Siyuan ; Wu, Jiaxin > Subject: RE: [PATCH

[edk2] [PATCH v2 3/4] MdePkg/UefiLib: Simplify protocol un/installation abstraction

2019-01-04 Thread Ashish Singhal
Add a helper function to operate upon protocol installation and uninstallation instead of every function doing it by itself. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ashish Singhal --- MdePkg/Include/Library/UefiLib.h | 26 +- MdePkg/Library/UefiLib

[edk2] [PATCH v2 2/4] NetworkPkg/IScsiDxe: Use UEFILib APIs to uninstall protocols.

2019-01-04 Thread Ashish Singhal
During cleanup in case of initialization failure, some driver bindings are not installed. Using abstractions in UEFILib takes care of it. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1428 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ashish Singhal

[edk2] [PATCH v2 4/4] NetworkPkg/IScsiDxe: Update UEFILib Usage

2019-01-04 Thread Ashish Singhal
Update interfaces as exposed by UEFILib for protocol installation and uninstallation abstraction. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ashish Singhal --- NetworkPkg/IScsiDxe/IScsiDriver.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NetworkPkg

[edk2] [PATCH v2 0/4] Provide UEFILib functions for protocol uninstallation.

2019-01-04 Thread Ashish Singhal
uninstallation interfaces as a result of patch 3. Ashish Singhal (4): MdePkg/UefiLib: Abstract driver model protocol uninstallation NetworkPkg/IScsiDxe: Use UEFILib APIs to uninstall protocols. MdePkg/UefiLib: Simplify protocol un/installation abstraction NetworkPkg/IScsiDxe: Update UEFILib Usage

[edk2] [PATCH v2 1/4] MdePkg/UefiLib: Abstract driver model protocol uninstallation

2019-01-04 Thread Ashish Singhal
-off-by: Ashish Singhal --- MdePkg/Include/Library/UefiLib.h | 103 MdePkg/Library/UefiLib/UefiDriverModel.c | 972 ++- 2 files changed, 1074 insertions(+), 1 deletion(-) diff --git a/MdePkg/Include/Library/UefiLib.h b/MdePkg/Include/Library/UefiLib.h

Re: [edk2] [PATCH v3 0/2] Provide UEFILib functions for protocol uninstallation.

2019-01-08 Thread Ashish Singhal
Thanks Mike. Please let me know if you have any more questions and/or comments. Thanks Ashish -Original Message- From: Kinney, Michael D Sent: Tuesday, January 8, 2019 9:26 AM To: Ashish Singhal ; edk2-devel@lists.01.org; Gao, Liming ; Fu, Siyuan ; Wu, Jiaxin ; Kinney, Michael D

Re: [edk2] Uninstalling Invalid Protocol Interfaces

2019-01-04 Thread Ashish Singhal
it yet) also absorb the change? Thanks Ashish From: Kinney, Michael D Sent: Friday, January 4, 2019 10:15 AM To: Ashish Singhal ; edk2-devel@lists.01.org; Kinney, Michael D Cc: Gao, Liming ; Fu, Siyuan ; Wu, Jiaxin Subject: RE: Uninstalling Invalid Protocol Interfaces Ashish, Thanks

Re: [edk2] [PATCH] NetworkPkg: Protocol Uninstallation Cleanup

2019-01-13 Thread Ashish Singhal
Thanks Jiaxin. Please let me know if anything else is needed to mainline it. -Original Message- From: Wu, Jiaxin Sent: Thursday, January 10, 2019 6:01 PM To: Ashish Singhal ; edk2-devel@lists.01.org Cc: Fu, Siyuan Subject: RE: [PATCH] NetworkPkg: Protocol Uninstallation Cleanup Looks

[edk2] [PATCH v4 0/2] Provide UEFILib functions for protocol uninstallation

2019-01-09 Thread Ashish Singhal
in the future. Bug 1429 was found to track this. These 2 patches take care of this. Ashish Singhal (2): MdePkg/UefiLib: Abstract driver model protocol uninstallation NetworkPkg/IScsiDxe: Use UEFILib APIs to uninstall protocols. MdePkg/Include/Library/UefiLib.h | 103 MdePkg

[edk2] [PATCH v4 1/2] MdePkg/UefiLib: Abstract driver model protocol uninstallation

2019-01-09 Thread Ashish Singhal
-off-by: Ashish Singhal --- MdePkg/Include/Library/UefiLib.h | 103 MdePkg/Library/UefiLib/UefiDriverModel.c | 972 ++- 2 files changed, 1074 insertions(+), 1 deletion(-) diff --git a/MdePkg/Include/Library/UefiLib.h b/MdePkg/Include/Library/UefiLib.h

[edk2] [PATCH v4 2/2] NetworkPkg/IScsiDxe: Use UEFILib APIs to uninstall protocols.

2019-01-09 Thread Ashish Singhal
During cleanup in case of initialization failure, some driver bindings are not installed. Using abstractions in UEFILib takes care of it. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1428 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ashish Singhal

Re: [edk2] Uninstalling Invalid Protocol Interfaces

2019-01-03 Thread Ashish Singhal
, January 3, 2019 5:09 PM To: Ashish Singhal ; edk2-devel@lists.01.org; Kinney, Michael D Cc: Gao, Liming ; Fu, Siyuan ; Wu, Jiaxin Subject: RE: Uninstalling Invalid Protocol Interfaces Hi Ashish, Can you provide a pointer to the UninstallMultipleProtocolInterfaces() call that is causing

[edk2] [PATCH v8] MdeModulePkg/SdMmcPciHcDxe: Add SDMMC HC v4 and above Support.

2019-01-02 Thread Ashish Singhal
appropriately. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1359 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ashish Singhal Reviewed-by: Hao Wu --- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c| 3 +- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c | 5

Re: [edk2] [PATCH v7] MdeModulePkg/SdMmcPciHcDxe: Add SDMMC HC v4 and above Support.

2019-01-02 Thread Ashish Singhal
Hello Hao, I have submitted patch v8 which incorporates all the changes. Thanks Ashish -Original Message- From: Wu, Hao A Sent: Tuesday, January 1, 2019 11:37 PM To: Wu, Hao A ; Ashish Singhal ; edk2-devel@lists.01.org Subject: RE: [edk2] [PATCH v7] MdeModulePkg/SdMmcPciHcDxe: Add

[edk2] Uninstalling Invalid Protocol Interfaces

2019-01-03 Thread Ashish Singhal
Hello, As part of moving from MdeModulePkg implementation of IScsiDxe to the implementation in NetworkPkg, I started hitting exception in the driver loaded after IScsiDxe if IScsiDxe's installation fails for some reason. Upon debugging, I found out that calls to

[edk2] [PATCH 2/4] NetworkPkg/IScsiDxe: Use UEFILib APIs to uninstall protocols.

2019-01-04 Thread Ashish Singhal
During cleanup in case of initialization failure, some driver bindings are not installed. Using abstractions in UEFILib takes care of it. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1428 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ashish Singhal

[edk2] [PATCH 0/4] Provide UEFILib functions for protocol uninstallation.

2019-01-04 Thread Ashish Singhal
uninstallation interfaces as a result of patch 3. Ashish Singhal (4): MdePkg/UefiLib: Abstract driver model protocol uninstallation NetworkPkg/IScsiDxe: Use UEFILib APIs to uninstall protocols. MdePkg/UefiLib: Simplify protocol un/installation abstraction NetworkPkg/IScsiDxe: Update UEFILib Usage

[edk2] [PATCH 3/4] MdePkg/UefiLib: Simplify protocol un/installation abstraction

2019-01-04 Thread Ashish Singhal
Add a helper function to operate upon protocol installation and uninstallation instead of every function doing it by itself. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ashish Singhal --- MdePkg/Include/Library/UefiLib.h | 26 +- MdePkg/Library/UefiLib

[edk2] [PATCH 1/4] MdePkg/UefiLib: Abstract driver model protocol uninstallation

2019-01-04 Thread Ashish Singhal
-off-by: Ashish Singhal --- MdePkg/Include/Library/UefiLib.h | 103 MdePkg/Library/UefiLib/UefiDriverModel.c | 972 ++- 2 files changed, 1074 insertions(+), 1 deletion(-) diff --git a/MdePkg/Include/Library/UefiLib.h b/MdePkg/Include/Library/UefiLib.h

[edk2] [PATCH 4/4] NetworkPkg/IScsiDxe: Update UEFILib Usage

2019-01-04 Thread Ashish Singhal
Update interfaces as exposed by UEFILib for protocol installation and uninstallation abstraction. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ashish Singhal --- NetworkPkg/IScsiDxe/IScsiDriver.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NetworkPkg

Re: [edk2] Uninstalling Invalid Protocol Interfaces

2019-01-04 Thread Ashish Singhal
Mike, I have addressed the issue along with some optimizations and have submitted patches for review. Thanks Ashish From: Ashish Singhal Sent: Friday, January 4, 2019 10:33 AM To: 'Kinney, Michael D' ; edk2-devel@lists.01.org Cc: Gao, Liming ; Fu, Siyuan ; Wu, Jiaxin Subject: RE

[edk2] Fmp Payload Header Usage

2019-01-29 Thread Ashish Singhal
Hello Michael/Liming, I am trying to use FmpDevicePkg for FMP based capsule update and am failing in FmpPayloadHeaderLib while verifying FMP payload header. I am building capsule and payload using FDF file itself and not calling Capsule tools explicitly from basetools. Is there a special build

[edk2] [PATCH] MdePkg/UefiLib: Simplify protocol un/installation abstraction

2019-02-04 Thread Ashish Singhal
Add helper functions to operate upon protocol installation and uninstallation instead of every function doing it by itself. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ashish Singhal --- MdePkg/Library/UefiLib/UefiDriverModel.c | 2040 +- 1

Re: [edk2] [PATCH v3 0/2] Provide UEFILib functions for protocol uninstallation.

2019-02-04 Thread Ashish Singhal
Mike, I have refactored my change and with this I am not seeing any size bloating in DEBUG or RELEASE images I am building for my platform. The new change has been submitted for consideration. Thanks Ashish -Original Message- From: Ashish Singhal Sent: Tuesday, January 8, 2019 8:02

Re: [edk2] [PATCH] MdePkg/UefiLib: Simplify protocol un/installation abstraction

2019-02-19 Thread Ashish Singhal
Hello Mike/Lao, Were you able to have a look at this? Thanks Ashish -Original Message- From: Ashish Singhal Sent: Monday, February 4, 2019 1:16 PM To: edk2-devel@lists.01.org Cc: michael.d.kin...@intel.com; liming@intel.com; Ashish Singhal Subject: [PATCH] MdePkg/UefiLib

Re: [edk2] [PATCH] MdePkg/UefiLib: Simplify protocol un/installation abstraction

2019-02-25 Thread Ashish Singhal
Mike, Do you have any update on this change yet? Thanks Ashish -Original Message- From: Kinney, Michael D Sent: Tuesday, February 19, 2019 12:56 PM To: Ashish Singhal ; edk2-devel@lists.01.org; Kinney, Michael D Cc: Gao, Liming Subject: RE: [PATCH] MdePkg/UefiLib: Simplify protocol

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems

2019-02-28 Thread Ashish Singhal
. Thanks Ashish -Original Message- From: Cohen, Eugene Sent: Thursday, February 28, 2019 4:24 AM To: Wu, Hao A ; edk2-devel@lists.01.org Cc: Ashish Singhal Subject: RE: [PATCH] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems Hao, > I remember the com

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems

2019-02-28 Thread Ashish Singhal
Support64BitDma = FALSE; } With this, we would be checking 64b capability based on the version we are using and not for something we may not be using despite of being advertised in the controller. Thanks Ashish From: Cohen, Eugene Sent: Thursday, February 28, 2019 2:59 PM To: Ashish Singha

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems

2019-02-28 Thread Ashish Singhal
kef> From: Cohen, Eugene Sent: Thursday, February 28, 2019 5:11 PM To: Ashish Singhal; Wu, Hao A; edk2-devel@lists.01.org; Ard Biesheuvel Subject: RE: [PATCH] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems Ashish, Agreed - #2 would be better in the long run

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems

2019-02-28 Thread Ashish Singhal
ULL ); if (EFI_ERROR (Status)) { DEBUG ((DEBUG_WARN, "SdMmcPciHcDriverBindingStart: failed to enable 64-bit DMA (%r)\n", Status)); } } Thanks Ashish From: Cohen, Eugene Sent: Thursday, February 28, 2019 12:56 PM To: Ashish Singhal ; Wu, Hao A ; edk

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems

2019-02-28 Thread Ashish Singhal
. This will take maybe a day or two and can be done. Thanks Ashish From: Cohen, Eugene Sent: Thursday, February 28, 2019 3:40 PM To: Ashish Singhal ; Wu, Hao A ; edk2-devel@lists.01.org; Ard Biesheuvel Subject: RE: [PATCH] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems Ashish, I

[edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Add V3 64b DMA Support

2019-03-01 Thread Ashish Singhal
-by: Ashish Singhal --- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 10 +- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 6 +- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 199 ++--- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h | 29 ++- 4 files changed

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems

2019-03-01 Thread Ashish Singhal
Eugene, I have submitted a patch for supporting 64b DMA on V3 controllers. Can you please validate it at your end as well? Thanks Ashish From: Ashish Singhal Sent: Friday, March 1, 2019 5:31 AM To: Ard Biesheuvel ; Cohen, Eugene Cc: Wu, Hao A ; edk2-devel@lists.01.org; Kim, Sangwoo (김상우

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Add V3 64b DMA Support

2019-03-03 Thread Ashish Singhal
Liming, I am OK waiting till the freeze is over. Thanks Ashish -Original Message- From: Gao, Liming Sent: Saturday, March 2, 2019 9:01 AM To: Ashish Singhal ; edk2-devel@lists.01.org Cc: Wu, Hao A Subject: RE: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Add V3 64b DMA Support Ashish

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems

2019-03-03 Thread Ashish Singhal
sense. Eugene, Please let me know once you have tried my patch on your board. Thanks Ashish -Original Message- From: Wu, Hao A Sent: Sunday, March 3, 2019 7:39 PM To: Cohen, Eugene ; Ashish Singhal ; Ard Biesheuvel Cc: edk2-devel@lists.01.org; Kim, Sangwoo (??? SW1Lab.) Subject: RE

[edk2] [PATCH 0/2] DynamicTablesPkg Updates

2019-02-21 Thread Ashish Singhal
been verified to work on hardware. Ashish Singhal (2): DynamicTablesPkg/DynamicTableManagerDxe: Update DEPEX DynamicTablesPkg/AcpiSpcrLibArm: Support 16550 UART. .../Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf | 4 +++- DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm

[edk2] [PATCH 2/2] DynamicTablesPkg/AcpiSpcrLibArm: Support 16550 UART.

2019-02-21 Thread Ashish Singhal
Add support for 16550 UART to ACPI SPCR table as it is a supported UART type by HLOS. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ashish Singhal --- DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[edk2] [PATCH 1/2] DynamicTablesPkg/DynamicTableManagerDxe: Update DEPEX

2019-02-21 Thread Ashish Singhal
DynamicTableManagerDxe initialization fails if gEdkiiDynamicTableFactoryProtocolGuid, gEdkiiConfigurationManagerProtocolGuid and gEfiAcpiTableProtocolGuid are not already available. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ashish Singhal --- .../Drivers

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Add V3 64b DMA Support

2019-03-05 Thread Ashish Singhal
Hi Hao, That is right. Also, I have addressed your comments and have submitted v2 patch. Thanks Ashish -Original Message- From: Wu, Hao A Sent: Tuesday, March 5, 2019 8:01 PM To: Ashish Singhal ; edk2-devel@lists.01.org Cc: eug...@hp.com Subject: RE: [PATCH] MdeModulePkg/SdMmcPciHcDxe

[edk2] [PATCH v2] MdeModulePkg/SdMmcPciHcDxe: Add V3 64b DMA Support

2019-03-06 Thread Ashish Singhal
-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ashish Singhal --- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 10 +- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 6 +- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 189 ++--- MdeModulePkg/Bus/Pci

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Add V3 64b DMA Support

2019-03-06 Thread Ashish Singhal
Hi Eugene, Thanks for confirming. Can you please validate the v2 patch I sent as well for completeness? Thanks Ashish From: Cohen, Eugene Sent: Wednesday, March 6, 2019 4:05 PM To: Wu, Hao A ; Ashish Singhal ; edk2-devel@lists.01.org Subject: RE: [PATCH] MdeModulePkg/SdMmcPciHcDxe: Add V3

Re: [edk2] [PATCH v2 0/1] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems

2019-03-05 Thread Ashish Singhal
Ok with me. Get Outlook for iOS<https://aka.ms/o0ukef> From: Ard Biesheuvel Sent: Tuesday, March 5, 2019 6:39 AM To: Wu, Hao A Cc: edk2-devel@lists.01.org; Eugene Cohen; Ashish Singhal Subject: Re: [PATCH v2 0/1] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on S

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems

2019-03-01 Thread Ashish Singhal
I've already started refactoring the driver to support V3 64b ADMA2. Meanwhile, I'm OK with the proposed patch. Thanks Ashish Get Outlook for iOS<https://aka.ms/o0ukef> From: Ard Biesheuvel Sent: Friday, March 1, 2019 4:40 AM To: Cohen, Eugene Cc:

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems

2019-03-01 Thread Ashish Singhal
Acked-by: Ashish Singhal -Original Message- From: Ard Biesheuvel Sent: Friday, March 1, 2019 4:39 AM To: Cohen, Eugene Cc: Ashish Singhal ; Wu, Hao A ; edk2-devel@lists.01.org; Kim, Sangwoo (김상우 SW1Lab.) Subject: Re: [PATCH] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit