[edk2] BaseTools build number after transition to git

Most of the EDKII tools support --version switch that returns tool version and build number. We've been using SVN revision ID as a build number for all the tools. Have there been any discussions on what should be used as a build number in the new (and hopefully merrier) EDKII Git world? Felix

Re: [edk2] BaseTools build number after transition to git

plus commit date/time. Something similar to the output of the following command: git show -s --format="%H %ci" -Original Message- From: Bjorge, Erik C [mailto:erik.c.bjo...@intel.com] Sent: Friday, February 12, 2016 6:41 PM To: Felix Poludov; edk2-devel@lists.01.org Subject: RE:

[edk2] Is EsrtDxe broken?

EsrtDxe publishes EsrtManagement protocol. It has (among others) SyncEsrtFmp() and LockEsrtRepository() functions. Here is the description of the functions from the protocol header file: SyncEsrtFmp(): This function syn up Cached ESRT with data from FMP instances Function should be called

Re: [edk2] [PATCH] MdePkg/BaseLib: do not rely on undefined behavior in arithmetic shift

Here is another case of shifting a negative value: It's CoreRestoreTpl (MdeModulePkg\Core\Dxe\Event\Tpl.c): while (((-2 << NewTpl) & gEventPending) != 0) { } -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Gao, Liming Sent: Thursday,

Re: [edk2] inconsistency between the UNI spec and the Build tool

No, STR_Xyz or str_x triggers the same error. -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Kinney, Michael D Sent: Tuesday, July 26, 2016 7:04 PM To: Felix Poludov; edk2-devel@lists.01.org; Kinney, Michael D Subject: Re: [edk2] inconsistency

[edk2] [PATCH] [MdePkg ] New Debug Message Levels

Dear MdePkg maintainer, DebugLib.h defines debug message levels. Some values such as DEBUG_ERROR and DEBUG_INFO define messages category, whereas other values such as DEBUG_BLKIO and DEBUG_VARIABLE define message domain. This patch adds definitions for several additional message domains.

Re: [edk2] [PATCH] [MdePkg ] New Debug Message Levels

Resending with the patch (the patch was missing in the original e-mail). -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Felix Poludov Sent: Wednesday, September 14, 2016 12:05 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH] [MdePkg ] New

Re: [edk2] SMM PciExpressLib Instance

Resending with the patch (the patch was missing in the original e-mail). -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Felix Poludov Sent: Wednesday, September 14, 2016 3:22 PM To: edk2-devel@lists.01.org Subject: [edk2] SMM PciExpressLib

Re: [edk2] SMM PciExpressLib Instance

Mike, I updated the library to be based on DxeRuntimePciExpressLib. Here is the new patch. Thanks, Felix Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Felix Polyudov > == diff --git a/MdePkg/Library/SmmPciExpressLib/PciExpressLib.c

Re: [edk2] [PATCH] [MdePkg ] New Debug Message Levels

hael.d.kin...@intel.com] Sent: Wednesday, September 21, 2016 2:10 AM To: Felix Poludov; Gao, Liming; edk2-devel@lists.01.org Subject: RE: [PATCH] [MdePkg ] New Debug Message Levels Felix, Thanks for the quick update. Quick question on usage model. Do you expect to be able to mix an I/O subsystem bit

Re: [edk2] [PATCH] [MdePkg ] New Debug Message Levels

\n" "BIT20 - Global Coherency Database changes message.\n" "BIT21 - Memory range cacheability changes message.\n&q

[edk2] [RFC] [MdePkg] UefiLib: CreatePopUp

UefiLib library class (MdePkg ) includes CreatePopUp function. The function displays a message box. There is certainly more than one way to draw a message box. If homogenous user interface is a project requirement, CreatePopUp is likely to be overridden to align message box appearance with the

Re: [edk2] [RFC] [MdePkg] UefiLib: CreatePopUp

etworkPkg\IScsiDxe\IScsiConfig.c(2404):CreatePopUp ( C:\home\Edk-II\NetworkPkg\IScsiDxe\IScsiConfig.c(2421): CreatePopUp ( C:\home\Edk-II\NetworkPkg\IScsiDxe\IScsiConfig.c(2444):CreatePopUp ( From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dong, Eric

[edk2] [PATCH 1/2] MdePkg: UiLib library. Add UiLib. Update UefiLib.

1. New UiLib library class is added to MdePkg. The library is intended for functions that produce UI elements. The patch introduces two functions that produce a popup window: UiCreatePopUp and UiCreatePopUpVaList. 2. An instance of UiLib library class is added to MdePkg. Popup implementation is

[edk2] [PATCH 0/2] MdePkg: UiLib library

This series of two patches introduces new UiLib library. 1. New UiLib library class is added to MdePkg. The library is intended for functions that produce UI elements. The patch introduces two functions that produce a popup window: UiCreatePopUp and UiCreatePopUpVaList. 2. An instance of UiLib

[edk2] [PATCH 2/2] MdePkg: UiLib library. Update DSC files.

Platform DSC files are updated to add UiLib instance Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Felix Polyudov --- AppPkg/AppPkg.dsc | 1 + ArmPkg/ArmPkg.dsc | 1 +

Re: [edk2] [PATCH 0/2] MdePkg: UiLib library

many other libraries in the MdePkg. What do you think? Thanks Felix From: Yao, Jiewen [mailto:jiewen@intel.com] Sent: Wednesday, November 09, 2016 8:54 PM To: Felix Poludov; edk2-devel@lists.01.org Subject: RE: [PATCH 0/2] MdePkg: UiLib library HI Poludov It is a good idea to have a new UiL

Re: [edk2] [PATCH 0/2] MdePkg: UiLib library

To: Felix Poludov; Yao, Jiewen; edk2-devel@lists.01.org Subject: RE: [PATCH 0/2] MdePkg: UiLib library Felix: I think two major concerns are here. 1) UefiLib depends on UiLib 2) UiLib class is defined in MdePkg. To resolve it, I have another idea. 1) Introduce new API

Re: [edk2] [PATCH 0/2] MdePkg: UiLib library

by Liming with all the CreatePopup consumers. -Original Message- From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Thursday, November 10, 2016 11:05 AM To: Felix Poludov; Gao, Liming; Yao, Jiewen; edk2-devel@lists.01.org; Kinney, Michael D Subject: RE: [PATCH 0/2] MdePkg

Re: [edk2] [RFC] [MdePkg] UefiLib: CreatePopUp

...@lists.01.org] On Behalf Of Dong, Eric Sent: Monday, October 31, 2016 4:26 AM To: Felix Poludov; edk2-devel@lists.01.org Cc: Bi, Dandan; Gao, Liming Subject: Re: [edk2] [RFC] [MdePkg] UefiLib: CreatePopUp Hi Felix, Add my comments below. > -Original Message- > From: Felix P

Re: [edk2] [RFC] [MdePkg] UefiLib: CreatePopUp

...@intel.com] Sent: Thursday, October 27, 2016 10:36 PM To: Felix Poludov; edk2-devel@lists.01.org Cc: Gao, Liming; Bi, Dandan Subject: RE: [RFC] [MdePkg] UefiLib: CreatePopUp Hi Felix, Do you want to provide a new solution for CreatePopup or just want to split CreatePopup from UefiLib? We already

Re: [edk2] [RFC] [MdePkg] UefiLib: CreatePopUp

Eric, See my comments below -Original Message- From: Dong, Eric [mailto:eric.d...@intel.com] Sent: Tuesday, November 01, 2016 2:55 AM To: Felix Poludov; edk2-devel@lists.01.org Cc: Bi, Dandan; Gao, Liming Subject: RE: [RFC] [MdePkg] UefiLib: CreatePopUp Felix, Add my comments below

Re: [edk2] [RFC] [MdePkg] UefiLib: CreatePopUp

in MdePkg/Library/UefiLib/Console.c. Thanks Felix -Original Message- From: Dong, Eric [mailto:eric.d...@intel.com] Sent: Thursday, November 03, 2016 3:33 AM To: Felix Poludov; edk2-devel@lists.01.org Cc: Bi, Dandan; Gao, Liming Subject: RE: [RFC] [MdePkg] UefiLib: CreatePopUp Hi Felix

[edk2] [RFC] GLOBAL_REMOVE_IF_UNREFERENCED, multiply defined symbols, and MSFT/GCC tool chains.

Trying to add GCC support to projects based on MSFT tool chain, I'm keep stumbling into multiply defined symbol errors reported by GCC linker. An attempt to understand why the errors are not reported by the Microsoft linker lead me to GLOBAL_REMOVE_IF_UNREFERENCED macro. The purpose of the macro

Re: [edk2] [RFC] GLOBAL_REMOVE_IF_UNREFERENCED, multiply defined symbols, and MSFT/GCC tool chains.

> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Friday, March 24, 2017 1:32 PM > To: Felix Poludov > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [RFC] GLOBAL_REMOVE_IF_UNREFERENCED, multiply > defined symbols, and

Re: [edk2] [RFC] GLOBAL_REMOVE_IF_UNREFERENCED, multiply defined symbols, and MSFT/GCC tool chains.

depending on the compiler used. -Original Message- From: Gao, Liming [mailto:liming@intel.com] Sent: Monday, March 27, 2017 12:49 AM To: Felix Poludov; edk2-devel@lists.01.org Cc: Gao, Liming Subject: RE: [RFC] GLOBAL_REMOVE_IF_UNREFERENCED, multiply defined symbols, and MSFT/GCC

Re: [edk2] [RFC] GLOBAL_REMOVE_IF_UNREFERENCED, multiply defined symbols, and MSFT/GCC tool chains.

, Michael D [mailto:michael.d.kin...@intel.com] Sent: Monday, March 27, 2017 12:07 PM To: Felix Poludov; Gao, Liming; edk2-devel@lists.01.org; Kinney, Michael D Subject: RE: [RFC] GLOBAL_REMOVE_IF_UNREFERENCED, multiply defined symbols, and MSFT/GCC tool chains. Felix, What is the condition

Re: [edk2] [RFC] GLOBAL_REMOVE_IF_UNREFERENCED, multiply defined symbols, and MSFT/GCC tool chains.

with GLOBAL_REMOVE_IF_UNREFERENCED are not subject to the default policy of breaking the build if multiple defined symbols are detected when MSFT tool chain is used. -Original Message- From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Monday, March 27, 2017 11:35 AM To: Felix Poludov; Gao, Liming

Re: [edk2] [edk2-staging/edk2-test Patch V2 0/2] TestFrameworkPkg/TestProfile: Fix overlapping buffer ASSERT()

The patch looks fine. Reviewed-by: Felix Polyudov <fel...@ami.com> -Original Message- From: Michael D Kinney [mailto:michael.d.kin...@intel.com] Sent: Monday, August 14, 2017 11:57 PM To: edk2-devel@lists.01.org Cc: Andrew Fish; Michael Kinney; Felix Poludov Subject: [edk2-stagin

[edk2] [staging/edk2-test] [PATCH] TestProfile bug fix

The attached patch is a bug fix for TestFrameworkPkg/Support/TestProfile driver. AsciiStrCpy function was used to copy overlapping strings, which triggered an ASSERT. The function was used on overlapping strings in a couple of places: 1. _alltrim: AsciiStrCpy is replaced with CopyMem, which can

[edk2] [PATCH] MdePkg: Add PcdPciExpressRegionLength PCD Token

Add PcdPciExpressRegionLength PCD Token to MdePkg. The new token can be used in conjunction with PcdPciExpressBaseAddress PCD token to describe PCI Express MMIO region. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Felix Polyudov --- Resending with

[edk2] [PATCH] staging/edk2-test: TestProfile bug fix

The patch is a bug fix for TestFrameworkPkg/Support/TestProfile driver. AsciiStrCpy function was used to copy overlapping strings, which triggered an ASSERT. The function was used on overlapping strings in a couple of places: 1. _alltrim: AsciiStrCpy is replaced with CopyMem, which can handle

Re: [edk2] [PATCH] MdePkg: Add PcdPciExpressRegionLength PCD Token

and PcdPciExpressRegionLength are names used in different platform packages. -Original Message- From: Marvin H?user [mailto:marvin.haeu...@outlook.com] Sent: Wednesday, August 02, 2017 9:57 AM To: edk2-devel@lists.01.org Cc: Felix Poludov; michael.d.kin...@intel.com; Gao, Liming Subject: RE: [PATCH] MdePkg: Add

Re: [edk2] [PATCH] staging/edk2-test: TestProfile bug fix

uence file is parsed. -Original Message- From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Wednesday, August 02, 2017 1:37 PM To: Felix Poludov; edk2-devel@lists.01.org; Kinney, Michael D Subject: RE: [PATCH] staging/edk2-test: TestProfile bug fix Hi Felix, Thanks for the contri

Re: [edk2] [Patch] SourceLevelDebugPkg/SecPeiDebugAgentLib: Fix duplicate symbol

vel@lists.01.org; Fan, Jeff; Felix Poludov; Ard Biesheuvel Subject: RE: [edk2] [Patch] SourceLevelDebugPkg/SecPeiDebugAgentLib: Fix duplicate symbol Mike: Yes. /Gw option is added since VS2013. The older VS version can't use this option. I suggest we always define GLOBAL_REMOVE_IF_UNREFEREN

Re: [edk2] edk2 interface deprecation policy

...@apple.com [mailto:af...@apple.com] Sent: Thursday, November 30, 2017 11:57 AM To: Felix Poludov Cc: edk2-devel@lists.01.org Subject: Re: [edk2] edk2 interface deprecation policy Felix, I don't think we have one Adding new interfaces does not impact the downstream projects, but depreciating

[edk2] edk2 interface deprecation policy

Does edk2 have a policy regarding deprecation of interface definition headers? I can see that definition of the UgaDraw protocol that was deprecated years ago (I believe in UEFI 2.0) is still part of the code base; yet, definition of the SMM Communication ACPI Table that was deprecated this year