Re: [edk2] [PATCH] BaseTools/VolInfo: Fix printf issue using '%ls' in format string

2016-12-01 Thread Wu, Hao A
Got it. I will move those 2 implementation before main() before code check-in. Best Regards, Hao Wu > -Original Message- > From: Gao, Liming > Sent: Friday, December 02, 2016 10:56 AM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Zhu, Yonghong > Subject: RE: [PATCH] BaseTools/VolInfo:

Re: [edk2] [PATCH] BaseTools/VolInfo: Fix printf issue using '%ls' in format string

2016-12-01 Thread Gao, Liming
Hao: Place move UnicodeStrLen() and Unicode2AsciiString() implementation before main() function. If so, they are not required to be declared again. Other changes are good. Reviewed-by: Liming Gao Thanks Liming -Original Message- From: Wu, Hao A Sent:

[edk2] [PATCH] BaseTools/VolInfo: Fix printf issue using '%ls' in format string

2016-12-01 Thread Hao Wu
https://bugzilla.tianocore.org/show_bug.cgi?id=257 For GCC compilers, when building with option '-fshort-wchar', wide char string format '%ls' does not work properly for printf() function. The string specified by '%ls' will not be printed. This commit avoids using '%ls' for printf() function and