Re: [edk2] [PATCH] UefiCpuPkg: Enhance CPU feature dependency check

2018-02-01 Thread Song, BinX
Hi Laszlo, Thanks for your reply, I have also discussed this patch with Eric and Ray, all comments will be in the V2 patch. Best Regards, Bell Song > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, February 1, 2018 9:16 PM > To: Song, BinX

Re: [edk2] [PATCH] UefiCpuPkg: Enhance CPU feature dependency check

2018-02-01 Thread Laszlo Ersek
On 02/01/18 06:10, Ni, Ruiyu wrote: > On 1/31/2018 5:44 PM, Laszlo Ersek wrote: >> On 01/31/18 08:00, Song, BinX wrote: >>> Current CPU feature dependency check will hang on when meet below or >>> similar case: >>> if (IsCpuFeatureSupported (CPU_FEATURE_AESNI)) { >>>    Status = RegisterCpuFeature

Re: [edk2] [PATCH] UefiCpuPkg: Enhance CPU feature dependency check

2018-02-01 Thread Laszlo Ersek
On 02/01/18 03:09, Song, BinX wrote: > Hi Laszlo, > > Thanks for your comments. > Explain the issue first: > In CpuCommonFeaturesLib.inf -> CpuCommonFeaturesLib.c -> > CpuCommonFeaturesLibConstructor() function, > it invokes RegisterCpuFeature() to register CPU feature. Some original source >

Re: [edk2] [PATCH] UefiCpuPkg: Enhance CPU feature dependency check

2018-01-31 Thread Ni, Ruiyu
On 1/31/2018 5:44 PM, Laszlo Ersek wrote: On 01/31/18 08:00, Song, BinX wrote: Current CPU feature dependency check will hang on when meet below or similar case: if (IsCpuFeatureSupported (CPU_FEATURE_AESNI)) { Status = RegisterCpuFeature ( "AESNI",

Re: [edk2] [PATCH] UefiCpuPkg: Enhance CPU feature dependency check

2018-01-31 Thread Song, BinX
Hi Laszlo, Thanks for your comments. Explain the issue first: In CpuCommonFeaturesLib.inf -> CpuCommonFeaturesLib.c -> CpuCommonFeaturesLibConstructor() function, it invokes RegisterCpuFeature() to register CPU feature. Some original source codes is here. if (IsCpuFeatureSupported

Re: [edk2] [PATCH] UefiCpuPkg: Enhance CPU feature dependency check

2018-01-31 Thread Laszlo Ersek
On 01/31/18 08:00, Song, BinX wrote: > Current CPU feature dependency check will hang on when meet below or > similar case: > if (IsCpuFeatureSupported (CPU_FEATURE_AESNI)) { > Status = RegisterCpuFeature ( > "AESNI", > AesniGetConfigData, > AesniSupport, >

Re: [edk2] [PATCH] UefiCpuPkg: Enhance CPU feature dependency check

2018-01-30 Thread Song, BinX
Dong, Eric <eric.d...@intel.com> > Subject: [edk2] [PATCH] UefiCpuPkg: Enhance CPU feature dependency > check > > Current CPU feature dependency check will hang on when meet below or > similar case: > if (IsCpuFeatureSupported (CPU_FEATURE_AESNI)) { > Status

[edk2] [PATCH] UefiCpuPkg: Enhance CPU feature dependency check

2018-01-30 Thread Song, BinX
Current CPU feature dependency check will hang on when meet below or similar case: if (IsCpuFeatureSupported (CPU_FEATURE_AESNI)) { Status = RegisterCpuFeature ( "AESNI", AesniGetConfigData, AesniSupport, AesniInitialize,