Re: [edk2] [PATCH v4 edk2-platforms 00/23] Platform/Raspberry: Add Raspberry Pi 3 support

2019-01-31 Thread Pete Batard
On 2019.01.30 21:59, Leif Lindholm wrote: Hi Pete, I have two annoying pieces of feedback that apply to the whole set. Firstly, I would really appreciate if we could have some sort of commit messages rather than just subject lines. I can work on that. So, for ACPI, mention the provenance

Re: [edk2] [PATCH v4 edk2-platforms 00/23] Platform/Raspberry: Add Raspberry Pi 3 support

2019-01-30 Thread Leif Lindholm
On Wed, Jan 30, 2019 at 09:59:34PM +, Leif Lindholm wrote: > Hi Pete, > > I have two annoying pieces of feedback that apply to the whole set. > > Firstly, I would really appreciate if we could have some sort of > commit messages rather than just subject lines. > So, for ACPI, mention the

Re: [edk2] [PATCH v4 edk2-platforms 00/23] Platform/Raspberry: Add Raspberry Pi 3 support

2019-01-30 Thread Leif Lindholm
Hi Pete, I have two annoying pieces of feedback that apply to the whole set. Firstly, I would really appreciate if we could have some sort of commit messages rather than just subject lines. So, for ACPI, mention the provenance and limitations. For SMBIOS, version supported and any relevant

Re: [edk2] [PATCH v4 edk2-platforms 00/23] Platform/Raspberry: Add Raspberry Pi 3 support

2019-01-30 Thread Ard Biesheuvel
On Wed, 30 Jan 2019 at 20:42, Leif Lindholm wrote: > > On Wed, Jan 30, 2019 at 08:38:19PM +0100, Ard Biesheuvel wrote: > > On Tue, 29 Jan 2019 at 22:10, Pete Batard wrote: > > > > > > On 2019.01.29 17:40, Ard Biesheuvel wrote: > > > > I managed to build and run a RELEASE image, and I must say,

Re: [edk2] [PATCH v4 edk2-platforms 00/23] Platform/Raspberry: Add Raspberry Pi 3 support

2019-01-30 Thread Leif Lindholm
On Wed, Jan 30, 2019 at 08:38:19PM +0100, Ard Biesheuvel wrote: > On Tue, 29 Jan 2019 at 22:10, Pete Batard wrote: > > > > On 2019.01.29 17:40, Ard Biesheuvel wrote: > > > I managed to build and run a RELEASE image, and I must say, I'm > > > impressed. It works really well, and looks really slick

Re: [edk2] [PATCH v4 edk2-platforms 00/23] Platform/Raspberry: Add Raspberry Pi 3 support

2019-01-30 Thread Ard Biesheuvel
On Tue, 29 Jan 2019 at 22:10, Pete Batard wrote: > > On 2019.01.29 17:40, Ard Biesheuvel wrote: > > I managed to build and run a RELEASE image, and I must say, I'm > > impressed. It works really well, and looks really slick too. Thanks a > > lot for taking the time to upstream this, it makes the

Re: [edk2] [PATCH v4 edk2-platforms 00/23] Platform/Raspberry: Add Raspberry Pi 3 support

2019-01-29 Thread Pete Batard
On 2019.01.29 17:40, Ard Biesheuvel wrote: I managed to build and run a RELEASE image, and I must say, I'm impressed. It works really well, and looks really slick too. Thanks a lot for taking the time to upstream this, it makes the RPI3 a lot more usable for people that want to run a generic

Re: [edk2] [PATCH v4 edk2-platforms 00/23] Platform/Raspberry: Add Raspberry Pi 3 support

2019-01-29 Thread Ard Biesheuvel
Hi Pete, On Tue, 29 Jan 2019 at 17:27, Pete Batard wrote: > > Changes applied to v4: > > * Silicon/Broadcom/Include has been moved to Silicon/Broadcom/Bcm283x/Include. > The [Packages] and [Includes] directives were also updated accordingly. > * Move the GpioLib function declarations into

[edk2] [PATCH v4 edk2-platforms 00/23] Platform/Raspberry: Add Raspberry Pi 3 support

2019-01-29 Thread Pete Batard
Changes applied to v4: * Silicon/Broadcom/Include has been moved to Silicon/Broadcom/Bcm283x/Include. The [Packages] and [Includes] directives were also updated accordingly. * Move the GpioLib function declarations into their own separate header. * Add NOOPT to BUILD_TARGETS. * Remove the no