Re: [edk2] [platforms: PATCH v2 06/12] Marvell/Drivers: MvBoardDesc: Extend protocol with GPIO support

2019-01-15 Thread Marcin Wojtas
wt., 15 sty 2019 o 11:12 Leif Lindholm napisał(a): > > On Tue, Jan 15, 2019 at 11:05:12AM +0100, Marcin Wojtas wrote: > > > > Anyway, I tried to play with the MV_BOARD_GPIO_DESCRIPTION to be the > > > > global variable, but was not convinced by the outcome. My biggest > > > > objection to the glob

Re: [edk2] [platforms: PATCH v2 06/12] Marvell/Drivers: MvBoardDesc: Extend protocol with GPIO support

2019-01-15 Thread Leif Lindholm
On Tue, Jan 15, 2019 at 11:14:16AM +0100, Marcin Wojtas wrote: > wt., 15 sty 2019 o 11:12 Leif Lindholm napisał(a): > > > > On Tue, Jan 15, 2019 at 11:05:12AM +0100, Marcin Wojtas wrote: > > > > > Anyway, I tried to play with the MV_BOARD_GPIO_DESCRIPTION to be the > > > > > global variable, but w

Re: [edk2] [platforms: PATCH v2 06/12] Marvell/Drivers: MvBoardDesc: Extend protocol with GPIO support

2019-01-15 Thread Leif Lindholm
On Tue, Jan 15, 2019 at 11:05:12AM +0100, Marcin Wojtas wrote: > > > Anyway, I tried to play with the MV_BOARD_GPIO_DESCRIPTION to be the > > > global variable, but was not convinced by the outcome. My biggest > > > objection to the global variable and checking whether it's NULL in the > > > consum

Re: [edk2] [platforms: PATCH v2 06/12] Marvell/Drivers: MvBoardDesc: Extend protocol with GPIO support

2019-01-15 Thread Marcin Wojtas
wt., 15 sty 2019 o 10:56 Leif Lindholm napisał(a): > > On Tue, Jan 15, 2019 at 07:05:42AM +0100, Marcin Wojtas wrote: > > > > index f71bfc4..e348b85 100644 > > > > --- a/Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.c > > > > +++ b/Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.c > > > > @@ -

Re: [edk2] [platforms: PATCH v2 06/12] Marvell/Drivers: MvBoardDesc: Extend protocol with GPIO support

2019-01-15 Thread Leif Lindholm
On Tue, Jan 15, 2019 at 07:05:42AM +0100, Marcin Wojtas wrote: > > > index f71bfc4..e348b85 100644 > > > --- a/Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.c > > > +++ b/Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.c > > > @@ -100,6 +100,48 @@ MvBoardDescComPhyGet ( > > > > > > STATIC > >

Re: [edk2] [platforms: PATCH v2 06/12] Marvell/Drivers: MvBoardDesc: Extend protocol with GPIO support

2019-01-14 Thread Marcin Wojtas
Hi Leif, pon., 14 sty 2019 o 23:58 Leif Lindholm napisał(a): > > On Thu, Jan 10, 2019 at 02:44:33AM +0100, Marcin Wojtas wrote: > > Introduce new callback that can provide information > > about GPIO SoC controllers, as well as on-board > > I2C IO expanders. According ArmadaSoCDescLib > > ArmadaBo

Re: [edk2] [platforms: PATCH v2 06/12] Marvell/Drivers: MvBoardDesc: Extend protocol with GPIO support

2019-01-14 Thread Leif Lindholm
On Thu, Jan 10, 2019 at 02:44:33AM +0100, Marcin Wojtas wrote: > Introduce new callback that can provide information > about GPIO SoC controllers, as well as on-board > I2C IO expanders. According ArmadaSoCDescLib > ArmadaBoardDescLib routines are used for > obtaining required data. > > Contribute

[edk2] [platforms: PATCH v2 06/12] Marvell/Drivers: MvBoardDesc: Extend protocol with GPIO support

2019-01-09 Thread Marcin Wojtas
Introduce new callback that can provide information about GPIO SoC controllers, as well as on-board I2C IO expanders. According ArmadaSoCDescLib ArmadaBoardDescLib routines are used for obtaining required data. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas -