Re: [edk2] [PATCH 02/10] StandaloneMmPkg: drop unused PCD PcdStandaloneMmEnable

2019-03-07 Thread Achin Gupta
On Thu, Mar 07, 2019 at 11:09:35AM +0100, Ard Biesheuvel wrote: > On Wed, 6 Mar 2019 at 16:37, Achin Gupta wrote: > > > > On Wed, Mar 06, 2019 at 04:17:51PM +0100, Ard Biesheuvel wrote: > > > On Wed, 6 Mar 2019 at 16:16, Achin Gupta wrote: > > > > > > > > Hi Ard, > > > > > > > > On Tue, Mar 05,

Re: [edk2] [PATCH 02/10] StandaloneMmPkg: drop unused PCD PcdStandaloneMmEnable

2019-03-07 Thread Ard Biesheuvel
On Wed, 6 Mar 2019 at 16:37, Achin Gupta wrote: > > On Wed, Mar 06, 2019 at 04:17:51PM +0100, Ard Biesheuvel wrote: > > On Wed, 6 Mar 2019 at 16:16, Achin Gupta wrote: > > > > > > Hi Ard, > > > > > > On Tue, Mar 05, 2019 at 02:32:40PM +0100, Ard Biesheuvel wrote: > > > > The PCD

Re: [edk2] [PATCH 02/10] StandaloneMmPkg: drop unused PCD PcdStandaloneMmEnable

2019-03-06 Thread Achin Gupta
On Wed, Mar 06, 2019 at 04:17:51PM +0100, Ard Biesheuvel wrote: > On Wed, 6 Mar 2019 at 16:16, Achin Gupta wrote: > > > > Hi Ard, > > > > On Tue, Mar 05, 2019 at 02:32:40PM +0100, Ard Biesheuvel wrote: > > > The PCD PcdStandaloneMmEnable is unused, and shouldn't exist in the > > > first place

Re: [edk2] [PATCH 02/10] StandaloneMmPkg: drop unused PCD PcdStandaloneMmEnable

2019-03-06 Thread Ard Biesheuvel
On Wed, 6 Mar 2019 at 16:16, Achin Gupta wrote: > > Hi Ard, > > On Tue, Mar 05, 2019 at 02:32:40PM +0100, Ard Biesheuvel wrote: > > The PCD PcdStandaloneMmEnable is unused, and shouldn't exist in the > > first place since the value is implied by the context (it is never > > valid to set it to

Re: [edk2] [PATCH 02/10] StandaloneMmPkg: drop unused PCD PcdStandaloneMmEnable

2019-03-06 Thread Achin Gupta
Hi Ard, On Tue, Mar 05, 2019 at 02:32:40PM +0100, Ard Biesheuvel wrote: > The PCD PcdStandaloneMmEnable is unused, and shouldn't exist in the > first place since the value is implied by the context (it is never > valid to set it to FALSE for standalone MM or TRUE for traditional > MM). So drop

Re: [edk2] [PATCH 02/10] StandaloneMmPkg: drop unused PCD PcdStandaloneMmEnable

2019-03-05 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ard Biesheuvel > Sent: Tuesday, March 5, 2019 5:33 AM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen > Subject: [edk2] [PATCH 02/10] StandaloneMmPkg: drop