Re: [edk2] [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default

2018-04-16 Thread Guo Heyi
On Mon, Apr 16, 2018 at 01:33:56PM +0100, Leif Lindholm wrote: > On Mon, Apr 02, 2018 at 10:51:53AM +0800, Guo Heyi wrote: > > Hi Ray and Leif, > > > > Any comments? > > > > > > On Mon, Mar 26, 2018 at 05:03:10PM +0800, Guo Heyi wrote: > > > Thanks Ray. > > > > > > Does that mean we need build

Re: [edk2] [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default

2018-04-16 Thread Leif Lindholm
On Mon, Apr 02, 2018 at 10:51:53AM +0800, Guo Heyi wrote: > Hi Ray and Leif, > > Any comments? > > > On Mon, Mar 26, 2018 at 05:03:10PM +0800, Guo Heyi wrote: > > Thanks Ray. > > > > Does that mean we need build the dynamic command driver separately and > > store it > > in other media instead

Re: [edk2] [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default

2018-04-01 Thread Guo Heyi
Hi Ray and Leif, Any comments? On Mon, Mar 26, 2018 at 05:03:10PM +0800, Guo Heyi wrote: > Thanks Ray. > > Does that mean we need build the dynamic command driver separately and store > it > in other media instead of UEFI fd image? Right now if I include the driver > into > the fd image, it w

Re: [edk2] [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default

2018-03-26 Thread Guo Heyi
Thanks Ray. Does that mean we need build the dynamic command driver separately and store it in other media instead of UEFI fd image? Right now if I include the driver into the fd image, it will be automatically added to EFI Shell command list; we don't need to run the load command. Hi Leif, Is t

Re: [edk2] [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default

2018-03-22 Thread Ni, Ruiyu
On 3/20/2018 8:15 PM, Guo Heyi wrote: I've no idea about how to use Driver; let me spend some time to learn first :) Heyi, you could use "load xxxDriver.efi" to load the dynamic command in shell. After that, you can run "tftp" in shell just as running an internal command. Regards, Heyi

Re: [edk2] [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default

2018-03-20 Thread Guo Heyi
I've no idea about how to use Driver; let me spend some time to learn first :) Regards, Heyi On Tue, Mar 20, 2018 at 09:51:32AM +, Leif Lindholm wrote: > Ah, apologies. > > I would be reluctant to add commands not covered by the UEFI Shell > Specification by default. > > Since it is no

Re: [edk2] [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default

2018-03-20 Thread Leif Lindholm
Ah, apologies. I would be reluctant to add commands not covered by the UEFI Shell Specification by default. Since it is now a dynamic command, is there any way of loading this dynamically (perhaps via DRIVER) where you feel the need for it? / Leif On Tue, Mar 20, 2018 at 03:54:46PM +080

Re: [edk2] [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default

2018-03-20 Thread Guo Heyi
Ping :) On Wed, Mar 07, 2018 at 04:02:30PM +, Ard Biesheuvel wrote: > On 7 March 2018 at 03:03, Heyi Guo wrote: > > Since D0x platforms always have network enabled, we would like to > > enable tftp command by default so that we can download something in > > EFI Shell. > > > > Contributed-und

Re: [edk2] [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default

2018-03-07 Thread Ard Biesheuvel
On 7 March 2018 at 03:03, Heyi Guo wrote: > Since D0x platforms always have network enabled, we would like to > enable tftp command by default so that we can download something in > EFI Shell. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Heyi Guo > Cc: Ard Biesheuv