Re: [edk2] [PATCH edk2-platforms v2 2/7] Platform/NinetySixBoards: introduce package and mezzanine protocol

2018-02-22 Thread Ard Biesheuvel
On 22 February 2018 at 13:44, Leif Lindholm wrote: > On Thu, Feb 22, 2018 at 01:21:37PM +, Ard Biesheuvel wrote: >> On 22 February 2018 at 13:15, Leif Lindholm wrote: >> > On Tue, Feb 20, 2018 at 05:49:39PM +, Ard Biesheuvel wrote: >> >> Introduce the mezzanine protocol and the 96boards p

Re: [edk2] [PATCH edk2-platforms v2 2/7] Platform/NinetySixBoards: introduce package and mezzanine protocol

2018-02-22 Thread Leif Lindholm
On Thu, Feb 22, 2018 at 01:21:37PM +, Ard Biesheuvel wrote: > On 22 February 2018 at 13:15, Leif Lindholm wrote: > > On Tue, Feb 20, 2018 at 05:49:39PM +, Ard Biesheuvel wrote: > >> Introduce the mezzanine protocol and the 96boards package defining > >> the PCDs and GUIDs that may be used

Re: [edk2] [PATCH edk2-platforms v2 2/7] Platform/NinetySixBoards: introduce package and mezzanine protocol

2018-02-22 Thread Ard Biesheuvel
On 22 February 2018 at 13:15, Leif Lindholm wrote: > On Tue, Feb 20, 2018 at 05:49:39PM +, Ard Biesheuvel wrote: >> Introduce the mezzanine protocol and the 96boards package defining >> the PCDs and GUIDs that may be used by implementations of the >> protocol. > > This looks really good. Comme

Re: [edk2] [PATCH edk2-platforms v2 2/7] Platform/NinetySixBoards: introduce package and mezzanine protocol

2018-02-22 Thread Leif Lindholm
On Tue, Feb 20, 2018 at 05:49:39PM +, Ard Biesheuvel wrote: > Introduce the mezzanine protocol and the 96boards package defining > the PCDs and GUIDs that may be used by implementations of the > protocol. This looks really good. Comments below are all style related. > Contributed-under: Tiano