Re: [edk2] [PATCH v2] ShellPkg/TftpDynamicCommand: Change file writing method in tftp

2019-01-14 Thread Li, Songpeng
eparate Feature BZ. We agree with this comment. It is a performance problem and will be fixed. Best, Songpeng > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, January 11, 2019 6:25 PM > To: Li, Songpeng ; edk2-devel@lists.01.org > Cc: Carsey

Re: [edk2] [PATCH v2] ShellPkg/TftpDynamicCommand: Change file writing method in tftp

2019-01-11 Thread Laszlo Ersek
On 01/10/19 03:54, Songpeng Li wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1433 > > v2: Remove an unused variable. > > Current logic of shell tftp download was writing file after tftp > download finished, when the file is large, it looks like the shell > tftp command hanged after

Re: [edk2] [PATCH v2] ShellPkg/TftpDynamicCommand: Change file writing method in tftp

2019-01-10 Thread Wu, Jiaxin
Reviewed-by: Wu Jiaxin > -Original Message- > From: Li, Songpeng > Sent: Thursday, January 10, 2019 10:54 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Ni, Ray ; > Wu, Jiaxin > Subject: [PATCH v2] ShellPkg/TftpDynamicCommand: Change file writing > method in tftp > > REF: https

Re: [edk2] [PATCH v2] ShellPkg/TftpDynamicCommand: Change file writing method in tftp

2019-01-10 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: Li, Songpeng > Sent: Wednesday, January 09, 2019 6:54 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Ni, Ray ; > Wu, Jiaxin > Subject: [PATCH v2] ShellPkg/TftpDynamicCommand: Change file writing > method in tftp > Importance: