Re: [edk2] [PATCH v5 4/6] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

2018-03-14 Thread Ni, Ruiyu
On 3/15/2018 10:57 AM, Guo Heyi wrote: Hi Ray, Sorry I never tried Ecc tool before, for there is few documents about it. When I tried running python BaseTools/Source/Python/Ecc/Ecc.py -t -s , it showed me with error message: ImportError: No module named Common.LongFilePathOs Then I found t

Re: [edk2] [PATCH v5 4/6] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

2018-03-14 Thread Guo Heyi
Hi Ray, Sorry I never tried Ecc tool before, for there is few documents about it. When I tried running python BaseTools/Source/Python/Ecc/Ecc.py -t -s , it showed me with error message: ImportError: No module named Common.LongFilePathOs Then I found there was an executable named "Ecc" in Bas

Re: [edk2] [PATCH v5 4/6] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

2018-03-14 Thread Ard Biesheuvel
On 14 March 2018 at 07:57, Ni, Ruiyu wrote: > On 3/7/2018 2:01 PM, Guo Heyi wrote: >> >> Thanks. Please let me know if any further changes are needed. >> >> Regards, >> >> Heyi >> >> On Wed, Mar 07, 2018 at 12:30:59PM +0800, Ni, Ruiyu wrote: >>> >>> On 3/6/2018 10:44 AM, Guo Heyi wrote:

Re: [edk2] [PATCH v5 4/6] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

2018-03-14 Thread Ni, Ruiyu
On 3/7/2018 2:01 PM, Guo Heyi wrote: Thanks. Please let me know if any further changes are needed. Regards, Heyi On Wed, Mar 07, 2018 at 12:30:59PM +0800, Ni, Ruiyu wrote: On 3/6/2018 10:44 AM, Guo Heyi wrote: Hi Ray, Any comments for v5? Heyi, Some backward compatibility concerns were re

Re: [edk2] [PATCH v5 4/6] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

2018-03-13 Thread Ard Biesheuvel
On 13 March 2018 at 07:31, Guo Heyi wrote: > Hi Ray, > > If the major concern is about backward compatibility, we can think about ways > to > get around of this, e.g. add a feature PCD to turn on translation and set the > default value to false. > I don't think that is necessary. Like any other

Re: [edk2] [PATCH v5 4/6] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

2018-03-13 Thread Guo Heyi
Hi Ray, If the major concern is about backward compatibility, we can think about ways to get around of this, e.g. add a feature PCD to turn on translation and set the default value to false. Thanks, Heyi On Tue, Mar 13, 2018 at 11:00:12AM +0800, Ni, Ruiyu wrote: > On 3/13/2018 1:18 AM, Ard Biesh

Re: [edk2] [PATCH v5 4/6] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

2018-03-12 Thread Ni, Ruiyu
On 3/13/2018 1:18 AM, Ard Biesheuvel wrote: On 7 March 2018 at 04:30, Ni, Ruiyu wrote: On 3/6/2018 10:44 AM, Guo Heyi wrote: Hi Ray, Any comments for v5? Heyi, Some backward compatibility concerns were received from internal production teams. Current change will cause silent failure on ol

Re: [edk2] [PATCH v5 4/6] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

2018-03-12 Thread Ard Biesheuvel
On 7 March 2018 at 04:30, Ni, Ruiyu wrote: > On 3/6/2018 10:44 AM, Guo Heyi wrote: >> >> Hi Ray, >> >> Any comments for v5? > > > Heyi, > Some backward compatibility concerns were received from internal production > teams. Current change will cause silent failure on old platforms because > Transla

Re: [edk2] [PATCH v5 4/6] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

2018-03-06 Thread Guo Heyi
Thanks. Please let me know if any further changes are needed. Regards, Heyi On Wed, Mar 07, 2018 at 12:30:59PM +0800, Ni, Ruiyu wrote: > On 3/6/2018 10:44 AM, Guo Heyi wrote: > >Hi Ray, > > > >Any comments for v5? > > Heyi, > Some backward compatibility concerns were received from internal prod

Re: [edk2] [PATCH v5 4/6] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

2018-03-06 Thread Ni, Ruiyu
On 3/6/2018 10:44 AM, Guo Heyi wrote: Hi Ray, Any comments for v5? Heyi, Some backward compatibility concerns were received from internal production teams. Current change will cause silent failure on old platforms because TranslationOffset might be random if uninitialized. I will solve the c

Re: [edk2] [PATCH v5 4/6] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

2018-03-05 Thread Guo Heyi
Hi Ray, Any comments for v5? Regards, Heyi On Thu, Mar 01, 2018 at 02:57:22PM +0800, Heyi Guo wrote: > PCI address translation is necessary for some non-x86 platforms. On > such platforms, address value (denoted as "device address" or "address > in PCI view") set to PCI BAR registers in configu