Re: [edk2] [Patch 1/2] UefiCpuPkg: Add comments for PCDs definition.

2017-08-22 Thread Kinney, Michael D
gt; Cc: Ni, Ruiyu <ruiyu...@intel.com>; Gao, Liming > <liming....@intel.com> > Subject: RE: [edk2] [Patch 1/2] UefiCpuPkg: Add comments for > PCDs definition. > > Mike, > > I think you misuse PcdCpuFeaturesSetting for > PcdCpuProcTraceMemSize, right? &g

Re: [edk2] [Patch 1/2] UefiCpuPkg: Add comments for PCDs definition.

2017-08-21 Thread Dong, Eric
intel.com>; edk2- > de...@lists.01.org > Cc: Ni, Ruiyu <ruiyu...@intel.com>; Gao, Liming <liming....@intel.com> > Subject: RE: [edk2] [Patch 1/2] UefiCpuPkg: Add comments for PCDs > definition. > > Mike, > > My reason to defined disable options for memory s

Re: [edk2] [Patch 1/2] UefiCpuPkg: Add comments for PCDs definition.

2017-08-17 Thread Kinney, Michael D
lt;ruiyu...@intel.com>; Gao, Liming > <liming....@intel.com> > Subject: RE: [edk2] [Patch 1/2] UefiCpuPkg: Add comments for > PCDs definition. > > Mike, > > My reason to defined disable options for memory size and > output scheme is I can use them as my default polic

Re: [edk2] [Patch 1/2] UefiCpuPkg: Add comments for PCDs definition.

2017-08-17 Thread Dong, Eric
lt;ruiyu...@intel.com>; Gao, Liming <liming....@intel.com> Subject: RE: [edk2] [Patch 1/2] UefiCpuPkg: Add comments for PCDs definition. Eric, For a setup page, the scheme can be greyed out or hidden if the feature is disabled. If the feature is disabled, it does not make sense to al

Re: [edk2] [Patch 1/2] UefiCpuPkg: Add comments for PCDs definition.

2017-08-17 Thread Kinney, Michael D
017 11:48 PM > To: Kinney, Michael D <michael.d.kin...@intel.com>; edk2- > de...@lists.01.org > Cc: Ni, Ruiyu <ruiyu...@intel.com>; Gao, Liming > <liming@intel.com>; Dong, Eric <eric.d...@intel.com> > Subject: RE: [edk2] [Patch 1/2] UefiCpuPkg:

Re: [edk2] [Patch 1/2] UefiCpuPkg: Add comments for PCDs definition.

2017-08-17 Thread Dong, Eric
, Eric <eric.d...@intel.com>; edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kin...@intel.com> Cc: Ni, Ruiyu <ruiyu...@intel.com>; Gao, Liming <liming@intel.com> Subject: RE: [edk2] [Patch 1/2] UefiCpuPkg: Add comments for PCDs definition. Eric, For the PCD Pcd

Re: [edk2] [Patch 1/2] UefiCpuPkg: Add comments for PCDs definition.

2017-08-16 Thread Kinney, Michael D
Eric, For the PCD PcdCpuProcTraceOutputScheme, the description of "Invalid scheme" does not seem like a good description for disable. Do we really need the value 0x02 for PcdCpuProcTraceOutputScheme at all? Can we use PcdCpuFeaturesSetting set to 0x10 ProcTraceMemDisable to know that the feature

Re: [edk2] [Patch 1/2] UefiCpuPkg: Add comments for PCDs definition.

2017-08-09 Thread Kinney, Michael D
Eric, Please add the default value settings to the detailed description. For example, PcdCpuProcTraceMemSize should say that the default value is 0x10 which disables the processor memory trace. Also, the .uni file _HELP should contains the same information as the detailed description, including