Re: [edk2] [Patch 1/3] UefiCpuPkg/RegisterCpuFeaturesLib: Avoid AP calls PeiService.

2019-01-10 Thread Laszlo Ersek
d=1419#c2>.) >> >> >> In addition to changing the default value to zero, I'd suggest moving >> "PcdSpinLockTimeout" from section >> >> [PcdsFixedAtBuild,PcdsPatchableInModule] >> >> to section >> >> [PcdsFix

Re: [edk2] [Patch 1/3] UefiCpuPkg/RegisterCpuFeaturesLib: Avoid AP calls PeiService.

2019-01-09 Thread Dong, Eric
feature (i.e. set a nonzero > value) more flexibly. Agree to do both changes, will submit BZ for it if we get the agreement in this mailing list. Thanks, Eric > > Thanks > Laszlo > > >> -Original Message- > >> From: Brian J. Johnson [mailto:brian.j

Re: [edk2] [Patch 1/3] UefiCpuPkg/RegisterCpuFeaturesLib: Avoid AP calls PeiService.

2019-01-09 Thread Laszlo Ersek
gt;> Brian >> >> On 12/19/18 8:08 PM, Yao, Jiewen wrote: >>> Yes, I agree, if we don't have any real case. >>> >>> >>>> -Original Message- >>>> From: Ni, Ruiyu >>>> Sent: Thursday, December 20, 2018 10:07 AM &g

Re: [edk2] [Patch 1/3] UefiCpuPkg/RegisterCpuFeaturesLib: Avoid AP calls PeiService.

2019-01-08 Thread Dong, Eric
To: Yao, Jiewen ; Ni, Ruiyu ; > Dong, Eric ; edk2-devel@lists.01.org > Cc: Laszlo Ersek > Subject: Re: [edk2] [Patch 1/3] UefiCpuPkg/RegisterCpuFeaturesLib: Avoid > AP calls PeiService. > > Agreed. We've seen issues on real platforms with timed-out spinlocks in DXE > c

Re: [edk2] [Patch 1/3] UefiCpuPkg/RegisterCpuFeaturesLib: Avoid AP calls PeiService.

2018-12-20 Thread Dong, Eric
>> Sent: Thursday, December 20, 2018 10:07 AM > >> To: Dong, Eric ; Yao, Jiewen > >> ; edk2-devel@lists.01.org > >> Cc: Laszlo Ersek > >> Subject: RE: [edk2] [Patch 1/3] UefiCpuPkg/RegisterCpuFeaturesLib: > >> Avoid AP calls PeiService. > >>

Re: [edk2] [Patch 1/3] UefiCpuPkg/RegisterCpuFeaturesLib: Avoid AP calls PeiService.

2018-12-20 Thread Brian J. Johnson
#x27;t have any real case. -Original Message- From: Ni, Ruiyu Sent: Thursday, December 20, 2018 10:07 AM To: Dong, Eric ; Yao, Jiewen ; edk2-devel@lists.01.org Cc: Laszlo Ersek Subject: RE: [edk2] [Patch 1/3] UefiCpuPkg/RegisterCpuFeaturesLib: Avoid AP calls PeiService. Can you just change

Re: [edk2] [Patch 1/3] UefiCpuPkg/RegisterCpuFeaturesLib: Avoid AP calls PeiService.

2018-12-19 Thread Yao, Jiewen
-Original Message- > > From: Dong, Eric > > Sent: Thursday, December 20, 2018 9:23 AM > > To: Yao, Jiewen ; edk2-devel@lists.01.org > > Cc: Ni, Ruiyu ; Laszlo Ersek > > Subject: RE: [edk2] [Patch 1/3] UefiCpuPkg/RegisterCpuFeaturesLib: Avoid > > AP calls

Re: [edk2] [Patch 1/3] UefiCpuPkg/RegisterCpuFeaturesLib: Avoid AP calls PeiService.

2018-12-19 Thread Ni, Ruiyu
; To: Yao, Jiewen ; edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Laszlo Ersek > Subject: RE: [edk2] [Patch 1/3] UefiCpuPkg/RegisterCpuFeaturesLib: Avoid > AP calls PeiService. > > > Agreed, Maybe it's time to add a new API like > AcquireSpinLockWithoutTimeOut? > > Thank

Re: [edk2] [Patch 1/3] UefiCpuPkg/RegisterCpuFeaturesLib: Avoid AP calls PeiService.

2018-12-19 Thread Dong, Eric
: RE: [edk2] [Patch 1/3] UefiCpuPkg/RegisterCpuFeaturesLib: Avoid > AP calls PeiService. > > Hi > If we think below code is generic, can we have an API for that? > > + // > + // Wait for the AP to release the MSR spin lock. > + // > + while

Re: [edk2] [Patch 1/3] UefiCpuPkg/RegisterCpuFeaturesLib: Avoid AP calls PeiService.

2018-12-19 Thread Yao, Jiewen
Hi If we think below code is generic, can we have an API for that? + // + // Wait for the AP to release the MSR spin lock. + // + while (!AcquireSpinLockOrFail (&CpuFlags->ConsoleLogLock)) { +CpuPause (); + } > -Original Message- > From: edk2-devel [mai