Re: [edk2] [RFC] SATA : Implemented NXP errata A008402

2018-01-11 Thread Ard Biesheuvel
On 11 January 2018 at 02:25, Ni, Ruiyu wrote: > On 1/10/2018 5:52 PM, Ard Biesheuvel wrote: >> >> On 10 January 2018 at 09:43, Udit Kumar wrote: >>> >>> Hi Ruiyu, >>> -Original Message- > > > And this change will not impact any other hardware so no one is > basically

Re: [edk2] [RFC] SATA : Implemented NXP errata A008402

2018-01-10 Thread Ni, Ruiyu
On 1/10/2018 5:52 PM, Ard Biesheuvel wrote: On 10 January 2018 at 09:43, Udit Kumar wrote: Hi Ruiyu, -Original Message- And this change will not impact any other hardware so no one is basically impacted by this change. Your buggy HW only need the value zero. But the addition of PC

Re: [edk2] [RFC] SATA : Implemented NXP errata A008402

2018-01-10 Thread Udit Kumar
> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Wednesday, January 10, 2018 3:23 PM > To: Udit Kumar > Cc: Ni, Ruiyu ; Meenakshi Aggarwal > ; edk2-devel@lists.01.org; Zeng, Star > ; leif.lindh...@linaro.org > Subjec

Re: [edk2] [RFC] SATA : Implemented NXP errata A008402

2018-01-10 Thread Ard Biesheuvel
On 10 January 2018 at 09:43, Udit Kumar wrote: > Hi Ruiyu, > >> -Original Message- >> > >> > And this change will not impact any other hardware so no one is basically >> impacted by this change. >> >> Your buggy HW only need the value zero. But the addition of PCD exposes >> an interface t

Re: [edk2] [RFC] SATA : Implemented NXP errata A008402

2018-01-10 Thread Udit Kumar
Hi Ruiyu, > -Original Message- > > > > And this change will not impact any other hardware so no one is basically > impacted by this change. > > Your buggy HW only need the value zero. But the addition of PCD exposes > an interface that can use any size of PRD. > I am not sure the AtaAtap

Re: [edk2] [RFC] SATA : Implemented NXP errata A008402

2018-01-10 Thread Ni, Ruiyu
On 1/10/2018 4:56 PM, Meenakshi Aggarwal wrote: -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ni, Ruiyu Sent: Tuesday, January 09, 2018 9:11 AM To: edk2-devel@lists.01.org Subject: Re: [edk2] [RFC] SATA : Implemented NXP errata A008402 On 1

Re: [edk2] [RFC] SATA : Implemented NXP errata A008402

2018-01-10 Thread Meenakshi Aggarwal
> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ni, > Ruiyu > Sent: Tuesday, January 09, 2018 9:11 AM > To: edk2-devel@lists.01.org > Subject: Re: [edk2] [RFC] SATA : Implemented NXP errata A008402 > > On 1/8/2018 7:1

Re: [edk2] [RFC] SATA : Implemented NXP errata A008402

2018-01-08 Thread Ni, Ruiyu
On 1/8/2018 7:16 PM, Meenakshi Aggarwal wrote: Description: Commands with 4 MB PRD length entries fail if PRD[DBC] is set to the value according to AHCI standard spec. Due to a logic error, 3F_h is misinterpreted by the device as zero length. Is the logic error mentioned here is the error i

Re: [edk2] [RFC] SATA : Implemented NXP errata A008402

2018-01-08 Thread Meenakshi Aggarwal
Cc: Ni, Ruiyu ; Zeng, Star > Subject: RE: [edk2] [RFC] SATA : Implemented NXP errata A008402 > > How will the code work based on your patch if the this PCD is configured to > other value, for example 0x20/0x30? > > > Thanks, > Star > -

Re: [edk2] [RFC] SATA : Implemented NXP errata A008402

2018-01-08 Thread Zeng, Star
...@linaro.org; leif.lindh...@linaro.org; edk2-devel@lists.01.org; Dong, Eric Cc: Ni, Ruiyu Subject: RE: [edk2] [RFC] SATA : Implemented NXP errata A008402 > -Original Message- > From: Zeng, Star [mailto:star.z...@intel.com] > Sent: Monday, January 08, 2018 3:18 PM > To: Meenak

Re: [edk2] [RFC] SATA : Implemented NXP errata A008402

2018-01-08 Thread Meenakshi Aggarwal
m] > Sent: Monday, January 8, 2018 2:26 PM > To: Zeng, Star ; ard.biesheu...@linaro.org; > leif.lindh...@linaro.org; edk2-devel@lists.01.org; Dong, Eric > > Cc: Ni, Ruiyu > Subject: RE: [edk2] [RFC] SATA : Implemented NXP errata A008402 > > Hi Star, > > Apologies and so

Re: [edk2] [RFC] SATA : Implemented NXP errata A008402

2018-01-08 Thread Zeng, Star
.org; Dong, Eric Cc: Ni, Ruiyu Subject: RE: [edk2] [RFC] SATA : Implemented NXP errata A008402 Hi Star, Apologies and some correction in my last reply. As per the errata, PRDT Maximum value needs to be set to 0 only when creating a PRD entry for a maximum data transfer size. So there is

Re: [edk2] [RFC] SATA : Implemented NXP errata A008402

2018-01-07 Thread Meenakshi Aggarwal
age- > From: Meenakshi Aggarwal > Sent: Monday, January 08, 2018 11:25 AM > To: 'Zeng, Star' ; ard.biesheu...@linaro.org; > leif.lindh...@linaro.org; edk2-devel@lists.01.org; Dong, Eric > > Cc: Ni, Ruiyu > Subject: RE: [edk2] [RFC] SATA : Implemented NXP errata A008

Re: [edk2] [RFC] SATA : Implemented NXP errata A008402

2018-01-07 Thread Meenakshi Aggarwal
Message- > From: Zeng, Star [mailto:star.z...@intel.com] > Sent: Monday, January 08, 2018 11:19 AM > To: Meenakshi Aggarwal ; > ard.biesheu...@linaro.org; leif.lindh...@linaro.org; edk2- > de...@lists.01.org; Dong, Eric > Cc: Ni, Ruiyu ; Zeng, Star > Subject: RE: [edk2] [RFC]

Re: [edk2] [RFC] SATA : Implemented NXP errata A008402

2018-01-07 Thread Zeng, Star
Do you have a full patch already? Why the PcdPrdtMaxDataLength is defined to 0x3F, but not 0x40? Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Meenakshi Aggarwal Sent: Monday, January 8, 2018 7:17 PM To: ard.biesheu...@lina