Re: [edk2] [RFC Patch 3/3] BaseTools/Scripts: Add sample makefile for use with RunMakefile.py

2017-08-11 Thread Zhu, Yonghong
Got you. Thanks. Best Regards, Zhu Yonghong -Original Message- From: Kinney, Michael D Sent: Saturday, August 12, 2017 12:33 AM To: Zhu, Yonghong ; edk2-devel@lists.01.org; Kinney, Michael D Cc: Gao, Liming Subject: RE: [RFC Patch 3/3] BaseTools/Scripts: Add sample makefile for use

Re: [edk2] [RFC Patch 3/3] BaseTools/Scripts: Add sample makefile for use with RunMakefile.py

2017-08-11 Thread Kinney, Michael D
Hi Yonghong, The tab characters in the makefile are required. The makefile does not run in all environments if they are replaced with spaces. The makefiles generated by build also use tabs. Mike > -Original Message- > From: Zhu, Yonghong > Sent: Thursday, August 10, 2017 10:41 PM > To:

Re: [edk2] [RFC Patch 3/3] BaseTools/Scripts: Add sample makefile for use with RunMakefile.py

2017-08-10 Thread Zhu, Yonghong
Hi Mike, The patch 3 has some "Tab character used". Please fix it when you commit. Others are good to me. Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Kinney, Michael D Sent: Friday, August 04, 2017 1:30 AM To: edk2-devel@lists.01.org Cc: Gao, Liming