Re: [Ekiga-devel-list] Race condition for disconnect and OnConnected event with 2.0.9. Patch included.
Charlie Hedlin wrote: Yesterday I had Ekiga lock up. Upon connecting with gdb I found that two threads were hung trying to acquire locks. Thread 5 was processing the OnConnected even tfrom SipConnection, up to OpalManager and down to OpalConnection::Released. It was blocked on LockReadWrite. Thread 1, the gui thread Called Manager::ClearCall (from the disconnect button) and blocked in Call::Clear on LockReadOnly. I couldn't find any other threads blocking in unusual states. I have added a Mutex to GMManager that to block clearCall or OnConnected events while the other is happening and have tested for around a hundred calls without hanging, but I can't reliably reproduce this problem. If I make it through a few days without further lockups I will say it likely worked. If this problem and fix can be confirmed it should probably be moved to Opal. I was trying to avoid having another custom package when I added these calls to GMManager. I am attaching my patch. Please disregard the SVN information, it is from my local repository. Robert has recently made a change to OPAL CVS head that reduces all locks within a single call to one mutex. This has removed many possible race conditions. I would recommend looking at these new changes Craig --- Craig Southeren Post Increment – VoIP Consulting and Software [EMAIL PROTECTED] www.postincrement.com.au Phone: +61 243654666 ICQ: #86852844 Fax:+61 243656905 MSN: [EMAIL PROTECTED] Mobile: +61 417231046 Jabber: [EMAIL PROTECTED] It takes a man to suffer ignorance and smile. Be yourself, no matter what they say. Sting ___ Ekiga-devel-list mailing list Ekiga-devel-list@gnome.org http://mail.gnome.org/mailman/listinfo/ekiga-devel-list
Re: [Ekiga-devel-list] Race condition for disconnect and OnConnected event with 2.0.9. Patch included.
Damien Sandras wrote: Le mercredi 09 mai 2007 à 09:03 +0200, Jan Schampera a écrit : Hey Charlie! If this problem and fix can be confirmed it should probably be moved to Opal. I was trying to avoid having another custom package when I added these calls to GMManager. I am attaching my patch. Please disregard the SVN information, it is from my local repository. Unfortunately I can't check it right now, I crashed my main system's CPU (with a screwdriver!) :-) Damien, I remember some deadlock I could not reproduce by will, that could be related - though I don't get under which conditions it deadlocks. I keep this patch in my queue of patches... Go ahead and remove the patch from the queue. It seems to have fixed one deadlock just in time for me to hit them elsewhere. Is there documentation about the various branches so I could start testing with development code? I would like to go for something more stable than head, but unfortunately 2.0.9 isn't going to do. Thank you, Charlie Hedlin ___ Ekiga-devel-list mailing list Ekiga-devel-list@gnome.org http://mail.gnome.org/mailman/listinfo/ekiga-devel-list
Re: [Ekiga-devel-list] Race condition for disconnect and OnConnected event with 2.0.9. Patch included.
Le mercredi 09 mai 2007 à 09:48 -0500, Charlie Hedlin a écrit : Damien Sandras wrote: Le mercredi 09 mai 2007 à 09:03 +0200, Jan Schampera a écrit : Hey Charlie! If this problem and fix can be confirmed it should probably be moved to Opal. I was trying to avoid having another custom package when I added these calls to GMManager. I am attaching my patch. Please disregard the SVN information, it is from my local repository. Unfortunately I can't check it right now, I crashed my main system's CPU (with a screwdriver!) :-) Damien, I remember some deadlock I could not reproduce by will, that could be related - though I don't get under which conditions it deadlocks. I keep this patch in my queue of patches... Go ahead and remove the patch from the queue. It seems to have fixed one deadlock just in time for me to hit them elsewhere. Is there documentation about the various branches so I could start testing with development code? I would like to go for something more stable than head, but unfortunately 2.0.9 isn't going to do. 2.0.9 and HEAD should have the same level of stability (we backport changes from HEAD to Phobos). If you encounter stability problems, please report them back here so that we can fix them. But do you encounter stability problems or not ? I do not understand your e-mail... Thank you, -- _ Damien Sandras (o- //\Ekiga Softphone : http://www.ekiga.org/ v_/_ NOVACOM : http://www.novacom.be/ FOSDEM : http://www.fosdem.org/ SIP Phone : sip:[EMAIL PROTECTED] ___ Ekiga-devel-list mailing list Ekiga-devel-list@gnome.org http://mail.gnome.org/mailman/listinfo/ekiga-devel-list
Re: [Ekiga-devel-list] Race condition for disconnect and OnConnected event with 2.0.9. Patch included.
Le mercredi 09 mai 2007 à 11:14 -0500, Charlie Hedlin a écrit : 2.0.9 and HEAD should have the same level of stability (we backport changes from HEAD to Phobos). If you encounter stability problems, please report them back here so that we can fix them. But do you encounter stability problems or not ? I do not understand your e-mail... Thank you, There are two types of stable... Stable as in the code isn't changing except for bug fixes and stable as in it doesn't crash. I was referring to unchanging code when looking for branches, but of course I want both. Indeed. 2.0.9 is definitely deadlocking, and my patches just moved the location around without fixing anything. OK. I am currently checking out the gnome-2-14 branch and pwlib and opal Phobos so I can test with the recent changes Craig Southeren added to Phobos. Yes, that is what you are supposed to do. I will write when I have done testing. Once I have a reliable version we will be placing about 10k calls per day on ekiga through our asterisk server. We are currently using Sip Foundry's sipXtapi and have contributed a number of bug fixes to their project as well as created SipXTapiDotNet to use the library on Windows in .Net applications. Unfortunately there have been major problems in the media thread of sipXtapi that we have been unable to overcome in our limited amount of time, so we are moving everything to Linux and Ekiga. Good, I'd like to hear reports about this and remove all possible problems. -- _ Damien Sandras (o- //\Ekiga Softphone : http://www.ekiga.org/ v_/_ NOVACOM : http://www.novacom.be/ FOSDEM : http://www.fosdem.org/ SIP Phone : sip:[EMAIL PROTECTED] ___ Ekiga-devel-list mailing list Ekiga-devel-list@gnome.org http://mail.gnome.org/mailman/listinfo/ekiga-devel-list
Re: [Ekiga-devel-list] Race condition for disconnect and OnConnected event with 2.0.9. Patch included.
At this point I should probably move to the Opal list, but unless that is requested I will stay on this thread. I tried to compile Opal Phobos and failed on src/opal/connection.cxx. Looking at the CVS log it shows the updates committed to revision 2.55.2.4 while Phobos is assigned to 2.55.0.2. I am remembering why I use subversion and feel that my CVS experience may be a bit lacking. Should I be using the Phobos tag or is there another tag for pending Phobos changes? co -r Phobos opal should get me the right code, right? Thank you, Charlie Hedlin Craig Southeren wrote: Damien Sandras wrote: ...deleted Would it be possible to make sure to synchronize the interesting changesfrom HEAD to Phobos in order to release Ekiga 2.0.10 ? Done Craig --- Craig Southeren Post Increment – VoIP Consulting and Software [EMAIL PROTECTED] www.postincrement.com.au Phone: +61 243654666 ICQ: #86852844 Fax:+61 243656905 MSN: [EMAIL PROTECTED] Mobile: +61 417231046 Jabber: [EMAIL PROTECTED] "It takes a man to suffer ignorance and smile. Be yourself, no matter what they say." Sting ___ Ekiga-devel-list mailing list Ekiga-devel-list@gnome.org http://mail.gnome.org/mailman/listinfo/ekiga-devel-list ___ Ekiga-devel-list mailing list Ekiga-devel-list@gnome.org http://mail.gnome.org/mailman/listinfo/ekiga-devel-list
Re: [Ekiga-devel-list] Race condition for disconnect and OnConnected event with 2.0.9. Patch included.
Hi, Le mercredi 09 mai 2007 à 18:21 +0200, Damien Sandras a écrit : I will write when I have done testing. Once I have a reliable version we will be placing about 10k calls per day on ekiga through our asterisk server. We are currently using Sip Foundry's sipXtapi and have contributed a number of bug fixes to their project as well as created SipXTapiDotNet to use the library on Windows in .Net applications. Unfortunately there have been major problems in the media thread of sipXtapi that we have been unable to overcome in our limited amount of time, so we are moving everything to Linux and Ekiga. Good, I'd like to hear reports about this and remove all possible problems. And maybe, if everything goes fine and if it's ok, tell the world Ekiga can be use in large scale : http://wiki.ekiga.org/index.php/Reviewers_FAQ#Study_cases_.28RL.29 At the moment, I've no report for such intensive use, I would like to write that kind of stories in our wiki... Regards, Yannick -- Me joindre en téléphonie IP / vidéoconférence ? sip:[EMAIL PROTECTED] ___ Ekiga-devel-list mailing list Ekiga-devel-list@gnome.org http://mail.gnome.org/mailman/listinfo/ekiga-devel-list
Re: [Ekiga-devel-list] Race condition for disconnect and OnConnected event with 2.0.9. Patch included.
Hey Charlie! If this problem and fix can be confirmed it should probably be moved to Opal. I was trying to avoid having another custom package when I added these calls to GMManager. I am attaching my patch. Please disregard the SVN information, it is from my local repository. Unfortunately I can't check it right now, I crashed my main system's CPU (with a screwdriver!) :-) Damien, I remember some deadlock I could not reproduce by will, that could be related - though I don't get under which conditions it deadlocks. Regards, Jan ___ Ekiga-devel-list mailing list Ekiga-devel-list@gnome.org http://mail.gnome.org/mailman/listinfo/ekiga-devel-list
