The proposal to merge
lp:~elementary-dev-community/pantheon-terminal/fix-1329550 into
lp:pantheon-terminal has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~elementary-dev-community/pantheon-terminal/fix-1329550/+merge/229683
--
https
The proposal to merge
lp:~elementary-dev-community/pantheon-terminal/fix-1329550 into
lp:pantheon-terminal has been updated.
Commit Message changed to:
Adds an --about (-a) command line option and a corresponding quicklist item
For more details, see:
https://code.launchpad.net/~elementary-dev
Attempt to merge into lp:pantheon-terminal failed due to conflicts:
text conflict in data/pantheon-terminal.desktop
--
https://code.launchpad.net/~elementary-dev-community/pantheon-terminal/fix-1329550/+merge/229683
Your team elementary Developer Community is subscribed to branch
The proposal to merge
lp:~elementary-dev-community/pantheon-terminal/fix-1329550 into
lp:pantheon-terminal has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~elementary-dev-community/pantheon-terminal/fix-1329550/+merge/229683
--
https
Ok, I managed to get around (2) by initializing Gtk in main() and then setting
the dark theme.
--
https://code.launchpad.net/~elementary-dev-community/pantheon-terminal/fix-1329550/+merge/229683
Your team elementary Developer Community is subscribed to branch
Cameron Norman has proposed merging
lp:~elementary-dev-community/pantheon-terminal/fix-1329550 into
lp:pantheon-terminal.
Requested reviews:
elementary Apps team (elementary-apps)
Related bugs:
Bug #1329550 in Terminal: Move About to quicklist
Review: Needs Fixing
1. Instead of
43 stdout.printf (pantheon-terminal: ERROR: + e.message + \n);
44
45 return 0;
use
error (e.message);
2. Not sure about the relevant part in the code, but the dark GTK+ theme isn't
active when you start the About-Dialog from the quicklist and no
1) is not my code, but I can definitely include that change.
2) This may be a granite deficiency, as the about option here works by relying
on the Granite.Application's behavior when running with the --about option. I
think that when Granite creates the about dialog when the app is already
8 matches
Mail list logo
