Re: [Elftoolchain-developers] addr2line improvements - sys/tree.h on Linux

2020-02-14 Thread Joseph Koshy via Elftoolchain-developers
ed> Should the build glue (adding appropriate -I arguments, etc.) already ed> be in place? ed> I tried building the change on Ubuntu 18.04 via CI and it failed to ed> find . The example programs in the libelf tutorial use "libbsd-dev". To build on Ubuntu you may need something like the

Re: [Elftoolchain-developers] addr2line improvements - sys/tree.h on Linux

2020-02-13 Thread Ed Maste
On Thu, 13 Feb 2020 at 16:13, Joseph Koshy wrote: > > > However this uses BSD's sys/tree.h, and I am not sure if it's > > available on Linux distros. Once we have CI for Linux (or get advice > > on sys/tree.h there) I will work on bringing these changes upstream. > > would be part of the

Re: [Elftoolchain-developers] addr2line improvements - sys/tree.h on Linux

2020-02-13 Thread Joseph Koshy via Elftoolchain-developers
jk> In https://reviews.freebsd.org/D23418 there is mention of increased jk> memory usage, from 256K to 77M. This seems a large increase; was it jk> looked at in FreeBSD? markj> This is stale and was due to a bug in an early version of the patch. We markj> did some heap profiling and found that

Re: [Elftoolchain-developers] addr2line improvements - sys/tree.h on Linux

2020-02-13 Thread Mark Johnston
On Thu, Feb 13, 2020 at 09:13:08PM +, Joseph Koshy via Elftoolchain-developers wrote: > Ed, > > > https://reviews.freebsd.org/rS357450 > > addr2line: Cache CU DIEs upon a successful address lookup > > In https://reviews.freebsd.org/D23418 there is mention of increased > memory usage, from

Re: [Elftoolchain-developers] addr2line improvements - sys/tree.h on Linux

2020-02-13 Thread Joseph Koshy via Elftoolchain-developers
Ed, > https://reviews.freebsd.org/rS357450 > addr2line: Cache CU DIEs upon a successful address lookup In https://reviews.freebsd.org/D23418 there is mention of increased memory usage, from 256K to 77M. This seems a large increase; was it looked at in FreeBSD? The Minix microkernel is one of