Re: [PATCH] Fix 'make coverage' when used with lcov version 2.0+

Hi, I think things worked out in the end, so that is good. Personally I didn't think Dmitry's request to take his review into account was exaggerating. But that might be because I know him and am happy with his suggestions in general. If the tone of some request was interpreted as "not

Re: [PATCH] Fix 'make coverage' when used with lcov version 2.0+

Hi - > Well, even if it happened unintentionally, it was ignored just the same > as if it happened on purpose. I hope the technical reasons for that > are now fixed, and won't cause any problems next time. You have been in the open source community long enough to know that emails sometimes just

Re: [PATCH] Fix 'make coverage' when used with lcov version 2.0+

Hi Frank, On Thu, May 09, 2024 at 07:03:47PM -0400, Frank Ch. Eigler wrote: > Hi - > > > > > What's the purpose of sending proposed patches to the mailing list > > > > if reviews are silently ignored? > > > > > > Please be collegial and don't exaggerate. > > > > The fact is that the review was

Re: [PATCH] Fix 'make coverage' when used with lcov version 2.0+

Hi - > > > What's the purpose of sending proposed patches to the mailing list > > > if reviews are silently ignored? > > > > Please be collegial and don't exaggerate. > > The fact is that the review was silently ignored, which is, from my point > of view, an extraordinary event, The review

Re: [PATCH] Fix 'make coverage' when used with lcov version 2.0+

On Thu, May 09, 2024 at 06:08:05PM -0400, Frank Ch. Eigler wrote: > Hi - > > On Fri, May 10, 2024 at 12:53:39AM +0300, Dmitry V. Levin wrote: > > > Pushed as commit ca8ad4648197 > > > > What's the purpose of sending proposed patches to the mailing list > > if reviews are silently ignored? > >

Re: [PATCH] Fix 'make coverage' when used with lcov version 2.0+

Hi - On Fri, May 10, 2024 at 12:53:39AM +0300, Dmitry V. Levin wrote: > > Pushed as commit ca8ad4648197 > > What's the purpose of sending proposed patches to the mailing list > if reviews are silently ignored? Please be collegial and don't exaggerate. - FChE

Re: [PATCH] Fix 'make coverage' when used with lcov version 2.0+

On Wed, May 08, 2024 at 12:28:04PM -0400, Aaron Merey wrote: > On Mon, May 6, 2024 at 4:45 PM Aaron Merey wrote: > > > > Starting with version 2.0, various lcov warnings now trigger an error > > exit. This results in 'make coverage' terminating before completion. > > > > Fix this by invoking

Re: [PATCH] Fix 'make coverage' when used with lcov version 2.0+

On Mon, May 6, 2024 at 4:45 PM Aaron Merey wrote: > > Starting with version 2.0, various lcov warnings now trigger an error > exit. This results in 'make coverage' terminating before completion. > > Fix this by invoking lcov and genhtml with --ignore-errors to prevent > the error exit when

Re: [PATCH] Fix 'make coverage' when used with lcov version 2.0+

Hi, On Mon, May 06, 2024 at 04:45:27PM -0400, Aaron Merey wrote: > Starting with version 2.0, various lcov warnings now trigger an error > exit. This results in 'make coverage' terminating before completion. > > Fix this by invoking lcov and genhtml with --ignore-errors to prevent > the error

[PATCH] Fix 'make coverage' when used with lcov version 2.0+

Starting with version 2.0, various lcov warnings now trigger an error exit. This results in 'make coverage' terminating before completion. Fix this by invoking lcov and genhtml with --ignore-errors to prevent the error exit when version 2.0+ is in use. Manually tested by running