Re: [elixir-core:8302] Proposal: Comments in AST

2018-09-17 Thread José Valim
I don't think we ever stored them in meta. But even if we did, we would probably have done it in the formatter, and we should likely move it somewhere public. *José Valim* www.plataformatec.com.br Skype: jv.ptec Founder and Director of R On Mon, Sep 17, 2018 at 8:37 PM, Louis Pilfold wrote:

Re: [elixir-core:8303] Proposal: Comments in AST

2018-09-17 Thread Steve Morin
Yes being part of the metadata would be great. Need to look around/research and see what other people have done. Just not losing the data would be great. > On Sep 17, 2018, at 12:10, José Valim wrote: > > I don't think we ever stored them in meta. But even if we did, we would > probably

Re: [elixir-core:8300] Proposal: Comments in AST

2018-09-17 Thread OvermindDL1
In addition, clang and a few other compilers I've worked with also all 'carry' comments in some form (either as their own syntactical node or as metadata on another node), so there is massive precedence. On Monday, September 17, 2018 at 11:28:11 AM UTC-6, OvermindDL1 wrote: > > Comments are

Re: [elixir-core:8301] Proposal: Comments in AST

2018-09-17 Thread Louis Pilfold
Hey I'm a little out of touch with this area, but isn't this what we previously did? I remember comments being stored in meta during the creation of the formatter. Or did I make that up? Cheers, Louis On Mon, 17 Sep 2018 at 19:17 José Valim wrote: > I like the metadata idea a lot, thanks. We

Re: [elixir-core:8299] Proposal: Comments in AST

2018-09-17 Thread OvermindDL1
Comments are part of the syntax and should be parsed as such however. Personally I'd opt for an OCaml-style handling of comments where the comments get turned into a meta attribute on the related tag, which for elixir could be as simple as wrapping the related comment part in something like

[elixir-core:8296] GenStage, Plug, Hooks, ...

2018-09-17 Thread Manuel Rubio
Hello, I was thinking to create a system which let me to plug some functionalities in future like ejabberd or MongooseIM does with hooks: https://github.com/benoitc/hooks The point is, if I have a dynamic pipeline created to process sequentially data, let me to include in that pipeline new code

Re: [elixir-core:8297] GenStage, Plug, Hooks, ...

2018-09-17 Thread Andrea Leopardi
Hey Manuel, the elixir-lang-core mailing list is reserved for discussions on the language and on language features. For example, you would write here if you had a proposal for a new feature to add to Elixir. This is outlined in this page: https://elixir-lang.org/development.html. I think your