Lute Kamstra wrote:
I prefer the latter. Maybe the mode function will never be called.
For example, it makes it possible to remove (require 'generic) from
generic-x.el. So you can just load generic-x.elc to define a bunch of
major modes (and add them to auto-mode-alist) and generic.e
In this case, I'd prefer to have
(defcustom generic-use-find-file-hook t
! "*If non-nil, add a hook to call `default-generic-mode'
automatically.
The main rationale is that this will give a working cross reference
link in the help window.
That is ok.
Lute Kamstra <[EMAIL PROTECTED]> writes:
> I changed define-generic-mode so that the name of the mode command
> need not be quoted (while retaining backward compatibility). This
> makes define-generic-mode more like other defining forms. I updated
> the docstring of define-generic-mode t
Here is an updated patch that incorporates the feedback of Stefan and
Richard.
I also changed three other things:
I removed the (eval-when-compile (require 'cl)) as that is not
needed.
I changed define-generic-mode so that the name of the mode command
need not be quoted (while retaining
Richard Stallman <[EMAIL PROTECTED]> writes:
> Thanks very much for making etc/TODO smaller.
> I have one minor criticism:
>
> (defcustom generic-use-find-file-hook t
> ! "*If non-nil, add a hook to enter `default-generic-mode'
> automatically.
>
> That doc string should say
>
>
Richard Stallman <[EMAIL PROTECTED]> writes:
> Thanks very much for making etc/TODO smaller.
> I have one minor criticism:
>
> (defcustom generic-use-find-file-hook t
> ! "*If non-nil, add a hook to enter `default-generic-mode'
> automatically.
>
> That doc string should say
>
>
Thanks very much for making etc/TODO smaller.
I have one minor criticism:
(defcustom generic-use-find-file-hook t
! "*If non-nil, add a hook to enter `default-generic-mode' automatically.
That doc string should say
(defcustom generic-use-find-file-hook t
! "*If non-nil, a
Stefan Monnier <[EMAIL PROTECTED]> writes:
>>> When loading a byte-compiled file that used define-generic-mode, I
>>> think you'll get an error that generic-mode-list is not defined
>>> (because generic.el doesn't get loaded: the autoload caused
>>> generic.el to be loaded during byte-compilation,
>> When loading a byte-compiled file that used define-generic-mode, I
>> think you'll get an error that generic-mode-list is not defined
>> (because generic.el doesn't get loaded: the autoload caused
>> generic.el to be loaded during byte-compilation, but it doesn't have
>> any such effect when loa
Stefan Monnier <[EMAIL PROTECTED]> writes:
> When loading a byte-compiled file that used define-generic-mode, I
> think you'll get an error that generic-mode-list is not defined
> (because generic.el doesn't get loaded: the autoload caused
> generic.el to be loaded during byte-compilation, but it
> and fixed some minor things along the way. Does anybody see any
> problems with this patch?
When loading a byte-compiled file that used define-generic-mode, I think
you'll get an error that generic-mode-list is not defined (because
generic.el doesn't get loaded: the autoload caused generic.el t
I worked on this item in etc/TODO:
** Redefine define-generic-mode as a macro, so the compiler
sees the definitions it generates.
and fixed some minor things along the way. Does anybody see any
problems with this patch?
Lute.
Index: lisp/ChangeLog
===
12 matches
Mail list logo
