Re: [PATCH] Bug: fragile org refile cache

2021-04-28 Thread Samuel Wales
thanks for reporting that you use it. would it be more useful if it automaticaly generated the cache instead of telling you to runt he command to do so? if a solid, perhaps unified, cache existed, would org-id use it too? On 4/28/21, Ihor Radchenko wrote: > Samuel Wales writes: > >> long ago

Re: [PATCH] Bug: fragile org refile cache

2021-04-28 Thread Ihor Radchenko
Samuel Wales writes: > long ago i used to use the refile cache. i think it is probably not > widely used, or maybe even not at all. At least, I do use it. A lot. I rely on it. I do not observe the breakage as described in the first message, mostly because I use refile cache exclusively for

Re: [PATCH] Bug: fragile org refile cache

2021-04-28 Thread Samuel Wales
long ago i used to use the refile cache. i think it is probably not widely used, or maybe even not at all. the reason i stopped was behavior that sounds similar to your description. such as, it would produce a set of results that did not match the calling conditions. i cannot reach the thread

Re: Bug: Org mode fails to compile using Emacs 24.5-r10 [9.4.5 (9.4.5-g3ea248 @ /home/yantar92/.emacs.d/straight/build/org/)]

2021-04-28 Thread Robert Horn
Timothy writes: > Ihor Radchenko writes: > > Maybe this is a good time to start a discussion about moving Org's > minimum supported Emacs to 25...? I checked Red Hat, Centos, Debian, SuSE, and Ubuntu. They are all 25.1 or later in their current distributions. So that will probably not cause

Re: [PATCH] Fixed-pitch tables and code blocks that do not break variable-pitch-mode

2021-04-28 Thread Protesilaos Stavrou
On 2021-04-27, 21:28 +0200, Bastien wrote: >> Please see the attached diff. An explanation is offered below. I have >> already assigned copyright to the FSF. > > Sorry it took so long to commit this, it is done in commit 667cb6f1a > in master, adding fixed-pitch for org-hide, org-verbatim and

Re: [PATCH] Have C-c C-c recognise #+plot lines

2021-04-28 Thread Timothy
Hi Eric, Have you had a chance to test this out? -- Timothy

Re: bug#47885: [PATCH] org-table-import: Make it more smarter for interactive use

2021-04-28 Thread Maxim Nikulin
On 28/04/2021 15:37, Utkarsh Singh wrote: +List of preferred separator (in order of preference): +comma, TAB, semicolon, colon or SPACE. I will hardly be using this feature heavily, so I do not insist that the following must be taken into account. Just some considerations... There are locales

Re: splot and #+PLOT keyword

2021-04-28 Thread Eric S Fraga
Looking at the code, 3d plotting does not support plotting individual selected columns, it would appear. :-( I think I'll stick to using src blocks instead, which is what I've been doing for years, for 3d plots. Sorry for the noise and thanks again. -- : Eric S Fraga via Emacs 28.0.50, Org

Re: splot and #+PLOT keyword

2021-04-28 Thread Eric S Fraga
Hi Nick, On Wednesday, 28 Apr 2021 at 11:28, Nick Dokos wrote: > Have you tried looking at the produced gnuplot script? It goes in a > temp file so it's a bit of a pain, but that's my fallback method when > I'm really confused :-) The issue appears to be the data that are also placed in a temp

[PATCH] Bug: fragile org refile cache

2021-04-28 Thread Maxim Nikulin
Reviewing my attempt to speedup collecting of refile targets https://orgmode.org/list/s209r8$16en$1...@ciao.gmane.io/ I have realized that refile cache is unreliable. With specific customization, cache content and thus refile targets depend on the function called first: `org-refile' ([C-u] C-c

Re: Bug: Org mode fails to compile using Emacs 24.5-r10 [9.4.5 (9.4.5-g3ea248 @ /home/yantar92/.emacs.d/straight/build/org/)]

2021-04-28 Thread Timothy
Ihor Radchenko writes: > In any case, not all the warnings go away even using Emacs 25.3: Just going to chime in here with the relevant info: > ob-gnuplot.el:299:1:Warning: the function ‘file-local-name’ is not known to be > defined. :added:26.1 It looks like the definition could

Re: splot and #+PLOT keyword

2021-04-28 Thread Nick Dokos
Eric S Fraga writes: > Hello, > > a question/problem regarding the #+plot: keyword. > > I am trying to plot out some data where the table looks like this: > > #+begin_src org > ,#+plot: ind:(6 7) deps:(1) with:"linespoints pt 7" set:"logscale xy" > type:3d > | 1 | 81 | 5 | 0

Re: org-goto and org-store-link/org-id-get-create

2021-04-28 Thread Bastien
Hi Ihor, applied in master as commit 232d9a060, thanks a lot! -- Bastien

Re: Bug: Org mode fails to compile using Emacs 24.5-r10 [9.4.5 (9.4.5-g3ea248 @ /home/yantar92/.emacs.d/straight/build/org/)]

2021-04-28 Thread Ihor Radchenko
Timothy writes: > Maybe this is a good time to start a discussion about moving Org's > minimum supported Emacs to 25...? I have no objections here, since I am on Emacs master anyway. In any case, not all the warnings go away even using Emacs 25.3: Compiling

Re: Bug: Org mode fails to compile using Emacs 24.5-r10 [9.4.5 (9.4.5-g3ea248 @ /home/yantar92/.emacs.d/straight/build/org/)]

2021-04-28 Thread Timothy
Ihor Radchenko writes: Maybe this is a good time to start a discussion about moving Org's minimum supported Emacs to 25...? -- Timothy

Re: org-goto and org-store-link/org-id-get-create

2021-04-28 Thread Ihor Radchenko
Bastien writes: > Can you provide a patch for this? Sure. Attached. >From d914acea52d251e2099681ac9541e4cb42e0953f Mon Sep 17 00:00:00 2001 Message-Id: From: Ihor Radchenko Date: Wed, 28 Apr 2021 22:51:53 +0800 Subject: [PATCH] Bypass read-only state in org-entry-put * lisp/org.el

Bug: Org mode fails to compile using Emacs 24.5-r10 [9.4.5 (9.4.5-g3ea248 @ /home/yantar92/.emacs.d/straight/build/org/)]

2021-04-28 Thread Ihor Radchenko
I was recently testing Org mode using old Emacs versions. Running make on master fails with the following errors and warnings: Compiling /home/yantar92/Git/org-mode/lisp/ob-C.el... Eager macro-expansion failure: (error "Vector QPatterns not implemented yet") Compiling

Re: [WDYT, mini] key h in agenda for quick help

2021-04-28 Thread Greg Minshall
Timothy, thanks! > Greg Minshall writes: > > > having glanced briefly at transient, would it be something with which > > one could, e.g., implement the export menu? > > > > where else in org-mode would you see using it? > > > > (just curiosity.) > > > > cheers, Greg > > This is going to sound

Re: More use of lexical-binding in ox.el

2021-04-28 Thread Stefan Monnier
>> Yes: >> >> (push (cons var val) varvals >> varvals))) >> >> should be >> >> (push (cons var val) varvals) >> varvals)) >> >> so that the final `varvals` is outside the `dolist` (it's the thing we >> want to return to store

Re: [patch] to allow org-attach-git to handle individual repositories

2021-04-28 Thread Juan Manuel Macías
Hi Bastien, Bastien writes: > It looks good but it is significative enough to require you to sign > the FSF copyright assignment. If you're willing to go through this > (which will secure future contributions too), please see: Thanks for the advice. I just signed and sent the FSF copyright

Bug: org-edit-special indents inline latex [9.5 (nil @ /home/david/.emacs.d/.local/straight/build-27.2/org-mode/)]

2021-04-28 Thread Dávid Jakab
Remember to cover the basics, that is, what you expected to happen and what in fact did happen.  You don't know how to make a good report?  See https://orgmode.org/manual/Feedback.html#Feedback Your bug report will be posted to the Org mailing list.

Re: [WDYT, mini] key h in agenda for quick help

2021-04-28 Thread Timothy
Greg Minshall writes: > having glanced briefly at transient, would it be something with which > one could, e.g., implement the export menu? > > where else in org-mode would you see using it? > > (just curiosity.) > > cheers, Greg This is going to sound really generic, but I think it's a good

Re: [WDYT, mini] key h in agenda for quick help

2021-04-28 Thread Greg Minshall
Timothy, > I actually think Org would benefit from using transient (which has > recently been merged into Emacs), and it could reduce the maintenance > burden, but I suppose that's not possible with our minimum version at > Emacs 24... having glanced briefly at transient, would it be something

Re: [PATCH] org-protocol: Fix missing '+' in js snippet

2021-04-28 Thread Maxim Nikulin
Hi Bastien. On 28/04/2021 12:40, you wrote: Hi Maxim, Would you like to volunteer as the maintainer for org-protocol.el? For now org-protocol.el indicates that Sebastian Rose, the original author, is the maintainer, but I don't think he would mind handing it to someone else. I am proud to

Re: Bug? C-h v in src block since org-9.4

2021-04-28 Thread Eric S Fraga
On Wednesday, 28 Apr 2021 at 19:19, Maxim Nikulin wrote: > With org 9.4+ I have to type variable name, no default option is > provided. TAB completion still works. Moreover, after help page for a > variable has been open (even for another one, e.g. > `org-refile-targets'), next time C-h v at

Bug? C-h v in src block since org-9.4

2021-04-28 Thread Maxim Nikulin
Hi, I am unsure if it is a bug or expected behavior of autoload. Try the following org file in new a "emacs -Q" instance: --- >8 --- #+begin_src elisp (setq org-refile-use-cache t) ;;^- put cursor here and try C-h v #+end_src --- 8< --- With org 9.3.8 I get `org-refile-use-cache' as

splot and #+PLOT keyword

2021-04-28 Thread Eric S Fraga
Hello, a question/problem regarding the #+plot: keyword. I am trying to plot out some data where the table looks like this: #+begin_src org ,#+plot: ind:(6 7) deps:(1) with:"linespoints pt 7" set:"logscale xy" type:3d | 1 | 81 | 5 | 0 | 2.27 | 0.9729848950975623 |

[PATCH] fix point position shifting in some org-src instances

2021-04-28 Thread Timothy
Hi All, I've noticed for a while that if you have a block with overlays/invisible characters that editing it with `org-edit-special' moves the point around. For example, with Org pretty entities enabled, and █ indicating the cursor, if I call org-edit-special on a LaTeX fragment like: \(

Re: More use of lexical-binding in ox.el

2021-04-28 Thread Nicolas Goaziou
Hello, Stefan Monnier writes: > That's because the "buffer copy" also copies the local vars, For some reason, I misread the code and thought `buffer-file-name' and `default-directory' were explicitly ignored. Go figure. > Yes: > > (push (cons var val) varvals >

bug#47885: [PATCH] org-table-import: Make it more smarter for interactive use

2021-04-28 Thread Utkarsh Singh
Hi, On 2021-04-27, 22:21 +0200, Nicolas Goaziou wrote: >> + When using org-table-import interactively if we failed to guess >> separator then we will be left with a user-error message and an >> 'unconverted table'. We can make use of 'temp-buffer' to import our >> file after successfully

bug#45915: 27.2; deletechar distorts org-table

2021-04-28 Thread Tak Kunihiro
>> I confirm that there still is following problem on 27.1.91. >> Could someone take a look and show me work around? > > I cannot reproduce this with latest Org stable version 9.4.5. > > Can you try again and report? I downloaded Org 9.4.5 and reproduced the problem on 26.3, 27.2, and 28.0.50.

Re: [Patch] to correctly sort the items with emphasis marks in a list

2021-04-28 Thread Bastien
Bastien writes: > Thanks for the heads-up. I reverted the commit. Please go ahead with > whatever you see fit. PS: Re-opening this work-in-progress patch for updates.orgmode.org. -- Bastien

Re: Plea for reviews/action on my Patches

2021-04-28 Thread Timothy
Thanks for getting back to me on this Bastien :) Bastien writes: > I suggest you rather bump them individually: sending such a digest > will scatter the discussion in separate places. (I'm raising some > points below, but please follow-up in the upstream thread.) I have responded to your

Re: [PATCH 2/3] org-protocol.el: Fix detection of old-style URIs

2021-04-28 Thread Bastien
Applied in maint, thanks! -- Bastien

Re: [PATCH] Add font-lock rule for inline export snippets

2021-04-28 Thread Timothy
Timothy writes: > Hello, > > The latest in my visually-oriented (mostly) short patch series, adding > basic fontification to inline export snippets --- @@comment:these things@@. > > I think fontification for stuff like this is nice because it visually > indicates to the user that they've

Re: [PATCH 3/3] test-org-protocol.el: Add expected failures for file:/// URLs

2021-04-28 Thread Bastien
Applied as 3dbeb677e in master, thanks. Maxim Nikulin writes: > * testing/lisp/test-org-protocol.el > (test-org-protocol/org-protocol-store-link-file, > test-org-protocol/org-protocol-capture-file): Add tests to document > that existing calls to `org-protocol-sanitize-uri' could make passed >

Re: [PATCH] Fontification for inline src blocks

2021-04-28 Thread Timothy
Timothy writes: > Hi All, > > I've been using inline src blocks a fair bit more recently, and I've > thought it's a pity how bad they look as they are currently without > fontification. A little digging into Org internals and font-lock later > and we have this patch. I could speak about what's

Re: [PATCH 1/3] test-org-protocol.el: Fix the case for parse parameters with complex argument

2021-04-28 Thread Bastien
Applied in maint, thanks and sorry for the slow reply. Maxim Nikulin writes: > * testing/lisp/test-org-protocol.el > (test-org-protocol/org-protocol-parse-parameters): Specify that the case > simulating real life capture uses new style parameters string > to prevent test failure. > > It looks

Re: [Patch] to correctly sort the items with emphasis marks in a list

2021-04-28 Thread Bastien
Nicolas Goaziou writes: > Unfortunately, this is not a proper fix for the problem, as discussed in > the thread. Thanks for the heads-up. I reverted the commit. Please go ahead with whatever you see fit. -- Bastien

Re: Plea for reviews/action on my Patches

2021-04-28 Thread Bastien
Hi Timothy, Timothy writes: > This is a very me-centric email Hehe. > but I've got a collection patches that > have received little attention (1 of the past 9 patches I've submitted > has been reviewed by a core contributor, 6 have zero replies). I care > about them, and I think it would be

Re: [Patch] to correctly sort the items with emphasis marks in a list

2021-04-28 Thread Nicolas Goaziou
Hello, Bastien writes: > Juan Manuel Macías writes: > >> Done! I've attached the corrected patch. Sorry for the flaws in me >> previous patch: I'm a bit of a novice at submitting patches... > > applied in the maint branch as commit 5be650714. Unfortunately, this is not a proper fix for the

Re: [PATCH]

2021-04-28 Thread Bastien
Hi Timothy, Timothy writes: > Bastien writes: > >> Feel free to install changes when they have reached consensus, >> or to ask for decisions when not. > > Thanks for the reply Bastien, would you mind elaborating on this a bit > more? I'm comfortable with the idea of what I can do with

Re: [PATCH]

2021-04-28 Thread Bastien
Hi Timothy, TEC writes: > This is just some tweaks to the styling in ox-html that I think may > appeal (and prevent ridiculously long lines on non-small displays, which > are an issue for legibility). > > I also took the opportunity to remove the (obsolete) CDATA strings and > make the CSS more

Re: [WDYT, mini] key h in agenda for quick help

2021-04-28 Thread Tim Cross
Bastien writes: > Timothy writes: > >> Great to hear! I think this would probably be developed as a branch like >> wip-cite-new > > Yes. > >> , and it would need transient to be installed (via ELPA?) on >> Emacs <28, but I think it has the potential to both: >> - Improve the user experience,

Re: org agenda bug — diary-sexp-entry-symbol is not respected

2021-04-28 Thread Bastien
Hi Joe, Joe Corneli via "General discussions about Org-mode." writes: > The string "%%" is hard coded here as a date prefix: > https://code.orgmode.org/bzg/org-mode/src/master/lisp/org-agenda.el#L5648 > > Shouldn’t this be diary-sexp-entry-symbol to allow local overrides, > etc.? Yes -- also

bug#45915: 27.1.91; deletechar distorts org-table

2021-04-28 Thread Bastien
Tak Kunihiro writes: > I confirm that there still is following problem on 27.1.91. > Could someone take a look and show me work around? I cannot reproduce this with latest Org stable version 9.4.5. Can you try again and report? See https://orgmode.org/org.html#Installation on how to install