Re: [Bug] org-in-src-block-p returns t when not in source block

2023-11-28 Thread Jens Schmidt
On 2023-11-27 21:30, Ihor Radchenko wrote: > Fixed, on main. > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=6d7c7917a Which is currently my HEAD, and there are still edge cases that do not seem to be handled well. Start off from "make vanilla" and the following buffer

How to get the inner boundaries of a block

2023-11-27 Thread Jens Schmidt
Triggered by a recent question here on `org-in-src-block-p' and a current need: Is there a function already available that returns the *inner* boundaries of an arbitrary block element? For the element corresponding to the block below: #+begin_verse ^A foo bar baz^B #+end_verse that

[BUG] org-comment-dwim does not work with temporary Transient Mark mode [9.7-pre (release_9.6.10-902-g41ff56 @ /home/jschmidt/work/org-mode/lisp/)]

2023-10-26 Thread Jens Schmidt
* Reproducer Save the following files: - /tmp/test.org - #+begin_src bash foo bar baz #+end_src - /tmp/test.org - - /tmp/test.el -

Support for buffer-column-aligned tables in Org?

2023-10-25 Thread Jens Schmidt
Is there any kind of support (also by non-core extensions) for tables in Org that are entirely organized along buffer columns? Some magic (= clever heuristics) that recognizes the following as a table with four columns, the first three left-aligned, the last right-aligned: <6>

Re: [RFC] Quoting property names in tag/property matches [Was: [BUG?] Matching tags: & operator no more implicit between tags and special property]

2023-09-03 Thread Jens Schmidt
On 2023-09-03 08:53, Ihor Radchenko wrote: > Jens Schmidt writes: > >> Implemented in the next version of the patch, please check. >> > > Applied, onto main. Thanks!

Re: [RFC] Quoting property names in tag/property matches

2023-09-02 Thread Jens Schmidt
On 2023-09-02 09:10, Ihor Radchenko wrote: > Jens Schmidt writes: >> - Even if we made "&" mandatory, it would not really solve the quoting >> problem, since the parser is rather hacky and other quoting and >> context issues would still be there. > >

Re: Redoing the current tag/property parser in a real grammar [was: Re: [RFC] Quoting property names in tag/property matches]

2023-09-02 Thread Jens Schmidt
On 2023-09-02 09:10, Ihor Radchenko wrote: > Jens Schmidt writes: >> This all calls for a proper parser, based on peg or bovine or whatever. >> Hopefully that parser would still keep backward compatibility, but >> that's probably wishful thinking. > > Backward compat

Re: [RFC] Quoting property names in tag/property matches [Was: [BUG?] Matching tags: & operator no more implicit between tags and special property]

2023-09-01 Thread Jens Schmidt
On 2023-08-27 09:43, Ihor Radchenko wrote: > Samuel Loury writes: > >> IMHO, "-tag&-todo=TODO" is totally ok. I even imagine we could say that >> & and | are forbidden to say anything else than AND and OR and people >> would be ok with that. > > Actually, explicit & or | might be an easier way

Re: [RFC] Quoting property names in tag/property matches [Was: [BUG?] Matching tags: & operator no more implicit between tags and special property]

2023-08-31 Thread Jens Schmidt
On 2023-08-31 10:08, Ihor Radchenko wrote: > Jens Schmidt writes: > >>> Implemented in the next version of the patch, please check. >> >> Gentle ping ... > > I was waiting for your comment on > https://list.orgmode.org/orgmode/874jklhqw2.fsf@localhost/ Ah,

Re: [RFC] Quoting property names in tag/property matches [Was: [BUG?] Matching tags: & operator no more implicit between tags and special property]

2023-08-30 Thread Jens Schmidt
On 2023-08-26 14:54, Jens Schmidt wrote: > On 2023-08-26 14:22, Ihor Radchenko wrote: >> Looks good to me. > > Implemented in the next version of the patch, please check. Gentle ping ...

Re: [RFC] Quoting property names in tag/property matches [Was: [BUG?] Matching tags: & operator no more implicit between tags and special property]

2023-08-26 Thread Jens Schmidt
On 2023-08-26 14:22, Ihor Radchenko wrote: > Jens Schmidt writes: >> #+begin_example >> boss\-prio="C" >> boss\:prio="C" >> boss\\prio="C" >> #+end_example > > Looks good to me. Implemented in the next version of the patch,

Re: [RFC] Quoting property names in tag/property matches [Was: [BUG?] Matching tags: & operator no more implicit between tags and special property]

2023-08-26 Thread Jens Schmidt
On 2023-08-26 14:00, Ihor Radchenko wrote: > Jens Schmidt writes: >> On 2023-08-26 12:16, Ihor Radchenko wrote: >>> This actually feels rather cubersome. >> >> [...] I can >> provide a simpler example in the manual, but that's probably not >> what

Re: [RFC] Quoting property names in tag/property matches [Was: [BUG?] Matching tags: & operator no more implicit between tags and special property]

2023-08-26 Thread Jens Schmidt
On 2023-08-26 12:16, Ihor Radchenko wrote: > Jens Schmidt writes: >> #+begin_example >> -+-long-and-twisted-property-name-="foo" >> +\-long\=and\\twisted\:property\.name\*="foo" >> #+end_example > > This actually feels rather cubersome.

Re: [RFC] Quoting property names in tag/property matches [Was: [BUG?] Matching tags: & operator no more implicit between tags and special property]

2023-08-25 Thread Jens Schmidt
On 2023-08-24 10:52, Jens Schmidt wrote: > On 2023-08-24 09:32, Ihor Radchenko wrote: >> I prefer (B). And we will need to allow escaping of the "\" itself. Like >> \\. > > OK. Since backslash is not used yet in the rest of the regexp, (B) > sh

Re: [BUG] "make check" reports a failure on test-org/insert-heading @ d5ee33f (this time with Emacs 29)

2023-08-24 Thread Jens Schmidt
On 2023-08-24 14:24, Ihor Radchenko wrote: > Jens Schmidt writes: > >> Would you mind if I added a test that explicitly and with some nice >> error message tests for that condition? I.e. if some unwary user >> strips off trailing whitespace in test-org.

Re: [BUG] "make check" reports a failure on test-org/insert-heading @ d5ee33f (this time with Emacs 29)

2023-08-24 Thread Jens Schmidt
On 2023-08-24 13:41, Ihor Radchenko wrote: > Jens Schmidt writes: > >> Seems the insert-heading-issue is still struggling, this time during >> a "make check" @ d5ee33fed8dd80d3f9f9811d86a73827fde80780 using Emacs 29: >> ... >>FAILED 998/109

[BUG] "make check" reports a failure on test-org/insert-heading @ d5ee33f (this time with Emacs 29)

2023-08-24 Thread Jens Schmidt
Seems the insert-heading-issue is still struggling, this time during a "make check" @ d5ee33fed8dd80d3f9f9811d86a73827fde80780 using Emacs 29: Test test-org/insert-heading condition: (ert-test-failed ((should (equal "* 1\n** 1.1\n** 1.2\n*\n* 2"

Re: [BUG] Compilation warnings when making main @ d5ee33fed8dd80d3f9f9811d86a73827fde80780

2023-08-24 Thread Jens Schmidt
On 2023-08-24 13:18, Ihor Radchenko wrote: > Jens Schmidt writes: > >> Compiling /home/jschmidt/work/org-mode/lisp/org-element-ast.el... >> >> In org-element--properties-mapc: >> org-element-ast.el:628:25:Warning: ‘not’ called with 3 args, but requires 1 >&g

[BUG] Compilation warnings when making main @ d5ee33fed8dd80d3f9f9811d86a73827fde80780

2023-08-24 Thread Jens Schmidt
Compiling /home/jschmidt/work/org-mode/lisp/org-cycle.el... Compiling /home/jschmidt/work/org-mode/lisp/org-datetree.el... Compiling /home/jschmidt/work/org-mode/lisp/org-duration.el... Compiling /home/jschmidt/work/org-mode/lisp/org-element-ast.el... In org-element--properties-mapc:

Re: [RFC] Quoting property names in tag/property matches [Was: [BUG?] Matching tags: & operator no more implicit between tags and special property]

2023-08-24 Thread Jens Schmidt
On 2023-08-24 09:32, Ihor Radchenko wrote: > Jens Schmidt writes: >> Some obvious choice would be a simpler single backslash >> >> (B) "\-" => "-" > > I prefer (B). And we will need to allow escaping of the "\" itself.

Re: [RFC] Quoting property names in tag/property matches [Was: [BUG?] Matching tags: & operator no more implicit between tags and special property]

2023-08-23 Thread Jens Schmidt
On 2023-08-23 16:00, Jens Schmidt wrote: > Given the property name syntax in > > https://orgmode.org/worg/org-syntax.html#Node_Properties > > the subre in `org-make-tags-matcher' to match property names > should then look similar to > > "\\(

Re: [RFC] Quoting property names in tag/property matches [Was: [BUG?] Matching tags: & operator no more implicit between tags and special property]

2023-08-23 Thread Jens Schmidt
> On 2023-08-23 12:31, Ihor Radchenko wrote: > >> Jens, we got an edge case with "-", after all. >> >> What is happening here is that the new parser >> (https://orgmode.org/list/9132e58f-d89e-f7df-bbe4-43d53a236...@vodafonemail.de) >> treats the above match string as >> >> property "tag-TODO"

Re: [BUG?] Matching tags: & operator no more implicit between tags and special property

2023-08-23 Thread Jens Schmidt
On 2023-08-23 12:31, Ihor Radchenko wrote: > Jens, we got an edge case with "-", after all. > > What is happening here is that the new parser > (https://orgmode.org/list/9132e58f-d89e-f7df-bbe4-43d53a236...@vodafonemail.de) > treats the above match string as > > property "tag-TODO" not equal

Re: [BUG?] Matching tags: & operator no more implicit between tags and special property

2023-08-23 Thread Jens Schmidt
Thanks for the detailed report! On 2023-08-23 09:57, Samuel Loury wrote: > The following tags query used to implicitly behave as a AND > "-tag-TODO=\"TODO\"". > Before commit f689eb44f175fbbdc4e8ef0ad6f5201b10863438, this showed only > "nothing", as expected. That was my short-sighted attempt

Re: Or probably just fix the org-ctags hook functions?

2023-08-11 Thread Jens Schmidt
On 2023-08-11 23:48, Ihor Radchenko wrote: - If you run into this issue, the real pain is to understand what's going on, since org-ctags might get loaded in surprising ways. So probably we should make that easier. The quick fix is unsetting `help-enable-completion-autoload'.

Re: Or probably just fix the org-ctags hook functions?

2023-08-11 Thread Jens Schmidt
On 2023-08-11 19:01, Nick Dokos wrote: Sure, but we should not reject Jens' proposal just because of this argument. We can use the suggestions to improve org-ctags itself, after it is explicitly loaded. Absolutely. My disagreement was only with the part that I quoted, in particular the

Re: Or probably just fix the org-ctags hook functions? (was: Should we accept breaking changes ...)

2023-08-09 Thread Jens Schmidt
On 2023-08-08 10:48, Ihor Radchenko wrote: The situation is a bit more complex. To make it even more complex, here a different point of view. Sorry, I don't have any earlier mails ready I could reply to ... * TL;DR Probably the problem is not the side-effects done by loading =org-ctags=,

Re: [BUG] `org-open-at-point' surprisingly asks for tags table [9.7-pre (release_9.6.7-640-ga18ebc @ /home/jschmidt/work/org-mode/lisp/)]

2023-08-08 Thread Jens Schmidt
Sorry, just followed that recent side-effect-thread to the root https://list.orgmode.org/orgmode/87o7omg4ie@alphaville.usersys.redhat.com/ and found that everything already got documented. It was that thread that triggered my bug report as an example of a particular nasty side effect.

[BUG] `org-open-at-point' surprisingly asks for tags table [9.7-pre (release_9.6.7-640-ga18ebc @ /home/jschmidt/work/org-mode/lisp/)]

2023-08-08 Thread Jens Schmidt
make EMACS=../emacs-master/src/emacs vanilla Create a new Org-mode buffer with the following contents: -- <> [[test][test link]] -- Position point on the link then type C-c C-o: Point jumps to the

Re: org-agenda queries for absent properties

2023-08-07 Thread Jens Schmidt
gv" means "getter value" and be done with it. Updated patch attached.From 6e98356dfaf3466288398ff4ecee7fd147c32a20 Mon Sep 17 00:00:00 2001 From: Jens Schmidt Date: Sun, 6 Aug 2023 16:38:04 +0200 Subject: [PATCH] org-make-tags-matcher: Add starred property operators, fix quoting * lisp/org.e

Re: org-agenda queries for absent properties

2023-08-06 Thread Jens Schmidt
On 2023-08-06 11:19, Jens Schmidt wrote: I will also add tests for matching property names having minuses and then we can see how it goes. Went well. With a property name regexp "\\(?5:[[:alnum:]_-]+\\)" and the following Org file -

Re: org-agenda queries for absent properties

2023-08-06 Thread Jens Schmidt
On 2023-08-06 09:55, Ihor Radchenko wrote: But from here it gets more intersting: - The code uses subre "-" in property names to (supposedly) allow for inclusion of minus characters in property names, which (probably) could be confused with term negation. Not probably. It is

Re: org-agenda queries for absent properties

2023-08-05 Thread Jens Schmidt
or parsing. Given the fact that we have to discuss issues like those above, I heartily agree. > https://yhetil.org/emacs-devel/875yvtbbn3@ericabrahamsen.net/ Arthouse thread: Interesting plot, surprising sidelines, not everything comprehensible, (unfortunately) open end. From 1765e91d2f78

Re: org-agenda queries for absent properties

2023-08-01 Thread Jens Schmidt
On 2023-07-31 08:45, Ihor Radchenko wrote: If you are up to a job of adding this to `org-make-tags-matcher' and not breaking things, you can try. Depends a bit on the required collateral changes: Updating ORG-NEWS and doc/org-guide.org should be no problem. Doing a naive grep-based search I

org-agenda queries for absent properties

2023-07-30 Thread Jens Schmidt
The following was initially meant as bug report until I understood that it's actually some sort of feature ... Consider the following todo list: todos.org * TODO relax * TODO do this :PROPERTIES: :patchday: 202302 :END: * TODO do that :PROPERTIES:

Re: [BUG] Issues in ol-gnus when storing links in nnvirtual and nnselect articles [9.7-pre (release_9.6.7-570-gd6f3ae.dirty @ /home/jschmidt/work/org-mode/lisp/)]

2023-07-30 Thread Jens Schmidt
look right now? From 74d5c1f5caf4ce425eb888340c2115276b4ddf8a Mon Sep 17 00:00:00 2001 From: Jens Schmidt Date: Sun, 30 Jul 2023 17:51:27 +0200 Subject: [PATCH] ol-gnus.el: Fix issue when storing links from Gnus article buffers * lisp/ol-gnus.el (org-gnus-store-link): Switch to `gnus-summary

Minimal Gnus setup for test purposes

2023-07-26 Thread Jens Schmidt
In the context of some ol-gnus bug I created a minimal Gnus setup. Ihor wanted to have a look at it, so here it is. To use: - create an empty directory /foo/bar/baz and say unzip -qd /foo/bar/baz gnus-minimal-test.zip - if you want to use the nnselect backend based on notmuch (haven't

Re: [BUG] Issues in ol-gnus when storing links in nnvirtual and nnselect articles [9.7-pre (release_9.6.7-570-gd6f3ae.dirty @ /home/jschmidt/work/org-mode/lisp/)]

2023-07-26 Thread Jens Schmidt
On 2023-07-26 18:04, Ihor Radchenko wrote: This is not a proper email address and name. Should I use Jens Schmidt ? Sorry, forgot to maintain that yet in my org-mode clone. Will do. May you please add TINYCHANGE cookie to commit message. I do not see you having a copyright status in our

Re: Subscript entity in the name of files or some advise for alternatives

2023-07-25 Thread Jens Schmidt
On 2023-07-25 01:08, Ypo wrote: Why did you try that variable instead of "org-pretty-entities-include-sub-superscripts"? To be honest: Because I haven't read your mail properly and because I didn't know about "pretty entities". I just noticed the subscripting done on such_file_names in Org

Re: Subscript entity in the name of files or some advise for alternatives

2023-07-24 Thread Jens Schmidt
On 2023-07-24 21:12, Ypo wrote: I wanted it, because I usually use (_) to divide words when naming my_files, and that looks ugly in Orgmode. I had that problem myself recently. Do `org-use-sub-superscripts' and its companion `org-export-with-sub-superscripts' help in your case? See also

Re: [BUG] Issues in ol-gnus when storing links in nnvirtual and nnselect articles [9.7-pre (release_9.6.7-570-gd6f3ae.dirty @ /home/jschmidt/work/org-mode/lisp/)]

2023-07-24 Thread Jens Schmidt
Uh, I had technical issues and did not get all mails as I expected. Cobbling things together in one big reply now, with references and quotes hopelessly broken ... hope you can sort it out. Anyway, thanks to Eric for chiming in. > Ideally, it would be nice to have tests, though I have no clue

Re: [BUG] Issues in ol-gnus when storing links in nnvirtual and nnselect articles [9.7-pre (release_9.6.7-570-gd6f3ae.dirty @ /home/jschmidt/work/org-mode/lisp/)]

2023-07-23 Thread Jens Schmidt
On 2023-07-23 12:26, Max Nikulin wrote: Is nnselect a real NNTP group or is it some instance existing solely in user's configuration? Like nnvirtual and nnir, nnselect exists only in user's configuration, yes. All these three backends are "wrapper backends" that keep track of the original

Re: [BUG] Issues in ol-gnus when storing links in nnvirtual and nnselect articles [9.7-pre (release_9.6.7-570-gd6f3ae.dirty @ /home/jschmidt/work/org-mode/lisp/)]

2023-07-22 Thread Jens Schmidt
On 2023-07-22 15:48, Ihor Radchenko wrote: I am not familiar with Gnus, but looking at the code, may it be that a Gnus article is open when Gnus summary buffer is not? Theoretically yes, if you actively and malignantly kill the summary buffer, for example. In practice and through Gnus key

[BUG] Issues in ol-gnus when storing links in nnvirtual and nnselect articles [9.7-pre (release_9.6.7-570-gd6f3ae.dirty @ /home/jschmidt/work/org-mode/lisp/)]

2023-07-22 Thread Jens Schmidt
Tags: patch `org-store-link' has a number of related issues when storing links from article buffers related to nnvirtual, nnselect, or nnir groups. I describe them here in prose without providing a full repro case, which would be somewhat difficult to set up. Just let me know if you think you

Re: [BUG] SPACE jumps to tag in header line after hidden emphasis marker [9.7-pre (release_9.6.7-562-g5b6268 @ /home/jschmidt/work/org-mode/lisp/)]

2023-07-20 Thread Jens Schmidt
On 2023-07-18 10:13, Ihor Radchenko wrote: No, it is space. In particular, it is `org--align-tags-here' + some bug in Emacs that screws up column computation. https://debbugs.gnu.org/cgi/bugreport.cgi?bug=64696 FWIW the third test yields ■ Warning (emacs): Test #3:: ’word’ is hidden

Re: [BUG] SPACE jumps to tag in header line after hidden emphasis marker [9.7-pre (release_9.6.7-562-g5b6268 @ /home/jschmidt/work/org-mode/lisp/)]

2023-07-19 Thread Jens Schmidt
On 2023-07-19 09:10, Ihor Radchenko wrote: I see no good way to address this quickly, so I re-added stickiness to the opening emphasis marker, as you suggested. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=724135dda Follow-ups: 1.

Re: [BUG] SPACE jumps to tag in header line after hidden emphasis marker [9.7-pre (release_9.6.7-562-g5b6268 @ /home/jschmidt/work/org-mode/lisp/)]

2023-07-18 Thread Jens Schmidt
[Resent with correct identity to make this visible on the list as well - sorry for the hassle.] On 2023-07-18 10:13, Ihor Radchenko wrote: Confirmed. Thanks for caring about this so quickly ... https://debbugs.gnu.org/cgi/bugreport.cgi?bug=64696 ... and for the discussion with Eli &

[BUG] SPACE jumps to tag in header line after hidden emphasis marker [9.7-pre (release_9.6.7-562-g5b6268 @ /home/jschmidt/work/org-mode/lisp/)]

2023-07-17 Thread Jens Schmidt
[emacs-29]$ ./src/emacs -Q -L ~jschmidt/work/org-mode/lisp/ (org-version nil t) "Org mode version 9.7-pre (release_9.6.7-562-g5b6268 @ /home/jschmidt/work/org-mode/lisp/)" (setq org-hide-emphasis-markers t) t ;; assume test.org being absent in cwd C-x 4 f ;; find-file-other-window t

Re: Where does headline data end for the purpose of `org-adapt-indentation´ == ´headline-data

2023-06-14 Thread Jens Schmidt
On 2023-06-09 09:34, Ihor Radchenko wrote: Emacs master tracks the latest stable Org release. OK, so I cobbled up Org main with branch emacs-29. ./src/emacs -Q M-x org-version Org mode version 9.7-pre (release_9.6.6-408-g9082fa @ ...) (setq org-adapt-indentation 'headline-data) Paste

Re: [BUG] Filling in source blocks fills by region, not paragraph [9.5.5 (release_9.5.5/master)]

2023-05-03 Thread Jens Schmidt
Forget about that one, it is already fixed in master. I had the wrong load path and used actually 9.5.5 and not org-mode cloned from master, as intended.